Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: list with -export and -covermode=atomic fails to build [1.21 backport] #68221

Closed
gopherbot opened this issue Jun 27, 2024 · 2 comments
Closed

cmd/go: list with -export and -covermode=atomic fails to build [1.21 backport] #68221

gopherbot opened this issue Jun 27, 2024 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases GoCommand cmd/go
Milestone
Go1.21.13

Comments

@gopherbot
Copy link
Contributor

@matloob requested issue #65264 to be considered for backport to the next 1.21 minor release.

@gopherbot please backport to Go 1.21 and Go 1.22
@gopherbot gopherbot added CherryPickCandidate Used during the release process for point releases GoCommand cmd/go labels Jun 27, 2024
@gopherbot gopherbot mentioned this issue Jun 27, 2024
Closed
@gopherbot gopherbot added this to the Go1.21.12 milestone Jun 27, 2024
@matloob matloob mentioned this issue Jun 27, 2024
Open
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/595495 mentions this issue: [release-branch.go1.21] cmd/go: fix build config before creating actions for 'go list -cover'

@matloob matloob added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Jun 27, 2024
@gopherbot gopherbot modified the milestones: Go1.21.12, Go1.21.13 Jul 2, 2024
gopherbot pushed a commit that referenced this issue Jul 10, 2024
@cixel @cagedmantis
[release-branch.go1.21] cmd/go: fix build config before creating acti…
e073feb 
…ons for 'go list -cover'

When -covermode is set to atomic, instrumented packages need to import
sync/atomic. If this is not already imported by a package being
instrumented, the build needs to ensure that sync/atomic is compiled
whenever 'go list' is run in a way that triggers package builds.

The build config was already being made to ensure the import, but only
after the action graph had been created, so there was no guarantee that
sync/atomic would be built when needed.

For #65264
For #68212
Fixes #68221

Change-Id: Ib3f1e102ce2ef554ea08330d9db69a8c98790ac5
Reviewed-on: https://go-review.googlesource.com/c/go/+/560236
Run-TryBot: Bryan Mills <[email protected]>
Auto-Submit: Bryan Mills <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Bryan Mills <[email protected]>
Reviewed-by: Michael Matloob <[email protected]>
(cherry picked from commit ac08c05)
Reviewed-on: https://go-review.googlesource.com/c/go/+/595495
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-by: Than McIntosh <[email protected]>
Reviewed-by: Sam Thanawalla <[email protected]>
@gopherbot
Copy link
Contributor Author

Closed by merging e073feb to release-branch.go1.21.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases GoCommand cmd/go
Projects
None yet
Milestone
Go1.21.13
Development

No branches or pull requests
2 participants
@gopherbot @matloob