Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/coordinator: stop builders that are ported to LUCI #67761

Closed
dmitshur opened this issue May 31, 2024 · 12 comments
Closed

x/build/cmd/coordinator: stop builders that are ported to LUCI #67761

dmitshur opened this issue May 31, 2024 · 12 comments
Assignees
@dmitshur
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@dmitshur
Copy link
Contributor

This is a tracking issue to trim down coordinator, stopping more of the builders that have been ported to LUCI. This builds on top of the previous dashboard work in #65913.

CC @golang/release.
@dmitshur dmitshur added Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. labels May 31, 2024
@dmitshur dmitshur added this to the Unreleased milestone May 31, 2024
@dmitshur dmitshur self-assigned this May 31, 2024
@dmitshur dmitshur moved this to In Progress in Go Release May 31, 2024
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/586776 mentions this issue: dashboard: stop running misc-compile trybots

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/589657 mentions this issue: internal/migration: add a small package to hold migration knobs

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/589659 mentions this issue: dashboard: stop running macOS builders

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/589660 mentions this issue: dashboard: stop running Windows builders

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/589661 mentions this issue: dashboard: stop running Linux builders

gopherbot pushed a commit to golang/build that referenced this issue Jun 3, 2024
@dmitshur @gopherbot
internal/migration: add a small package to hold migration knobs
b70af65 
I'm looking to largely leave existing coordinator code alone as
it's being gradually shut down, before being eventually deleted.
This makes it easier to look up past behaviors.

Add a small internal package that can be imported both by dashboard and
coordinator. It'll hold some state that controls what's been turned off.

For golang/go#67761.

Change-Id: Iff3615418307fbd925590ccc98306374bb7891ac
Reviewed-on: https://go-review.googlesource.com/c/build/+/589657
Auto-Submit: Dmitri Shuralyov <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-by: Michael Knyszek <[email protected]>
gopherbot pushed a commit to golang/build that referenced this issue Jun 3, 2024
@dmitshur @gopherbot
dashboard: stop running misc-compile trybots
6fefa43 
The misc-compile trybots have been ported to LUCI, which is required to
run on each CL now, so it's safe to shut down the old misc-compile bots.

For golang/go#67761.

Change-Id: I860506a6ab113041f0296356c20c4984c86f1c9c
Reviewed-on: https://go-review.googlesource.com/c/build/+/586776
Reviewed-by: Michael Knyszek <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
Auto-Submit: Dmitri Shuralyov <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
gopherbot pushed a commit to golang/build that referenced this issue Jun 3, 2024
@dmitshur @gopherbot
dashboard: stop running macOS builders
5368811 
All of them have been ported to LUCI. Stop running the previous ones
and disable their health check.

For golang/go#67761.

Change-Id: I1128322aa216341641878c785773339bffcf799e
Reviewed-on: https://go-review.googlesource.com/c/build/+/589659
Reviewed-by: Michael Pratt <[email protected]>
Auto-Submit: Dmitri Shuralyov <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
gopherbot pushed a commit to golang/build that referenced this issue Jun 3, 2024
@dmitshur @gopherbot
dashboard: stop running Windows builders
14f081d 
All of them have been ported to LUCI. Stop running the previous ones.

For golang/go#67761.

Change-Id: I1ccd262b18cefcc03471e40ccc2659b703721be7
Reviewed-on: https://go-review.googlesource.com/c/build/+/589660
Reviewed-by: Michael Knyszek <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
Auto-Submit: Dmitri Shuralyov <[email protected]>
gopherbot pushed a commit to golang/build that referenced this issue Jun 3, 2024
@dmitshur @gopherbot
dashboard: stop running Linux builders
5dfbda4 
Stop running the Linux builders that have been ported to LUCI.
Update some tests so it's viable not to delete them yet.

For golang/go#67761.

Change-Id: Iec53744970f478a63ec6792c3f46d49b17938ec6
Reviewed-on: https://go-review.googlesource.com/c/build/+/589661
Auto-Submit: Dmitri Shuralyov <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
Reviewed-by: Michael Knyszek <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/591156 mentions this issue: dashboard: stop expecting macOS and Windows reverse builders

gopherbot pushed a commit to golang/build that referenced this issue Jun 6, 2024
@dmitshur @gopherbot
dashboard: stop expecting macOS and Windows reverse builders
e41b086 
These coordinator-specific reverse builders have stopped doing work
as CL 589659 and CL 589660. They're being stopped and so they're no
longer expected to connect to the coordinator.

For golang/go#67761.

Change-Id: Id3a4ab94e24a57bd5dc3db900dd486e348857682
Reviewed-on: https://go-review.googlesource.com/c/build/+/591156
Reviewed-by: Dmitri Shuralyov <[email protected]>
Reviewed-by: Carlos Amedee <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
Auto-Submit: Dmitri Shuralyov <[email protected]>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/592755 mentions this issue: DashboardBuilders: remove steps to add builders to legacy system

gopherbot pushed a commit to golang/wiki that referenced this issue Jun 14, 2024
@dmitshur @gopherbot
DashboardBuilders: remove steps to add builders to legacy system
ee7917e 
The migration to LUCI is far along now that we aren't adding any more
new builders to coordinator. Remove the instructions for doing that,
and also move the LUCI section to be on top. This will unfortunately
require some links to be updated, but there's no way to avoid that.

Keep the security note section since its content generally applies
to the new system too.

For golang/go#67761.

Change-Id: I338b5622b1f9020539d1ab309f39127a4f3e0c93
Reviewed-on: https://go-review.googlesource.com/c/wiki/+/592755
Reviewed-by: Carlos Amedee <[email protected]>
Auto-Submit: Dmitri Shuralyov <[email protected]>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/596155 mentions this issue: dashboard: stop running Linux perf builder

gopherbot pushed a commit to golang/build that referenced this issue Jul 2, 2024
@dmitshur @gopherbot
dashboard: stop running Linux perf builder
0807931 
The performance testing builders have been migrated to LUCI.

For golang/go#67761.

Change-Id: Ib6816c5f58f7cfd59b340827f07d2a87830b42bb
Reviewed-on: https://go-review.googlesource.com/c/build/+/596155
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-by: Michael Pratt <[email protected]>
Auto-Submit: Dmitri Shuralyov <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/601237 mentions this issue: dashboard: stop running remaining ported builders

@github-project-automation github-project-automation bot moved this from In Progress to Done in Go Release Jul 26, 2024
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/607656 mentions this issue: internal/migration: stop running plan9/{386,arm} builders

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/612559 mentions this issue: cmd/coordinator: stop EC2 buildlet pool

gopherbot pushed a commit to golang/build that referenced this issue Sep 12, 2024
@dmitshur @gopherbot
cmd/coordinator: stop EC2 buildlet pool
4ca568d 
All EC2 builders have been migrated to LUCI and stopped in coordinator.
Stop the pool as well. Its permissions have been revoked and it prints
errors continuously. Also drop an unhelpful printf.

For golang/go#67761.

Change-Id: I6ce48e222a2dc88f7d5a7386f8cc9d5b1e8bac71
Reviewed-on: https://go-review.googlesource.com/c/build/+/612559
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-by: Tim King <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
Auto-Submit: Dmitri Shuralyov <[email protected]>
gopherbot pushed a commit to golang/build that referenced this issue Nov 22, 2024
@dmitshur @gopherbot
internal/migration: stop running plan9/{386,arm} builders
2921ab6 
These builders have been migrated to LUCI.

For golang/go#67761.

Change-Id: I5a1672f42db2f873c94e87aa14f18ec85de92cf5
Reviewed-on: https://go-review.googlesource.com/c/build/+/607656
Reviewed-by: Dmitri Shuralyov <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-by: Michael Pratt <[email protected]>
Auto-Submit: Dmitri Shuralyov <[email protected]>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/646515 mentions this issue: internal/migration: stop running freebsd-amd64-{12_3,13_0,race} builders

gopherbot pushed a commit to golang/build that referenced this issue Feb 5, 2025
@dmitshur @gopherbot
internal/migration: stop running freebsd-amd64-{12_3,13_0,race} builders
fe31b0b 
These builders have been migrated to LUCI.

For golang/go#61095.
For golang/go#67761.

Change-Id: I677b1a4fabe300c048c38f34f3712c118922eb86
Reviewed-on: https://go-review.googlesource.com/c/build/+/646515
Reviewed-by: Michael Knyszek <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
Auto-Submit: Dmitri Shuralyov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmitshur dmitshur

Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release
Archived in project
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot