cmd/compile: Go1.22RC1 compiler crash when using GOEXPERIMENT=rangefunc #64930

bolazec · 2024-01-02T09:20:27Z

What version of Go are you using (`go version`)?

$ go version
go version devel go1.22-fe1b2f95e6 Fri Dec 8 23:05:48 2023 +0000 linux/amd64

Does this issue reproduce with the latest release?

This problem happens with go1.22rc1 when using GOEXPERIMENT=rangefunc

#61405

What operating system and processor architecture are you using (`go env`)?

go env Output

$ go env
GO111MODULE=''
GOARCH='amd64'
GOBIN=''
GOCACHE='/home/rafter/.cache/go-build'
GOENV='/home/rafter/.config/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='amd64'
GOHOSTOS='linux'
GOINSECURE=''
GOMODCACHE='/home/rafter/go/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='linux'
GOPATH='/home/rafter/go'
GOPRIVATE=''
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/home/rafter/go-compilers/go-tip'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='local'
GOTOOLDIR='/home/rafter/go-compilers/go-tip/pkg/tool/linux_amd64'
GOVCS=''
GOVERSION='devel go1.22-fe1b2f95e6 Fri Dec 8 23:05:48 2023 +0000'
GCCGO='gccgo'
GOAMD64='v1'
AR='ar'
CC='gcc'
CXX='g++'
CGO_ENABLED='1'
GOMOD='/dev/null'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build12169918115877555041=/tmp/go-build -gno-record-gcc-switches'
GOROOT/bin/go version: go version devel go1.22-fe1b2f95e6 Fri Dec 8 23:05:48 2023 +0000 linux/amd64
GOROOT/bin/go tool compile -V: compile version devel go1.22-fe1b2f95e6 Fri Dec 8 23:05:48 2023 +0000
uname -sr: Linux 5.4.0-169-generic
Distributor ID:	Ubuntu
Description:	Ubuntu 20.04.6 LTS
Release:	20.04
Codename:	focal
/lib/x86_64-linux-gnu/libc.so.6: GNU C Library (Ubuntu GLIBC 2.31-0ubuntu9.14) stable release version 2.31.
gdb --version: GNU gdb (Ubuntu 9.2-0ubuntu1~20.04.1) 9.2

See the program at https://go.dev/play/p/KyQscllQkMW

With GOEXPERIMENT=rangefunc this program compiles and runs correctly,
which shows that the types and functions are all OK.

However when the commented out for loop is re-enabled the program causes a compiler crash.

What did you expect to see?

No compiler crash, and a program that runs.

What did you see instead?

Compiler Output ...

# example.com/iterators/bugs/bug-1-seq2
: internal compiler error: panic: interface conversion: syntax.Type is *types2.Named, not *types2.Signature
goroutine 1 [running]:

runtime/debug.Stack()

../../../../go-compilers/go-tip/src/runtime/debug/stack.go:24 +0x5e

cmd/compile/internal/base.FatalfAt({0x44a750?, 0xc0?}, {0xdf1b09, 0x9}, {0xc00044a780, 0x1, 0x1})

../../../../go-compilers/go-tip/src/cmd/compile/internal/base/print.go:225 +0x1d7

cmd/compile/internal/base.Fatalf(...)

../../../../go-compilers/go-tip/src/cmd/compile/internal/base/print.go:194

cmd/compile/internal/gc.handlePanic()

../../../../go-compilers/go-tip/src/cmd/compile/internal/gc/main.go:52 +0x90

panic({0xd72320?, 0xc000443890?})

../../../../go-compilers/go-tip/src/runtime/panic.go:770 +0x132

cmd/compile/internal/rangefunc.(*rewriter).endLoop(0xc000154400, 0xc00044e4c0)

../../../../go-compilers/go-tip/src/cmd/compile/internal/rangefunc/rewrite.go:937 +0xa3b

cmd/compile/internal/rangefunc.(*rewriter).inspect(0xc000154400, {0x0?, 0x0?})

../../../../go-compilers/go-tip/src/cmd/compile/internal/rangefunc/rewrite.go:610 +0x3f8

cmd/compile/internal/syntax.inspector.Visit(...)

../../../../go-compilers/go-tip/src/cmd/compile/internal/syntax/walk.go:23

cmd/compile/internal/syntax.walker.node({{0xf5aa00?, 0xc00003b3c0?}}, {0xf5d000, 0xc0004127d0})

../../../../go-compilers/go-tip/src/cmd/compile/internal/syntax/walk.go:315 +0x10b8

cmd/compile/internal/syntax.walker.stmtList(...)

../../../../go-compilers/go-tip/src/cmd/compile/internal/syntax/walk.go:332

cmd/compile/internal/syntax.walker.node({{0xf5aa00?, 0xc00003b3c0?}}, {0xf5c250, 0xc000414200})

../../../../go-compilers/go-tip/src/cmd/compile/internal/syntax/walk.go:222 +0x14f0

cmd/compile/internal/syntax.Walk(...)

../../../../go-compilers/go-tip/src/cmd/compile/internal/syntax/walk.go:41

cmd/compile/internal/syntax.Inspect(...)

../../../../go-compilers/go-tip/src/cmd/compile/internal/syntax/walk.go:17

cmd/compile/internal/rangefunc.rewriteFunc(0xc0003f1e00, 0xc0003f1da0, 0xc000127340, 0xc000414200)

../../../../go-compilers/go-tip/src/cmd/compile/internal/rangefunc/rewrite.go:551 +0xed

cmd/compile/internal/rangefunc.Rewrite.func1({0xf5c1c0?, 0xc0003f19e0?})

../../../../go-compilers/go-tip/src/cmd/compile/internal/rangefunc/rewrite.go:528 +0x58

cmd/compile/internal/syntax.inspector.Visit(...)

../../../../go-compilers/go-tip/src/cmd/compile/internal/syntax/walk.go:23

cmd/compile/internal/syntax.walker.node({{0xf5aa00?, 0xc00040e918?}}, {0xf5c1c0, 0xc0003f19e0})

../../../../go-compilers/go-tip/src/cmd/compile/internal/syntax/walk.go:60 +0x8a

cmd/compile/internal/syntax.walker.declList(...)

../../../../go-compilers/go-tip/src/cmd/compile/internal/syntax/walk.go:320

cmd/compile/internal/syntax.walker.node({{0xf5aa00?, 0xc00040e918?}}, {0xf5c130, 0xc0003f1980})

../../../../go-compilers/go-tip/src/cmd/compile/internal/syntax/walk.go:69 +0x207a

cmd/compile/internal/syntax.Walk(...)

../../../../go-compilers/go-tip/src/cmd/compile/internal/syntax/walk.go:41

cmd/compile/internal/syntax.Inspect(...)

../../../../go-compilers/go-tip/src/cmd/compile/internal/syntax/walk.go:17

cmd/compile/internal/rangefunc.Rewrite(0xc0003f1e00, 0xc0003f1da0, {0xc00005c590, 0x1, 0x1?})

../../../../go-compilers/go-tip/src/cmd/compile/internal/rangefunc/rewrite.go:525 +0x5b

cmd/compile/internal/noder.checkFiles({0x0, {0x0, 0x0}}, {0xc00005c528, 0x1, 0xf6a708?})

../../../../go-compilers/go-tip/src/cmd/compile/internal/noder/irgen.go:148 +0x956

cmd/compile/internal/noder.writePkgStub({0x0?, {0x0?, 0x0?}}, {0xc00005c528, 0x1, 0x1})

../../../../go-compilers/go-tip/src/cmd/compile/internal/noder/unified.go:296 +0x6a

cmd/compile/internal/noder.unified({0x0?, {0x0?, 0x0?}}, {0xc00005c528?, 0xd38440?, 0x0?})

../../../../go-compilers/go-tip/src/cmd/compile/internal/noder/unified.go:172 +0x9a

cmd/compile/internal/noder.LoadPackage({0xc000022230, 0x1, 0x1})

../../../../go-compilers/go-tip/src/cmd/compile/internal/noder/noder.go:77 +0x43a

cmd/compile/internal/gc.Main(0xe2ac48)

../../../../go-compilers/go-tip/src/cmd/compile/internal/gc/main.go:197 +0xbbd

main.main()

../../../../go-compilers/go-tip/src/cmd/compile/main.go:57 +0xf9

The text was updated successfully, but these errors were encountered:

mauri870 · 2024-01-02T10:12:35Z

Tentatively marking as release blocker, but it only affects GOEXPERIMENT=rangefunc.

cc @rsc @golang/release @golang/compiler

gopherbot · 2024-01-02T11:05:22Z

Change https://go.dev/cl/553455 mentions this issue: cmd/compile/internal/rangefunc: handle aliased type in yield func

gopherbot · 2024-01-02T15:35:39Z

Change https://go.dev/cl/553436 mentions this issue: cmd/compile: handle defined iter func type correctly

mauri870 · 2024-01-02T15:50:17Z

@cuonglm I had already started working on a fix in an earlier CL (553455), but I'm open to discard that in favor of your fix.

Out of curiosity, what is the fundamental difference between

ftyp := types2.AsSignature(rfunc.Params().At(0).Type()) // func(...) bool

And

ftyp := types2.CoreType(rfunc.Params().At(0).Type()).(*types2.Signature) // func(...) bool

Since both seem to fix the issue?

cuonglm · 2024-01-02T16:10:37Z

@mauri870 The types2.CoreType can handle type parameter and others. I don't have any concrete example off-hand, but given the fact that we already used types2.CoreType for range expression func(func(...) bool), using it for iter func func(...) bool is more reasonable IMHO.

mauri870 · 2024-01-02T17:27:35Z

@mauri870 The types2.CoreType can handle type parameter and others. I don't have any concrete example off-hand, but given the fact that we already used types2.CoreType for range expression func(func(...) bool), using it for iter func func(...) bool is more reasonable IMHO.

Makes sense, thanks!

Fixed golang#64930 Change-Id: I916de7f97116fb20cb2f3f0b425ac34409afd494 Reviewed-on: https://go-review.googlesource.com/c/go/+/553436 LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Matthew Dempsky <[email protected]> Auto-Submit: Cuong Manh Le <[email protected]>

mauri870 added NeedsFix The path to resolution is known, but the work has not been done. release-blocker compiler/runtime Issues related to the Go compiler and/or runtime. labels Jan 2, 2024

mauri870 changed the title ~~Go1.22RC1 compiler crash when using GOEXPERIMENT=rangefunc~~ cmd/compile: Go1.22RC1 compiler crash when using GOEXPERIMENT=rangefunc Jan 2, 2024

mauri870 mentioned this issue Jan 2, 2024

cmd/compile/internal/rangefunc: handle aliased type in yield func #64931

Closed

mauri870 self-assigned this Jan 2, 2024

mauri870 added this to the Go1.22 milestone Jan 2, 2024

mauri870 assigned mauri870 and cuonglm and unassigned mauri870 Jan 2, 2024

mknyszek added this to Go Compiler / Runtime Jan 3, 2024

mdempsky moved this to In Progress in Go Compiler / Runtime Jan 3, 2024

gopherbot closed this as completed in 881869d Jan 8, 2024

github-project-automation bot moved this from In Progress to Done in Go Compiler / Runtime Jan 8, 2024

mknyszek removed this from Go Compiler / Runtime Feb 28, 2024

gabyhelp mentioned this issue Jul 19, 2024

cmd/compile: importing generic alias types is not supported in 1.23 #68526

Closed

gabyhelp mentioned this issue Aug 15, 2024

runtime: confusing panic on parallel calls to yield function #68897

Open

gabyhelp mentioned this issue Sep 17, 2024

cmd/compile: mysterious crashes and non-determinism with range over func #69507

Closed

gabyhelp mentioned this issue Oct 11, 2024

import/path: issue title #69851

Closed

golang locked and limited conversation to collaborators Jan 7, 2025

gopherbot added the FrozenDueToAge label Jan 7, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cmd/compile: Go1.22RC1 compiler crash when using GOEXPERIMENT=rangefunc #64930

cmd/compile: Go1.22RC1 compiler crash when using GOEXPERIMENT=rangefunc #64930

bolazec commented Jan 2, 2024 •

edited

Loading

mauri870 commented Jan 2, 2024 •

edited

Loading

gopherbot commented Jan 2, 2024

gopherbot commented Jan 2, 2024

mauri870 commented Jan 2, 2024

cuonglm commented Jan 2, 2024

mauri870 commented Jan 2, 2024

cmd/compile: Go1.22RC1 compiler crash when using GOEXPERIMENT=rangefunc #64930

cmd/compile: Go1.22RC1 compiler crash when using GOEXPERIMENT=rangefunc #64930

Comments

bolazec commented Jan 2, 2024 • edited Loading

What version of Go are you using (go version)?

Does this issue reproduce with the latest release?

What operating system and processor architecture are you using (go env)?

What did you expect to see?

What did you see instead?

mauri870 commented Jan 2, 2024 • edited Loading

gopherbot commented Jan 2, 2024

gopherbot commented Jan 2, 2024

mauri870 commented Jan 2, 2024

cuonglm commented Jan 2, 2024

mauri870 commented Jan 2, 2024

bolazec commented Jan 2, 2024 •

edited

Loading

What version of Go are you using (`go version`)?

What operating system and processor architecture are you using (`go env`)?

mauri870 commented Jan 2, 2024 •

edited

Loading