x/tools/gopls: hover stops working

[pjweinb]

gopls version

Build info ---------- golang.org/x/tools/gopls v0.14.2 golang.org/x/tools/[email protected] h1:sIw6vjZiuQ9S7s0auUUkHlWgsCkKZFWDHmrge8LYsnc= github.com/BurntSushi/[email protected] h1:9F2/+DoOYIOksmaJFPw1tGFy1eDnIJXg+UHjuD8lTak= github.com/google/[email protected] h1:O2Tfq5qg4qc4AmwVlvv0oLiVAGB7enBSJ2x2DqQFi38= github.com/sergi/[email protected] h1:we8PVUC3FE2uYfodKH/nBHMSetSfHDR6scGdBi+erh0= golang.org/x/exp/[email protected] h1:2O2DON6y3XMJiQRAS1UWU+54aec2uopH3x7MAiqGW6Y= golang.org/x/[email protected] h1:dGoOF9QVLYng8IHTm7BAyWqCqSheQ5pYWGhzW00YJr0= golang.org/x/[email protected] h1:zxkM55ReGkDlKSM+Fu41A+zmbZuaPVbGMzvvdUPznYQ= golang.org/x/[email protected] h1:Vz7Qs629MkJkGyHxUlRHizWJRG2j8fbQKjELVSNhy7Q= golang.org/x/[email protected] h1:brbkEFfGwNGAEkykUOcryE/JiHUMMJouzE0fWWmz/QU= golang.org/x/[email protected] h1:ablQoSUd0tRdKxZewP80B+BaqeKJuVhuRxj/dkrun3k= golang.org/x/[email protected] h1:Oku7E+OCrXHyst1dG1z10etCTxewCHXNFLRlyMPbh3w= golang.org/x/vuln

go env

GO111MODULE=''
GOARCH='amd64'
GOBIN=''
GOCACHE='/Users/pjw/Library/Caches/go-build'
GOENV='/Users/pjw/Library/Application Support/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='amd64'
GOHOSTOS='darwin'
GOINSECURE=''
GOMODCACHE='/Users/pjw/go/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='darwin'
GOPATH='/Users/pjw/go'
GOPRIVATE=''
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/Users/pjw/go/pkg/mod/golang.org/[email protected]'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='go1.21.4+auto'
GOTOOLDIR='/Users/pjw/go/pkg/mod/golang.org/[email protected]/pkg/tool/darwin_amd64'
GOVCS=''
GOVERSION='go1.21.4'
GCCGO='gccgo'
GOAMD64='v1'
AR='ar'
CC='clang'
CXX='clang++'
CGO_ENABLED='1'
GOMOD='/dev/null'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -arch x86_64 -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -ffile-prefix-map=/var/folders/rd/k2_hl56d33d46wylmty83gyh00052r/T/go-build1843092930=/tmp/go-build -gno-record-gcc-switches -fno-common'

What did you do?

I did nothing. For hours when I moved the cursor over a symbol vscode would show a hover. Then that stopped. It looks like vscode stopped sending the hover requests.

What did you expect to see?

hovers

What did you see instead?

nothing. However reloading the window brings the hovers back.

Editor and settings

{
"window.title": "${dirty}${activeEditorLong}${separator}${rootName}${separator}${appName}",
"editor.codeActionsOnSave": {
"source.organizeImports": "explicit",
"source.fixAll": "explicit"
},
"editor.minimap.enabled": false,
"editor.suggest.showStatusBar": true,
"extensions.autoCheckUpdates": false,
"go.coverageDecorator": {
"type": "gutter",
"coveredGutterStyle": "blockgreen",
"uncoveredGutterStyle": "blockred",
"coveredHighlightColor": "rgba(64,128,128,0.5)",
"uncoveredHighlightColor": "rgba(128,64,64,0.25)",
"coveredBorderColor": "rgba(64,128,128,1.0)",
"uncoveredBorderColor": "rgba(128,64,64,1.0)"
},
"go.coverOnSingleTestFile": true,
"go.coverOnSingleTest": true,
"go.coverMode": "count",
"go.coverShowCounts": false,
"go.formatTool": "goimports",
"go.lintOnSave": "off",
"go.languageServerExperimentalFeatures": {
"diagnostics": true
},
"[go]": {
"editor.snippetSuggestions": "none",
"editor.formatOnSave": true,
"editor.codeActionsOnSave": {
"source.organizeImports": "explicit",
"source.fixAll": "explicit"
}
},
"gopls": {
"usePlaceholders": true, // add parameter placeholders when completing a function
"verboseOutput": false,
"annotations": {
"Escape": false,
"Nil": false,
"Inline": false,
"Bounds": false
},
"codelenses": {
"gc_details": true
},
"analyses": {
"fillstruct": true,
"staticcheck": false,
"unusedparams": false,
"ST1005": false,
"QF1003": false,
"SA9003": false
},
"ui.noSemanticNumber": true,
"ui.noSemanticString": true,
"ui.semanticTokens": true,
"build.templateExtensions": [".tmpl"]
},
"go.languageServerFlags": [
"-rpc.trace",
"-logfile=auto",
"-debug=localhost:0"
],
"terminal.integrated.defaultProfile.osx": "zsh",
"typescript.format.insertSpaceAfterConstructor": true,
"typescript.format.semicolons": "insert",
"workbench.colorCustomizations": {
"editor.symbolHighlightBorder": "#ff0000",
"editorGutter.deletedBackground": "#ff0000"
// "editor.hoverHighlightBackground": "#ff0000",
// "editor.lineHighlightBackground": "#00ffb310"
},
"typescript.referencesCodeLens.enabled": true,
"typescript.implementationsCodeLens.enabled": true,
"editor.wordWrap": "on",
"go.enableCodeLens": {
"runtest": true
},
"go.delveConfig": {

"dlvLoadConfig": {
  "followPointers": true,
  "maxVariableRecurse": 1,
  "maxStringLen": 64,
  "maxArrayValues": 64,
  "maxStructFields": -1
},
"apiVersion": 2,
"showGlobalVariables": false,
"debugAdapter": "legacy"

},
"editor.inlineSuggest.enabled": true,
"terminal.integrated.commandsToSkipShell": [
"language-julia.interrupt"
],
"julia.symbolCacheDownload": true,
"julia.enableTelemetry": true,
"julia.usePlotPane": false,
"go.toolsManagement.autoUpdate": true,
"editor.fontSize": 14,
"debug.console.fontSize": 14,
"terminal.integrated.fontSize": 14,
"workbench.editor.highlightModifiedTabs": true,
"editor.stickyScroll.enabled": true,
"workbench.editor.empty.hint": "hidden",
"lldb.library": "/Applications/Xcode.app/Contents/SharedFrameworks/LLDB.framework/Versions/A/LLDB",
"lldb.launch.expressions": "native",
"editor.occurrencesHighlight": "multiFile",
"editor.unicodeHighlight.includeComments": true,
"editor.unicodeHighlight.nonBasicASCII": true,
}

Logs

The logs are unhelpful. Everything looks fine, but after a while there are no more hover requests.

[hyangah]

after a while there are no more hover requests.

Doesn't it indicate this is a client issue?

[pjweinb]

Yes. (I was already filling out the bug form when I looked at the logs)

…

On Mon, Dec 18, 2023 at 11:10 AM Hyang-Ah Hana Kim ***@***.***> wrote: after a while there are no more hover requests. Doesn't it indicate this is a client issue? — Reply to this email directly, view it on GitHub <#64778 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABJIAIY6TJMEW7BYXK6RX3TYKBTFRAVCNFSM6AAAAABAYUL3ISVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRQHEZDENBVGA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[adonovan]

Unfortunate limitations of JSONRPC make it very difficult to send responses to requests that are never received; I suggest filing this at vscode-go if it persists.