-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/build/dashboard: update dragonfly to 6.4.0 #64684
Comments
It seems the work of adding these builders to LUCI hasn't been done yet (#61092), so it might make sense to use 6.4.0 instead of 6.2.2 when doing that. (Since we're actively moving towards LUCI, there's less value in trying to do this update in the old infra at this point.) @tuxillo, are you able to take a look at what adding this to LUCI would take? Also see #63471 and #60468. CC @prattmic if you have a chance to look. |
Change https://go.dev/cl/549035 mentions this issue: |
Initial work to move from dfly 6.2.2 to 6.4.0. For golang/go#64684. Change-Id: I67e951ccb34728d9b42980cdd3cf1c9739fbc395 GitHub-Last-Rev: e672ce4 GitHub-Pull-Request: #83 Reviewed-on: https://go-review.googlesource.com/c/build/+/549035 Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Michael Pratt <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Auto-Submit: Dmitri Shuralyov <[email protected]>
has there been any progress? not sure what to do next. |
This will probably need to look something like https://go.dev/cl/526618, as that is another port that runs on GCE. We will also need to do some internal work to get LUCI to launch these VMs. I can take a look at making adjustments to the image. Unfortunately, I tried to create the existing image, which failed in phase 2 trying to download packages:
Do you know what may be the problem here? |
Yeah, let me come up with a set of commands that can be actually put into a script. It's a problem with 6.4.0 alone that will be fixed in later releases (and it is fixed in latest). |
Ah, thanks for the quick response. I'll try 6.2.2 for now. |
6.2.2 gets further, but it is unfortunately broken as well:
|
For 6.4.0, can you please try the following? Make sure after the failure, you do the command below and then retry the
Context: There was a bug that was triggered in the pkg 1.14 upgrade which ended up deleting the repos configuration. |
That did not work either, the second run failed with:
You could be able to run the image creation process as well, by running |
To this original question, the best baseline for LUCI migration is the port of the openbsd-amd64 builder image in CL 526618, plus minor follow-ups in CL 528515 and CL 542064. The key parts are:
You won't be able to fully test this until it is running on GCE with swarming access, but it should be testable that at least bootstrapswarm attempts to access the swarming server and gets an authentication error. |
Let me try myself and come back to you with something that actually works. Sorry for the hassle! |
This comment was marked as resolved.
This comment was marked as resolved.
@prattmic created a PR for the 6.4.0 build issue. I have tested it in Debian. |
Change https://go.dev/cl/568315 mentions this issue: |
Due to several factors as an old pkg version in the ISO, or the amount of changes that have gone to the binary packages since 6.4.0 was released, a bit of a workaround is needed in phase2.sh For golang/go#64684. Change-Id: I233fcfb77c3cc2f0b04331ad7bfee5892193622a GitHub-Last-Rev: 76b78fd GitHub-Pull-Request: #88 Reviewed-on: https://go-review.googlesource.com/c/build/+/568315 LUCI-TryBot-Result: Go LUCI <[email protected]> Auto-Submit: Ian Lance Taylor <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Carlos Amedee <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]>
Hi @tuxillo please can you explain what's the dragonfly |
It's a FreeBSD fork. |
Ah ok, so if I understand this issue it's to make Go compatible with the Dragonfly 6.4. |
How can we move this forward? |
@tuxillo but first what's Dragonfly |
@tuxillo this issue isn't moving |
It's long due but we should update the gobuilder from dfly 6.2.2 to 6.4.0
The text was updated successfully, but these errors were encountered: