Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/env: host-linux-amd64-wasip1-wasm-wasmtime (Container Image: wasip1-wasm-wasmtime:latest) #61116

Closed
Tracked by #60468
joedian opened this issue Jun 30, 2023 · 9 comments
Closed
Tracked by #60468

x/build/env: host-linux-amd64-wasip1-wasm-wasmtime (Container Image: wasip1-wasm-wasmtime:latest) #61116

joedian opened this issue Jun 30, 2023 · 9 comments
Assignees
@dmitshur
Labels
arch-wasm WebAssembly issues Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. new-builder
Milestone
Unreleased

Comments

@joedian
Copy link

joedian commented Jun 30, 2023

No description provided.

@joedian joedian mentioned this issue Jun 30, 2023
Open
35 tasks
@joedian joedian added Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. new-builder labels Jul 5, 2023
@joedian joedian changed the title host-linux-amd64-wasip1-wasm-wasmtime (Container Image: wasip1-wasm-wasmtime:latest) x/build/env: host-linux-amd64-wasip1-wasm-wasmtime (Container Image: wasip1-wasm-wasmtime:latest) Jul 5, 2023
@gopherbot gopherbot added this to the Unreleased milestone Jul 5, 2023
@bcmills bcmills added the arch-wasm WebAssembly issues label Jul 24, 2023
@dmitshur dmitshur self-assigned this Nov 1, 2023
@dmitshur dmitshur moved this to In Progress in Go Release Nov 1, 2023
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/538897 mentions this issue: main.star: start adding two wasip1-wasm builders

gopherbot pushed a commit to golang/build that referenced this issue Nov 1, 2023
@dmitshur @gopherbot
main.star: start adding two wasip1-wasm builders
9189ff0 
Start by adding them as post-submit builders, only in the main Go repo,
and only at tip. Mostly so it's easier to see the generated code and
iterate. Once they work, they'll be turned up in the remaining places.

For golang/go#61116.
For golang/go#61117.

Change-Id: I72127713d1043acc800b2fc13a0fcccdf090aeba
Reviewed-on: https://go-review.googlesource.com/c/build/+/538897
Auto-Submit: Dmitri Shuralyov <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
Reviewed-by: Michael Knyszek <[email protected]>
TryBot-Bypass: Dmitri Shuralyov <[email protected]>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/539435 mentions this issue: syscall: copy rlimit.go's build constraint to rlimit_test.go

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/538699 mentions this issue: misc/wasm: silence Wasmtime 14 CLI warning

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/539417 mentions this issue: main.star: enable wasip1-wasm builders on release-branch.go1.21

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/539419 mentions this issue: main.star: enable presubmit coverage for wasip1-wasm builders

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/539418 mentions this issue: main.star: enable wasip1-wasm builders for x repos

gopherbot pushed a commit that referenced this issue Nov 2, 2023
@dmitshur @gopherbot
syscall: copy rlimit.go's build constraint to rlimit_test.go
b7cbcf0 
Tests in rlimit_test.go exist to test the behavior of automatically
bumping RLIMIT_NOFILE on Unix implemented in rlimit.go (issue #46279),
with darwin-specific behavior split out into rlimit_darwin.go and
the rest left empty in rlimit_stub.go.

Since the behavior happens only on Unix, it doesn't make sense to test
it on other platforms. Copy rlimit.go's 'unix' build constraint to
rlimit_test.go to accomplish that.

Also simplify the build constraint in rlimit_stub.go while here,
so that its maintenance is easier and it starts to match all
non-darwin Unix GOOS values (previously, 'hurd' happened to be missed).

In particular, this fixes a problem where TestOpenFileLimit was
failing in some environments when testing the wasip1/wasm port.
The RLIMIT_NOFILE bumping behavior isn't implemented there, so
the test was testing the environment and not the Go project.

Updates #46279.
For #61116.

Change-Id: Ic993f9cfc021d4cda4fe3d7fed8e2e180f78a2ca
Reviewed-on: https://go-review.googlesource.com/c/go/+/539435
Reviewed-by: Johan Brandhorst-Satzkorn <[email protected]>
Reviewed-by: Bryan Mills <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
Auto-Submit: Dmitri Shuralyov <[email protected]>
gopherbot pushed a commit that referenced this issue Nov 2, 2023
@dmitshur @gopherbot
misc/wasm: silence Wasmtime 14 CLI warning
450f469 
The latest version of Wasmtime, 14.0.4 as of writing this, offers a new
CLI while also supporting the old CLI. Since this is known and tracked
in issue #63718, silence the warning that otherwise causes many tests
to fail.

Since Wasmtime 13 and older don't pay attention to WASMTIME_NEW_CLI,
this change increases compatibility of the script, letting it work
with Wasmtime 9.0.1 as currently tested by the old cmd/coordinator, and
with Wasmtime 14.0.4 as currently tested in the new LUCI infrastructure.

The rest of the transition is left as future work.

For #63718.
For #61116.

Change-Id: I77d4f74cc1d34a657e48dcaaceb6fbda7d1e9428
Cq-Include-Trybots: luci.golang.try:gotip-wasip1-wasm_wasmtime
Reviewed-on: https://go-review.googlesource.com/c/go/+/538699
Auto-Submit: Dmitri Shuralyov <[email protected]>
Reviewed-by: Johan Brandhorst-Satzkorn <[email protected]>
Reviewed-by: Cherry Mui <[email protected]>
Run-TryBot: Dmitri Shuralyov <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/539715 mentions this issue: main.star: prepend CIPD epoch to wasmtime, wazero versions

gopherbot pushed a commit to golang/build that referenced this issue Nov 3, 2023
@dmitshur @gopherbot
main.star: prepend CIPD epoch to wasmtime, wazero versions
c57b860 
The wazero and wasmtime packages are available in infra/3pp/tools as
of crrev.com/c/4995549. In preparation of the switch soon to be done
in crrev.com/c/4995558, prepend the "2@" package epoch (more context
in crrev.com/c/2763964) that their version strings ended up with.

Also factor out the comment explaining how to check the availability
of a given version in CIPD, so we don't need to repeat it 3 times.

For golang/go#61116.
For golang/go#61117.

Change-Id: I1c638aec1782b8d4f15724c0acc97f0323e5f70a
Reviewed-on: https://go-review.googlesource.com/c/build/+/539715
TryBot-Bypass: Dmitri Shuralyov <[email protected]>
TryBot-Bypass: Dmitri Shuralyov <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
Auto-Submit: Dmitri Shuralyov <[email protected]>
Reviewed-by: Michael Knyszek <[email protected]>
gopherbot pushed a commit to golang/build that referenced this issue Nov 7, 2023
@dmitshur @gopherbot
main.star: enable wasip1-wasm builders on release-branch.go1.21
004cb4b 
The GOOS=wasip1 port is new to Go 1.21, so there's nothing to test
on release-branch.go1.20.

I'll also likely need to backport a test-only version of CL 539435
for it to work.

For golang/go#61116.
For golang/go#61117.

Change-Id: I53d0b370a98059f2f4f721402a9e0f153df4f28b
Reviewed-on: https://go-review.googlesource.com/c/build/+/539417
TryBot-Bypass: Dmitri Shuralyov <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
Reviewed-by: Michael Knyszek <[email protected]>
Auto-Submit: Dmitri Shuralyov <[email protected]>
gopherbot pushed a commit to golang/build that referenced this issue Nov 7, 2023
@dmitshur @gopherbot
main.star: enable wasip1-wasm builders for x repos
f733a3b 
For golang/go#61116.
For golang/go#61117.

Change-Id: I90898bb976009086a617d56348becb5d9bdc747f
Reviewed-on: https://go-review.googlesource.com/c/build/+/539418
Auto-Submit: Dmitri Shuralyov <[email protected]>
TryBot-Bypass: Dmitri Shuralyov <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
Reviewed-by: Michael Knyszek <[email protected]>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/540615 mentions this issue: [release-branch.go1.21] syscall: copy rlimit.go's build constraint to rlimit_test.go

gopherbot pushed a commit that referenced this issue Nov 7, 2023
@dmitshur @gopherbot
[release-branch.go1.21] syscall: copy rlimit.go's build constraint to…
1e91861 
… rlimit_test.go

Tests in rlimit_test.go exist to test the behavior of automatically
bumping RLIMIT_NOFILE on Unix implemented in rlimit.go (issue #46279),
with darwin-specific behavior split out into rlimit_darwin.go and
the rest left empty in rlimit_stub.go.

Since the behavior happens only on Unix, it doesn't make sense to test
it on other platforms. Copy rlimit.go's 'unix' build constraint to
rlimit_test.go to accomplish that.

Leave out the simplification of the build constraint in rlimit_stub.go
so that this CL remains a test-only fix.

In particular, this fixes a problem where TestOpenFileLimit was
failing in some environments when testing the wasip1/wasm port.
The RLIMIT_NOFILE bumping behavior isn't implemented there, so
the test was testing the environment and not the Go project.

Updates #46279.
For #61116.
Fixes #63994.

Change-Id: Ic993f9cfc021d4cda4fe3d7fed8e2e180f78a2ca
Cq-Include-Trybots: luci.golang.try:go1.21-wasip1-wasm_wasmtime
Reviewed-on: https://go-review.googlesource.com/c/go/+/539435
Reviewed-by: Johan Brandhorst-Satzkorn <[email protected]>
Reviewed-by: Bryan Mills <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
Auto-Submit: Dmitri Shuralyov <[email protected]>
(cherry picked from commit b7cbcf0)
Reviewed-on: https://go-review.googlesource.com/c/go/+/540615
Reviewed-by: Heschi Kreinick <[email protected]>
Auto-Submit: Heschi Kreinick <[email protected]>
gopherbot pushed a commit to golang/build that referenced this issue Nov 7, 2023
@dmitshur @gopherbot
main.star: enable presubmit coverage for wasip1-wasm builders
838577e 
This is the last step after turning it on in postsubmit everywhere.

In the old build system, we've decided that just one of the multiple
wasip1 builders is enough signal for trybots. We could propagate that
decision here by putting wasip1-wasm_wazero (not wasip1-wasm_wasmtime)
in some "don't include in pre-submit" list, but for now we choose to
defer that kind of policy and configuration complexity until there's
a concrete need.

Fixes golang/go#61116.
Fixes golang/go#61117.

Change-Id: I54403eaf299f4c9a3d68f350323763670663f1b0
Reviewed-on: https://go-review.googlesource.com/c/build/+/539419
Reviewed-by: Michael Knyszek <[email protected]>
Auto-Submit: Dmitri Shuralyov <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
TryBot-Bypass: Dmitri Shuralyov <[email protected]>
@dmitshur
Copy link
Contributor

dmitshur commented Nov 7, 2023

This builder is turned up in LUCI, both in pre- and post-submit.

@dmitshur dmitshur closed this as completed Nov 7, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Go Release Nov 7, 2023
@golang golang locked and limited conversation to collaborators Nov 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dmitshur dmitshur

Labels
arch-wasm WebAssembly issues Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. new-builder
Projects
Go Release
Archived in project
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@dmitshur @bcmills @gopherbot @joedian