Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/link: Trampoline insertion breaks DWARF Line Program Table output on Darwin/ARM64 [1.18 backport] #54502

Closed
gopherbot opened this issue Aug 17, 2022 · 2 comments
Closed

cmd/link: Trampoline insertion breaks DWARF Line Program Table output on Darwin/ARM64 [1.18 backport] #54502

gopherbot opened this issue Aug 17, 2022 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge
Milestone
Go1.18.6

Comments

@gopherbot
Copy link
Contributor

@cagedmantis requested issue #54320 to be considered for backport to the next 1.18 minor release.

@gopherbot please open a backport to 1.18.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Aug 17, 2022
@gopherbot gopherbot mentioned this issue Aug 17, 2022
Closed
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Aug 17, 2022
@gopherbot gopherbot added this to the Go1.18.6 milestone Aug 17, 2022
@cagedmantis cagedmantis added the CherryPickApproved Used during the release process for point releases label Aug 17, 2022
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Aug 17, 2022
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/424536 mentions this issue: [release-branch.go1.18] cmd/link: fix trampolines breaking DWARF line info

@mknyszek mknyszek moved this to All-But-Submitted in Go Compiler / Runtime Aug 24, 2022
gopherbot pushed a commit that referenced this issue Aug 29, 2022
@jquirke @heschi
[release-branch.go1.18] cmd/link: fix trampolines breaking DWARF line…
569d949 
… info

When trampolines are needed (e.g. Darwin ARM64), the DWARF LPT (Line
Program Table - see DWARF section 6.1) generation fails because the
replacement symbols are marked as external symbols and skipped during
the DWARF LPT generation phase.

Fixes #54502

Change-Id: I6c93f5378f50e5edf30d5121402a48214abb1ce2
GitHub-Last-Rev: 085bbc5
GitHub-Pull-Request: #54321
Reviewed-on: https://go-review.googlesource.com/c/go/+/422154
Reviewed-by: Cherry Mui <[email protected]>
Run-TryBot: Than McIntosh <[email protected]>
Reviewed-by: Than McIntosh <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
(cherry picked from commit 2340d37)
Reviewed-on: https://go-review.googlesource.com/c/go/+/424536
Run-TryBot: Cherry Mui <[email protected]>
@gopherbot
Copy link
Contributor Author

Closed by merging 569d949 to release-branch.go1.18.

Repository owner moved this from All-But-Submitted to Done in Go Compiler / Runtime Aug 29, 2022
@golang golang locked and limited conversation to collaborators Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge
Projects
None yet
Milestone
Go1.18.6
Development

No branches or pull requests
2 participants
@cagedmantis @gopherbot