Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/crypto/ssh: TestClientAuthMaxAuthTries failures with WSAECONNABORTED #51149

Closed
bcmills opened this issue Feb 11, 2022 · 1 comment
Closed

x/crypto/ssh: TestClientAuthMaxAuthTries failures with WSAECONNABORTED #51149

bcmills opened this issue Feb 11, 2022 · 1 comment
Labels
FrozenDueToAge NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. release-blocker
Milestone
Go1.18

Comments

@bcmills
Copy link
Contributor

bcmills commented Feb 11, 2022 •
edited
Loading

Looks like TestClientAuthMaxAuthTries has the same problem as TestClientAuthMaxAuthTriesPublicKey (#50805).

2022-02-09T19:56:52-db63837-9cec77a/windows-arm64-10:

--- FAIL: TestClientAuthMaxAuthTries (0.01s)
    client_auth_test.go:600: client: got ssh: handshake failed: read tcp 127.0.0.1:50086->127.0.0.1:50087: wsarecv: An established connection was aborted by the software in your host machine., want ssh: handshake failed: ssh: disconnect, reason 2: too many authentication failures
FAIL
FAIL	golang.org/x/crypto/ssh

greplogs --dashboard -md -l -e 'FAIL: TestClientAuthMaxAuthTries .*\n(?: .*\n)* .*An established connection was aborted' --since=2021-01-01

2022-02-09T19:56:52-db63837-9cec77a/windows-arm64-10
2022-02-03T18:23:55-30dcbda-1ab8273/windows-arm64-10
2022-01-14T21:54:39-5e0467b-3b5eec9/windows-amd64-longtest
2021-12-06T19:23:21-5770296-765cc72/windows-arm64-10
2021-12-03T17:13:03-5770296-d921bb2/windows-arm64-10
2021-11-20T00:37:28-ae814b3-d2f4c93/windows-arm64-10
2021-11-17T17:36:36-b4de73f-0555ea3/windows-arm64-10
2021-11-04T23:35:26-089bfa5-256a8fc/windows-386-2008
2021-11-04T20:43:07-089bfa5-8248152/windows-arm64-10

Like that issue, this one also affects windows/amd64, which is a first-class port.

@rolandshoemaker, do you want to apply the same test change as for that issue?
@bcmills bcmills added NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. release-blocker labels Feb 11, 2022
@bcmills bcmills added this to the Go1.18 milestone Feb 11, 2022
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/385236 mentions this issue: crypto/ssh: don't send the last auth failure message if disconnecting

owenthereal pushed a commit to owenthereal/upterm.crypto that referenced this issue Mar 5, 2022
@rolandshoemaker @owenthereal
crypto/ssh: don't send the last auth failure message if disconnecting
b5f5340 
If we are going to send the disconnect message and close the connection,
because we have exhausted the number of authentication attempts, don't
send the final authentication failure message. This behavior matches
that of OpenSSH.

Fixes golang/go#51149

Change-Id: I43b2de2e854f789161cd7fd6c05876661adfb2c1
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/385236
Trust: Roland Shoemaker <[email protected]>
Run-TryBot: Roland Shoemaker <[email protected]>
Auto-Submit: Roland Shoemaker <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Ian Lance Taylor <[email protected]>
iamacarpet pushed a commit to affordablemobiles/xcrypto that referenced this issue Aug 2, 2022
@rolandshoemaker @iamacarpet
crypto/ssh: don't send the last auth failure message if disconnecting
ebcf61a 
If we are going to send the disconnect message and close the connection,
because we have exhausted the number of authentication attempts, don't
send the final authentication failure message. This behavior matches
that of OpenSSH.

Fixes golang/go#51149

Change-Id: I43b2de2e854f789161cd7fd6c05876661adfb2c1
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/385236
Trust: Roland Shoemaker <[email protected]>
Run-TryBot: Roland Shoemaker <[email protected]>
Auto-Submit: Roland Shoemaker <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Ian Lance Taylor <[email protected]>
@golang golang locked and limited conversation to collaborators Feb 13, 2023
LewiGoddard pushed a commit to LewiGoddard/crypto that referenced this issue Feb 16, 2023
@rolandshoemaker @gopherbot
crypto/ssh: don't send the last auth failure message if disconnecting
6992913 
If we are going to send the disconnect message and close the connection,
because we have exhausted the number of authentication attempts, don't
send the final authentication failure message. This behavior matches
that of OpenSSH.

Fixes golang/go#51149

Change-Id: I43b2de2e854f789161cd7fd6c05876661adfb2c1
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/385236
Trust: Roland Shoemaker <[email protected]>
Run-TryBot: Roland Shoemaker <[email protected]>
Auto-Submit: Roland Shoemaker <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Ian Lance Taylor <[email protected]>
BiiChris pushed a commit to BiiChris/crypto that referenced this issue Sep 15, 2023
@rolandshoemaker @gopherbot
crypto/ssh: don't send the last auth failure message if disconnecting
93c19f6 
If we are going to send the disconnect message and close the connection,
because we have exhausted the number of authentication attempts, don't
send the final authentication failure message. This behavior matches
that of OpenSSH.

Fixes golang/go#51149

Change-Id: I43b2de2e854f789161cd7fd6c05876661adfb2c1
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/385236
Trust: Roland Shoemaker <[email protected]>
Run-TryBot: Roland Shoemaker <[email protected]>
Auto-Submit: Roland Shoemaker <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Ian Lance Taylor <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. release-blocker
Projects
None yet
Milestone
Go1.18
Development

No branches or pull requests
2 participants
@bcmills @gopherbot