Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/crypto/ssh/agent: TestMalformedRequests/Short_body failures on darwin/arm64 since 2021-12-08 #50161

Closed
bcmills opened this issue Dec 14, 2021 · 3 comments
Closed

x/crypto/ssh/agent: TestMalformedRequests/Short_body failures on darwin/arm64 since 2021-12-08 #50161

bcmills opened this issue Dec 14, 2021 · 3 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Milestone
Go1.18

Comments

@bcmills
Copy link
Contributor

bcmills commented Dec 14, 2021 

--- FAIL: TestMalformedRequests (60.00s)
    --- FAIL: TestMalformedRequests/Short_body (60.00s)
        client_test.go:230: ServeAgent returned expected error: read tcp 127.0.0.1:60723->127.0.0.1:60727: read: connection reset by peer
2021/12/14 08:02:42 agent 23: agent: incorrect passphrase
FAIL
FAIL	golang.org/x/crypto/ssh/agent	60.279s

greplogs --dashboard -md -l -e 'FAIL: TestMalformedRequests'

2021-12-09T19:36:57-4570a08-de690c2/darwin-arm64-12_0-toothrot
2021-12-08T04:14:00-5770296-a19e72c/darwin-arm64-11_0-toothrot
@gopherbot gopherbot added this to the Unreleased milestone Dec 14, 2021
@bcmills bcmills changed the title x/crypto/ssh/agent: TestMalformedRequests/Short_body failures on darwin/arm64 x/crypto/ssh/agent: TestMalformedRequests/Short_body failures on darwin/arm64 since 2021-12-08 Dec 14, 2021
@bcmills
Copy link
Contributor Author

bcmills commented Dec 14, 2021

This is a release-blocker via #11811.

Given the timing, it could be related to the fix for #49932 (CC @rolandshoemaker @julieqiu @katiehockman). Note that at least one of the failures is on release-branch.go1.17, so this does not appear to be a regression in Go 1.18 itself.

@bcmills bcmills added okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 release-blocker labels Dec 14, 2021
@bcmills bcmills modified the milestones: Unreleased, Go1.18 Dec 14, 2021
@bcmills bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Dec 14, 2021
@cherrymui cherrymui removed the okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 label Dec 14, 2021
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/371874 mentions this issue: ssh/agent: fix TestMalformedRequests

@cagedmantis
Copy link
Contributor

Checking in on this as a release-blocking issue. Are there any updates?

@bcmills bcmills mentioned this issue Jan 25, 2022
Closed
owenthereal pushed a commit to owenthereal/upterm.crypto that referenced this issue Mar 5, 2022
@rolandshoemaker @owenthereal
ssh/agent: fix TestMalformedRequests
4771c01 
Use a net.Pipe, rather than setting up a local TCP connection,
for testing malformed SSH requests, since we don't need the
complex intricacies of a real connection to test this protocol
behavior.

Fixes golang/go#50161

Change-Id: I5e46c42041ddd03b06725469216b82b801990e64
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/371874
Reviewed-by: Bryan Mills <[email protected]>
Trust: Roland Shoemaker <[email protected]>
Run-TryBot: Roland Shoemaker <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
iamacarpet pushed a commit to affordablemobiles/xcrypto that referenced this issue Aug 2, 2022
@rolandshoemaker @iamacarpet
ssh/agent: fix TestMalformedRequests
b60b86f 
Use a net.Pipe, rather than setting up a local TCP connection,
for testing malformed SSH requests, since we don't need the
complex intricacies of a real connection to test this protocol
behavior.

Fixes golang/go#50161

Change-Id: I5e46c42041ddd03b06725469216b82b801990e64
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/371874
Reviewed-by: Bryan Mills <[email protected]>
Trust: Roland Shoemaker <[email protected]>
Run-TryBot: Roland Shoemaker <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
@golang golang locked and limited conversation to collaborators Jan 26, 2023
LewiGoddard pushed a commit to LewiGoddard/crypto that referenced this issue Feb 16, 2023
@rolandshoemaker
ssh/agent: fix TestMalformedRequests
5ec22ef 
Use a net.Pipe, rather than setting up a local TCP connection,
for testing malformed SSH requests, since we don't need the
complex intricacies of a real connection to test this protocol
behavior.

Fixes golang/go#50161

Change-Id: I5e46c42041ddd03b06725469216b82b801990e64
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/371874
Reviewed-by: Bryan Mills <[email protected]>
Trust: Roland Shoemaker <[email protected]>
Run-TryBot: Roland Shoemaker <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
BiiChris pushed a commit to BiiChris/crypto that referenced this issue Sep 15, 2023
@rolandshoemaker
ssh/agent: fix TestMalformedRequests
d11dfc8 
Use a net.Pipe, rather than setting up a local TCP connection,
for testing malformed SSH requests, since we don't need the
complex intricacies of a real connection to test this protocol
behavior.

Fixes golang/go#50161

Change-Id: I5e46c42041ddd03b06725469216b82b801990e64
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/371874
Reviewed-by: Bryan Mills <[email protected]>
Trust: Roland Shoemaker <[email protected]>
Run-TryBot: Roland Shoemaker <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Projects
None yet
Milestone
Go1.18
Development

No branches or pull requests
4 participants
@cagedmantis @bcmills @gopherbot @cherrymui