x/net/http2: frequent failures in TestClientConnCloseAtBody #49335

bcmills · 2021-11-04T02:37:10Z

This test has been failing typically multiple times per day since at least 2021-10-04.

--- FAIL: TestClientConnCloseAtBody (0.01s)
    transport_test.go:4572: got 1 active streams, want 0
FAIL
FAIL	golang.org/x/net/http2	22.488s

greplogs --dashboard -md -l -e 'FAIL: TestClientConnCloseAtBody'

(CC @neild)

The text was updated successfully, but these errors were encountered:

gopherbot · 2021-11-05T18:49:15Z

Change https://golang.org/cl/361536 mentions this issue: http2: don't count aborted streams as active in tests

neild · 2021-12-01T23:00:47Z

@gopherbot Please open backport issues for 1.16 and 1.17. Test-only fix for flaky failures.

gopherbot · 2021-12-01T23:01:04Z

Backport issue(s) opened: #49910 (for 1.16), #49911 (for 1.17).

Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://golang.org/wiki/MinorReleases.

gopherbot · 2021-12-01T23:03:41Z

Change https://golang.org/cl/368554 mentions this issue: [internal-branch.go1.16-vendor] http2: don't count aborted streams as active in tests

gopherbot · 2021-12-01T23:04:48Z

Change https://golang.org/cl/368555 mentions this issue: [internal-branch.go1.17-vendor] http2: don't count aborted streams as active in tests

… active in tests Deflake TestClientConnCloseAtBody, which assumes all streams have been fully cleaned up after ClientConn.Close returns. Only count active streams, not ones in the process of aborting. Perhaps ClientConn.Close should block until all streams have been cleaned up, although this could result in Close blocking indefinitely if a stream is blocked reading from the request body. For golang/go#49335. For golang/go#49910. Change-Id: I172e0d3f10875191d29b24598de0abbdeb35e434 Reviewed-on: https://go-review.googlesource.com/c/net/+/361536 Trust: Damien Neil <[email protected]> Run-TryBot: Damien Neil <[email protected]> TryBot-Result: Go Bot <[email protected]> Reviewed-by: Bryan C. Mills <[email protected]> (cherry picked from commit b53810d) Reviewed-on: https://go-review.googlesource.com/c/net/+/368554 Reviewed-by: Michael Knyszek <[email protected]>

… active in tests Deflake TestClientConnCloseAtBody, which assumes all streams have been fully cleaned up after ClientConn.Close returns. Only count active streams, not ones in the process of aborting. Perhaps ClientConn.Close should block until all streams have been cleaned up, although this could result in Close blocking indefinitely if a stream is blocked reading from the request body. For golang/go#49335. For golang/go#49911. Change-Id: I172e0d3f10875191d29b24598de0abbdeb35e434 Reviewed-on: https://go-review.googlesource.com/c/net/+/361536 Trust: Damien Neil <[email protected]> Run-TryBot: Damien Neil <[email protected]> TryBot-Result: Go Bot <[email protected]> Reviewed-by: Bryan C. Mills <[email protected]> (cherry picked from commit b53810d) Reviewed-on: https://go-review.googlesource.com/c/net/+/368555 Reviewed-by: Michael Knyszek <[email protected]>

Deflake TestClientConnCloseAtBody, which assumes all streams have been fully cleaned up after ClientConn.Close returns. Only count active streams, not ones in the process of aborting. Perhaps ClientConn.Close should block until all streams have been cleaned up, although this could result in Close blocking indefinitely if a stream is blocked reading from the request body. Fixes golang/go#49335. Change-Id: I172e0d3f10875191d29b24598de0abbdeb35e434 Reviewed-on: https://go-review.googlesource.com/c/net/+/361536 Trust: Damien Neil <[email protected]> Run-TryBot: Damien Neil <[email protected]> TryBot-Result: Go Bot <[email protected]> Reviewed-by: Bryan C. Mills <[email protected]>

… active in tests Deflake TestClientConnCloseAtBody, which assumes all streams have been fully cleaned up after ClientConn.Close returns. Only count active streams, not ones in the process of aborting. Perhaps ClientConn.Close should block until all streams have been cleaned up, although this could result in Close blocking indefinitely if a stream is blocked reading from the request body. For golang/go#49335. For golang/go#49911. Change-Id: I172e0d3f10875191d29b24598de0abbdeb35e434 Reviewed-on: https://go-review.googlesource.com/c/net/+/361536 Trust: Damien Neil <[email protected]> Run-TryBot: Damien Neil <[email protected]> TryBot-Result: Go Bot <[email protected]> Reviewed-by: Bryan C. Mills <[email protected]> (cherry picked from commit b53810dc28af183c5c4adfbb6b6d982379845b06) Reviewed-on: https://go-review.googlesource.com/c/net/+/368555 Reviewed-by: Michael Knyszek <[email protected]>

bcmills added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker labels Nov 4, 2021

bcmills added this to the Go1.18 milestone Nov 4, 2021

gopherbot closed this as completed in golang/net@b53810d Nov 5, 2021

This was referenced Dec 1, 2021

x/net/http2: frequent failures in TestClientConnCloseAtBody [1.16 backport] #49910

Closed

x/net/http2: frequent failures in TestClientConnCloseAtBody [1.17 backport] #49911

Closed

golang locked and limited conversation to collaborators Dec 1, 2022

gopherbot added the FrozenDueToAge label Dec 1, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

x/net/http2: frequent failures in TestClientConnCloseAtBody #49335

x/net/http2: frequent failures in TestClientConnCloseAtBody #49335

bcmills commented Nov 4, 2021

gopherbot commented Nov 5, 2021

neild commented Dec 1, 2021

gopherbot commented Dec 1, 2021

gopherbot commented Dec 1, 2021

gopherbot commented Dec 1, 2021

x/net/http2: frequent failures in TestClientConnCloseAtBody #49335

x/net/http2: frequent failures in TestClientConnCloseAtBody #49335

Comments

bcmills commented Nov 4, 2021

gopherbot commented Nov 5, 2021

neild commented Dec 1, 2021

gopherbot commented Dec 1, 2021

gopherbot commented Dec 1, 2021

gopherbot commented Dec 1, 2021