Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build: have more than 1 macOS 12.0 Monterey builder (arm64/amd64) #49149

Closed
cagedmantis opened this issue Oct 25, 2021 · 23 comments
Closed

x/build: have more than 1 macOS 12.0 Monterey builder (arm64/amd64) #49149

cagedmantis opened this issue Oct 25, 2021 · 23 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. new-builder OS-Darwin
Milestone
Unreleased

Comments

@cagedmantis
Copy link
Contributor

Apple has release macOS 12.0 on October 25, 2021. We plan to provide this builder before Go 1.18 is released. Builders should be added for both the arm64 and amd64 architecture.

@golang/release
@cagedmantis cagedmantis added OS-Darwin Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. new-builder okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 labels Oct 25, 2021
@cagedmantis cagedmantis added this to the Go1.18 milestone Oct 25, 2021
@randall77
Copy link
Contributor

FYI, there may be a problem with Monterey and the race detector, see #49138.

@voelzmo voelzmo mentioned this issue Nov 8, 2021
Closed
@dmitshur dmitshur mentioned this issue Nov 16, 2021
Closed
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/365194 mentions this issue: all: add macOS 12 AMD64 builders

gopherbot pushed a commit to golang/build that referenced this issue Nov 18, 2021
@heschi
all: add macOS 12 AMD64 builders
1a0f547 
I'm not 100% sure they'll work, so just one for now.

I've updated the documentation according to my very shaky understanding.

For golang/go#49149.
Change-Id: Ic8f3b7fe96a1a6c18c0940a4aa2d08ec9dc2138b
Reviewed-on: https://go-review.googlesource.com/c/build/+/365194
Trust: Heschi Kreinick <[email protected]>
Run-TryBot: Heschi Kreinick <[email protected]>
TryBot-Result: Go Bot <[email protected]>
Reviewed-by: Carlos Amedee <[email protected]>
@heschi
Copy link
Contributor

heschi commented Nov 18, 2021

The new build is up and passing using MallocNanoZone=0. Only one machine; I'll scale it up tomorrow probably.

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/365736 mentions this issue: dashboard: add darwin-arm64-12_0 builder

gopherbot pushed a commit to golang/build that referenced this issue Nov 19, 2021
@toothrot
dashboard: add darwin-arm64-12_0 builder
6f3ca61 
Upgrades our arm64-11_0 builder.

For golang/go#49149

Change-Id: I517cc5a999cea0cbc96ee2a6d3901840e2473b6a
Reviewed-on: https://go-review.googlesource.com/c/build/+/365736
Trust: Alexander Rakoczy <[email protected]>
Run-TryBot: Alexander Rakoczy <[email protected]>
TryBot-Result: Go Bot <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
@bcmills bcmills mentioned this issue Nov 19, 2021
Closed
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/365777 mentions this issue: buildlet,dashboard: tweaks to Darwin, OpenBSD, and Linux builders

gopherbot pushed a commit to golang/build that referenced this issue Nov 19, 2021
@heschi
buildlet,dashboard: tweaks to Darwin, OpenBSD, and Linux builders
3ffd700 
- Add more Monterey builders and remove the known issue: it's stable.
  Also use it for race and nocgo. Update slowbot aliases to point to it.
- Don't test 1.16 on OpenBSD 7.0, it segfaults.
- Pin the Linux (ContainerOS) builders to an older version to avoid the
  pprof kernel bug.

For golang/go#49065, golang/go#49149, and golang/go#48977.

Change-Id: Ibec2fa735183ec65e5066c7c752ac356b7360550
Reviewed-on: https://go-review.googlesource.com/c/build/+/365777
Trust: Heschi Kreinick <[email protected]>
Run-TryBot: Heschi Kreinick <[email protected]>
TryBot-Result: Go Bot <[email protected]>
Reviewed-by: Alexander Rakoczy <[email protected]>
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/366134 mentions this issue: dashboard: remove macOS 12.0 KI

gopherbot pushed a commit to golang/build that referenced this issue Nov 22, 2021
@heschi
dashboard: remove macOS 12.0 KI
7a022db 
Forgot to do this in CL 365777.

For golang/go#49149.

Change-Id: I50d090d84408898b4ceb19da660de9c3a79beeda
Reviewed-on: https://go-review.googlesource.com/c/build/+/366134
Trust: Heschi Kreinick <[email protected]>
Run-TryBot: Heschi Kreinick <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
Reviewed-by: Alexander Rakoczy <[email protected]>
Reviewed-by: Carlos Amedee <[email protected]>
TryBot-Result: Go Bot <[email protected]>
@bcmills bcmills mentioned this issue Nov 22, 2021
Closed
This was referenced Dec 1, 2021
Open
Closed
Closed
@dmitshur
Copy link
Contributor

dmitshur commented Dec 2, 2021

Issue #46239 is the cause of the new macOS 12 arm64 builder consistently failing on the 1.17 release branch. Interestingly, that same test is not failing on tip (and is not being skipped).

@ianlancetaylor
Copy link
Contributor

@golang/release This is in the 1.18 milestone; time to move to 1.19? Thanks.

@dmitshur
Copy link
Contributor

Since this isn't a release-blocker for 1.18 now and the fix will be in x/build, moving to Unreleased milestone.

@dmitshur dmitshur modified the milestones: Go1.18, Unreleased Feb 15, 2022
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/398697 mentions this issue: cmd/coordinator: triple writeSnapshot timeout for macOS arm64 builders

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/399041 mentions this issue: cmd/coordinator: extend macOS builder health check coverage

gopherbot pushed a commit to golang/build that referenced this issue Apr 8, 2022
@dmitshur @gopherbot
cmd/coordinator: triple writeSnapshot timeout for reverse builders
6444502 
This timeout is meant to be an upper bound, and some reverse builders
have been observed to need a bit over 5 minutes to finish the upload.
Give them more time and update the comment to describe the 2022 state.

Also log how many bytes they've managed to copy before failing.

Updates golang/go#52235.
Updates golang/go#49149.

Change-Id: I20f850620f0aa8126968862f2ad9a096fa32ce03
Reviewed-on: https://go-review.googlesource.com/c/build/+/398697
Trust: Carlos Amedee <[email protected]>
Reviewed-by: Carlos Amedee <[email protected]>
Trust: Dmitri Shuralyov <[email protected]>
Run-TryBot: Dmitri Shuralyov <[email protected]>
Auto-Submit: Dmitri Shuralyov <[email protected]>
Reviewed-by: Heschi Kreinick <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
gopherbot pushed a commit to golang/build that referenced this issue Apr 11, 2022
@dmitshur @gopherbot
cmd/coordinator: extend macOS builder health check coverage
b82e23d 
Use reverseHostChecker, which handles when a builder restarts between
builds and reconnects quickly—without displaying a fatal error during
that time. Delete the simple hostTypeChecker which does not do that.

This CL tries to implement a temporary fix to make the health check
more useful while the work on adding more builders (and making them
sustainable) is still underway.

For golang/go#49149.

Change-Id: If5fe39b0c7a854a8bcce3095e356d7d2b8faec7e
Reviewed-on: https://go-review.googlesource.com/c/build/+/399041
Run-TryBot: Dmitri Shuralyov <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Auto-Submit: Dmitri Shuralyov <[email protected]>
Reviewed-by: Alex Rakoczy <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/402181 mentions this issue: net: skip TestDialCancel on darwin-arm64

gopherbot pushed a commit that referenced this issue Apr 26, 2022
@heschi @gopherbot
net: skip TestDialCancel on darwin-arm64
06b0a65 
We're turning up Macs in a network environment that clashes with this
test. I don't think it's critical to get it working, so skip it.

For #49149.

Change-Id: I925e3ecc5356c4cefd208bdcff3d98021215d0b4
Reviewed-on: https://go-review.googlesource.com/c/go/+/402181
Reviewed-by: Alex Rakoczy <[email protected]>
Run-TryBot: Heschi Kreinick <[email protected]>
Auto-Submit: Heschi Kreinick <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/402454 mentions this issue: net: install slowDialTCP hook in TestDialCancel

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/402737 mentions this issue: env/darwin/macstadium: rewrite setup notes

@heschi
Copy link
Contributor

heschi commented Apr 27, 2022

@toothrot We've got 3 darwin-arm64 up for each of macOS 11 and 12. Think we can close this issue?

gopherbot pushed a commit to golang/build that referenced this issue Apr 28, 2022
@heschi @gopherbot
env/darwin/macstadium: rewrite setup notes
29a15fa 
Generally clean up the notes:
- Restructure them so there's less bouncing around between preferences
  and Terminal and stuff
- include the stage0 script for non-VMs
- Remove obsolete Xcode instructions
- Convert to Markdown

For golang/go#49149.

Change-Id: I893ef85924fca552c8d179146f9db6b1b9b4912f
Reviewed-on: https://go-review.googlesource.com/c/build/+/402737
Reviewed-by: Dmitri Shuralyov <[email protected]>
Run-TryBot: Heschi Kreinick <[email protected]>
Auto-Submit: Heschi Kreinick <[email protected]>
Reviewed-by: Carlos Amedee <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/405294 mentions this issue: [release-branch.go1.18] net: skip TestDialCancel on darwin-arm64

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/405295 mentions this issue: [release-branch.go1.17] net: skip TestDialCancel on darwin-arm64

gopherbot pushed a commit that referenced this issue May 9, 2022
@heschi @dmitshur
[release-branch.go1.18] net: skip TestDialCancel on darwin-arm64
b2b4b9e 
We're turning up Macs in a network environment that clashes with this
test. I don't think it's critical to get it working, so skip it.

For #49149.
Fixes #52706.

Change-Id: I925e3ecc5356c4cefd208bdcff3d98021215d0b4
Reviewed-on: https://go-review.googlesource.com/c/go/+/402181
Reviewed-by: Alex Rakoczy <[email protected]>
Run-TryBot: Heschi Kreinick <[email protected]>
Auto-Submit: Heschi Kreinick <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
(cherry picked from commit 06b0a65)
Reviewed-on: https://go-review.googlesource.com/c/go/+/405294
Reviewed-by: Dmitri Shuralyov <[email protected]>
Run-TryBot: Dmitri Shuralyov <[email protected]>
Reviewed-by: Heschi Kreinick <[email protected]>
gopherbot pushed a commit that referenced this issue May 9, 2022
@heschi @dmitshur
[release-branch.go1.17] net: skip TestDialCancel on darwin-arm64
5b45e19 
We're turning up Macs in a network environment that clashes with this
test. I don't think it's critical to get it working, so skip it.

For #49149.
Fixes #52705.

Change-Id: I925e3ecc5356c4cefd208bdcff3d98021215d0b4
Reviewed-on: https://go-review.googlesource.com/c/go/+/402181
Reviewed-by: Alex Rakoczy <[email protected]>
Run-TryBot: Heschi Kreinick <[email protected]>
Auto-Submit: Heschi Kreinick <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
(cherry picked from commit 06b0a65)
Reviewed-on: https://go-review.googlesource.com/c/go/+/405295
Run-TryBot: Dmitri Shuralyov <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
Reviewed-by: Heschi Kreinick <[email protected]>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/406021 mentions this issue: all: turn up new Mac Minis as their own host type

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/419194 mentions this issue: dashboard, cmd/makemac: drop macOS 10.12 builder

gopherbot pushed a commit to golang/build that referenced this issue Jul 25, 2022
@dmitshur @gopherbot
dashboard, cmd/makemac: drop macOS 10.12 builder
a3d9d89 
Go 1.16 was the last Go release to support macOS 10.12, so that builder
has become unused and its capacity can be reallocated to other builders.

While here, also update makemac to support parsing host types without a
"_0" suffix, so we can start using "host-darwin-amd64-13" instead of
"host-darwin-amd64-13_0", similar to the new arm64 host type names.

For golang/go#23011.
Updates golang/go#49149.

Change-Id: I6bc0948e716ee62f4b5519cb069aa0f06a2ec1af
Reviewed-on: https://go-review.googlesource.com/c/build/+/419194
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
Reviewed-by: Carlos Amedee <[email protected]>
Run-TryBot: Dmitri Shuralyov <[email protected]>
Auto-Submit: Dmitri Shuralyov <[email protected]>
@heschi heschi moved this to Done in Go Release Sep 27, 2022
@gopherbot

This comment was marked as resolved.

Sign in to view
@golang golang locked and limited conversation to collaborators Jan 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. new-builder OS-Darwin
Projects
Go Release
Archived in project
Milestone
Unreleased
Development

No branches or pull requests
8 participants
@toothrot @cagedmantis @dmitshur @ianlancetaylor @randall77 @gopherbot @cherrymui @heschi