Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: run.{bash,bat,rc} sets GOPATH inconsistently [1.15 backport] #45239

Closed
gopherbot opened this issue Mar 25, 2021 · 4 comments
Closed

all: run.{bash,bat,rc} sets GOPATH inconsistently [1.15 backport] #45239

gopherbot opened this issue Mar 25, 2021 · 4 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.15.11

Comments

@gopherbot
Copy link
Contributor

@dmitshur requested issue #45238 to be considered for backport to the next 1.15 minor release.

@gopherbot Please consider this for backport.

This should be a test-only fix, since releases use make.bash (all.bash is used only during release testing), and is needed to be able to run long tests for future 1.16 and 1.15 minor releases (issue #29252).
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Mar 25, 2021
@gopherbot gopherbot mentioned this issue Mar 25, 2021
Closed
@gopherbot gopherbot added this to the Go1.15.11 milestone Mar 25, 2021
@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/304773 mentions this issue: [release-branch.go1.15] build: set GOPATH consistently in run.bash, run.bat, run.rc

@dmitshur dmitshur mentioned this issue Mar 25, 2021
Closed
@dmitshur
Copy link
Contributor

Approving per discussion in a release meeting. This backport applies to both 1.16 (#45240) and 1.15 (this issue).

@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Mar 25, 2021
@dmitshur dmitshur mentioned this issue Mar 25, 2021
Closed
@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/304949 mentions this issue: cmd/releasebot, cmd/release: add 2 more longtest test-only targets

@gopherbot
Copy link
Contributor Author

Closed by merging 6df5d3a to release-branch.go1.15.

gopherbot pushed a commit that referenced this issue Mar 29, 2021
@rsc @dmitshur
[release-branch.go1.15] build: set GOPATH consistently in run.bash, r…
6df5d3a 
…un.bat, run.rc

We used to clear GOPATH in all the build scripts.
Clearing GOPATH is misleading at best, since you just end up
with the default GOPATH (%USERPROFILE%\go on Windows).
Unless that's your GOROOT, in which case you end up with a
fatal error from the go command (#43938).

run.bash changed to setting GOPATH=/dev/null, which has no
clear analogue on Windows.

run.rc still clears GOPATH.

Change them all to set GOPATH to a non-existent directory
/nonexist-gopath or c:\nonexist-gopath.

For #45238.
Fixes #45239.

Change-Id: I51edd66d37ff6a891b0d0541d91ecba97fbbb03d
Reviewed-on: https://go-review.googlesource.com/c/go/+/288818
Trust: Russ Cox <[email protected]>
Trust: Jason A. Donenfeld <[email protected]>
Reviewed-by: Cherry Zhang <[email protected]>
Reviewed-by: Alex Brainman <[email protected]>
Reviewed-by: Jason A. Donenfeld <[email protected]>
(cherry picked from commit bb6efb9)
Reviewed-on: https://go-review.googlesource.com/c/go/+/304773
Run-TryBot: Dmitri Shuralyov <[email protected]>
TryBot-Result: Go Bot <[email protected]>
Reviewed-by: Alexander Rakoczy <[email protected]>
Reviewed-by: Carlos Amedee <[email protected]>
Trust: Carlos Amedee <[email protected]>
gopherbot pushed a commit to golang/build that referenced this issue Mar 29, 2021
@dmitshur
cmd/releasebot, cmd/release: add 2 more longtest test-only targets
305e1e3 
Add support for a linux-386-longtest test-only target. This is the
third longtest builder that we have.

Both linux-{386,amd64}-longtest targets are passing on master
for future Go 1.17 releases, as well as release-branch.go1.16
and release-branch.go1.15 now that CL 288818 is cherry-picked
(see backport issues golang/go#45240 and golang/go#45239).

Start including them in the release process by default, so that we
have more automated test coverage and more information available
during the upcoming releases, and in turn can use it to improve
the releases and the release process further.

Fixes golang/go#29252.

Change-Id: I9740c9ce5cae73a3ed9fe320219f1044f5fdcc9a
Reviewed-on: https://go-review.googlesource.com/c/build/+/304949
Trust: Dmitri Shuralyov <[email protected]>
Reviewed-by: Alexander Rakoczy <[email protected]>
Reviewed-by: Carlos Amedee <[email protected]>
@dmitshur dmitshur added the Testing An issue that has been verified to require only test changes, not just a test failure. label Apr 1, 2021
@golang golang locked and limited conversation to collaborators Apr 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.15.11
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot