Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime/race: race_linux_amd64.syso now depends on glibc 2.16 [1.14 backport] #38321

Closed
gopherbot opened this issue Apr 9, 2020 · 6 comments
Closed

runtime/race: race_linux_amd64.syso now depends on glibc 2.16 [1.14 backport] #38321

gopherbot opened this issue Apr 9, 2020 · 6 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.14.3

Comments

@gopherbot
Copy link
Contributor

@randall77 requested issue #37485 to be considered for backport to the next 1.14 minor release.

This should be fixed at tip (can you try tip? I've been told this issue has been fixed in compiler-rt but I haven't verified myself).
I don't think we've backported fixes like this before. We'll see if this qualifies for 1.14.3.

@gopherbot Please open a backport issue to 1.14.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Apr 9, 2020
@gopherbot gopherbot mentioned this issue Apr 9, 2020
Closed
@gopherbot gopherbot added this to the Go1.14.3 milestone Apr 9, 2020
@randall77
Copy link
Contributor

This would involve backporting CL 226981 (at least the linux/amd64 part).

@ianlancetaylor
Copy link
Member

This fixes race mode on systems that cannot otherwise use it, so cherry pick approved.

@ianlancetaylor ianlancetaylor added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Apr 30, 2020
@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/231222 mentions this issue: [release-branch.go1.14] runtime/race: update some .syso files

gopherbot pushed a commit that referenced this issue May 4, 2020
@randall77 @ianlancetaylor
[release-branch.go1.14] runtime/race: update some .syso files
6936700 
Update race detector syso files for some platforms.

There's still 2 more to do, but they might take a while so I'm
mailing the ones I have now.

Note: some arm64 tests did not complete successfully due to out
of memory errors, but I suspect the .syso is correct.

For #14481
For #37485 (I think?)
For #37355
Fixes #38321

Change-Id: I7e7e707a1fd7574855a538ba89dc11acc999c760
Reviewed-on: https://go-review.googlesource.com/c/go/+/226981
Run-TryBot: Ian Lance Taylor <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Reviewed-by: Ian Lance Taylor <[email protected]>
(cherry picked from commit 041bcb3)
Reviewed-on: https://go-review.googlesource.com/c/go/+/231222
Reviewed-by: Keith Randall <[email protected]>
@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/232159 mentions this issue: [release-branch.go1.14] runtime/race: update ppc64 .syso file

@gopherbot
Copy link
Contributor Author

Closed by merging 6936700 to release-branch.go1.14.

gopherbot pushed a commit that referenced this issue May 6, 2020
@randall77 @ianlancetaylor
[release-branch.go1.14] runtime/race: update ppc64 .syso file
b338266 
For #14881
For #37355
For #38321

Change-Id: I5edd53b7532836cfe6037fb668b1b8fe8f7a32f9
Reviewed-on: https://go-review.googlesource.com/c/go/+/227443
Run-TryBot: Ian Lance Taylor <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Reviewed-by: Dmitry Vyukov <[email protected]>
(cherry picked from commit 7a35d39)
Reviewed-on: https://go-review.googlesource.com/c/go/+/232159
Reviewed-by: Keith Randall <[email protected]>
@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/232417 mentions this issue: [release-branch.go1.14] runtime/race: rebuild netbsd .syso

gopherbot pushed a commit that referenced this issue May 6, 2020
@randall77 @ianlancetaylor
[release-branch.go1.14] runtime/race: rebuild netbsd .syso
6143ce3 
For #14481
For #37355
For #38321

Change-Id: Idfceaf0e64d340b7304ce9562549a82ebfc27e3c
Reviewed-on: https://go-review.googlesource.com/c/go/+/227867
Run-TryBot: Keith Randall <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Reviewed-by: Dmitry Vyukov <[email protected]>
(cherry picked from commit 3afa741)
Reviewed-on: https://go-review.googlesource.com/c/go/+/232417
Run-TryBot: Ian Lance Taylor <[email protected]>
Reviewed-by: Keith Randall <[email protected]>
@golang golang locked and limited conversation to collaborators May 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.14.3
Development

No branches or pull requests
3 participants
@ianlancetaylor @randall77 @gopherbot