Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile/internal/syntax: TestStdLib verbosely broken on Windows [1.13 backport] #37901

Closed
gopherbot opened this issue Mar 17, 2020 · 2 comments
Closed

cmd/compile/internal/syntax: TestStdLib verbosely broken on Windows [1.13 backport] #37901

gopherbot opened this issue Mar 17, 2020 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.13.10

Comments

@gopherbot
Copy link
Contributor

@dmitshur requested issue #35175 to be considered for backport to the next 1.13 minor release.

@gopherbot, please consider this issue for backport to Go 1.13. This is a test fix. It is needed to resolve a test failure in the cmd/compile/internal/syntax package on windows-amd64-longtest builder, which could be masking other problems (due to #36181) and making releasing Go 1.13.x more difficult.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Mar 17, 2020
@gopherbot gopherbot mentioned this issue Mar 17, 2020
Closed
@gopherbot gopherbot added this to the Go1.13.9 milestone Mar 17, 2020
@dmitshur dmitshur added the Testing An issue that has been verified to require only test changes, not just a test failure. label Mar 17, 2020
@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/223703 mentions this issue: [release-branch.go1.13] cmd/compile/internal/syntax: don't hardwire path separator in test

@cagedmantis cagedmantis modified the milestones: Go1.13.9, Go1.13.10 Mar 19, 2020
@andybons andybons added the CherryPickApproved Used during the release process for point releases label Mar 26, 2020
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Mar 26, 2020
@gopherbot
Copy link
Contributor Author

Closed by merging 5a31a97 to release-branch.go1.13.

gopherbot pushed a commit that referenced this issue Mar 31, 2020
@griesemer @dmitshur
[release-branch.go1.13] cmd/compile/internal/syntax: don't hardwire p…
5a31a97 
…ath separator in test

Windows uses '\' not '/'.

For #35175.
Fixes #37901.

Change-Id: Ib3d01dcf148fc0675496d5213f5bcc9cf210a6fc
Reviewed-on: https://go-review.googlesource.com/c/go/+/203889
Reviewed-by: Bryan C. Mills <[email protected]>
Run-TryBot: Brad Fitzpatrick <[email protected]>
(cherry picked from commit a754d29)
Reviewed-on: https://go-review.googlesource.com/c/go/+/223703
Reviewed-by: Robert Griesemer <[email protected]>
Run-TryBot: Andrew Bonventre <[email protected]>
@golang golang locked and limited conversation to collaborators Mar 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.13.10
Development

No branches or pull requests
4 participants
@cagedmantis @andybons @dmitshur @gopherbot