Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: TestVariousDeadlines failures with "client stuck in Dial+Copy" on NetBSD builders #37883

Closed
bcmills opened this issue Mar 16, 2020 · 9 comments
Closed

net: TestVariousDeadlines failures with "client stuck in Dial+Copy" on NetBSD builders #37883

bcmills opened this issue Mar 16, 2020 · 9 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-NetBSD WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Milestone
Go1.18

Comments

@bcmills
Copy link
Contributor

bcmills commented Mar 16, 2020

2020-03-15T08:19:07-26154f3/netbsd-amd64-8_0
2019-11-06T02:52:51-f71bd51/netbsd-amd64-8_0
2019-11-05T20:47:22-fb37821/netbsd-amd64-8_0
2019-09-19T15:51:38-e53edaf/netbsd-arm-bsiegert
2019-08-28T20:26:53-aced50a/netbsd-arm-bsiegert

CC @bsiegert @mikioh @bradfitz @ianlancetaylor
@bcmills bcmills added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-NetBSD labels Mar 16, 2020
@bcmills bcmills added this to the Backlog milestone Mar 16, 2020
@bsiegert
Copy link
Contributor

/cc @tklauser

@bcmills
Copy link
Contributor Author

bcmills commented Apr 9, 2020

2020-04-09T01:17:53-0a18cbc/netbsd-amd64-8_0

(CC @dmitshur, who I believe is working on NetBSD builders this week.)

@bsiegert
Copy link
Contributor

bsiegert commented Apr 9, 2020

I am hoping that the update to NetBSD 9 will fix this.

@bcmills bcmills mentioned this issue Oct 8, 2020
Closed
@bcmills
Copy link
Contributor Author

bcmills commented May 7, 2021 •
edited
Loading

I am hoping that the update to NetBSD 9 will fix this.

[Narrator: it did not.]

2021-05-07T03:55:29-f5423ea/netbsd-386-9_0
2021-04-12T10:30:24-c26f954/netbsd-arm64-bsiegert
2021-04-07T03:42:11-8462169/netbsd-arm-bsiegert
2021-04-05T15:29:05-ee51e3d/netbsd-amd64-9_0
2021-03-25T08:43:17-402d784/netbsd-arm-bsiegert
2021-03-24T19:18:50-fef5a15/netbsd-amd64-9_0
2021-03-18T00:08:55-2583c1b/netbsd-arm-bsiegert
2021-03-15T20:04:23-a9cfd55/netbsd-amd64-9_0
2021-03-13T11:52:17-b3235b7/netbsd-arm-bsiegert
2021-03-04T03:29:58-95ff296/netbsd-arm64-bsiegert
2021-02-23T12:14:32-b3b65f2/netbsd-arm64-bsiegert
2021-01-25T23:54:44-bf0f7c9/netbsd-arm-bsiegert
2021-01-08T20:19:51-6192b98/netbsd-arm64-bsiegert
2020-12-25T23:54:24-2018b68/netbsd-386-9_0
2020-11-17T15:10:45-0968d2d/netbsd-386-9_0
2020-11-05T16:43:34-40f0359/netbsd-amd64-9_0
2020-11-05T10:46:08-3510a1e/netbsd-arm-bsiegert
2020-10-20T00:59:23-a505312/netbsd-amd64-9_0
2020-09-23T11:49:55-4d7abd7/netbsd-386-9_0
2020-09-22T07:12:52-7547768/netbsd-amd64-9_0
2020-09-09T22:03:39-b4944ef/netbsd-386-9_0
2020-08-15T04:45:34-69d34e2/netbsd-386-9_0
2020-05-06T16:25:52-2189852/netbsd-386-9_0
2020-05-06T15:41:25-ef3571b/netbsd-amd64-9_0

@bcmills
Copy link
Contributor Author

bcmills commented Oct 5, 2021

greplogs --dashboard -md -l -e 'client stuck in Dial' --since=2021-05-08

2021-10-05T07:32:41-d55009c/netbsd-arm64-bsiegert
2021-09-29T20:06:10-5930cff/netbsd-amd64-9_0
2021-09-27T13:35:50-516d75c/netbsd-arm-bsiegert
2021-09-21T20:28:32-1367a60/netbsd-amd64-9_0
2021-08-30T02:40:35-21d0b30/netbsd-386-9_0
2021-08-28T16:00:51-d7a43e8/netbsd-arm-bsiegert
2021-08-25T01:57:42-de1c934/netbsd-arm-bsiegert
2021-08-20T21:00:08-97d17dc/freebsd-amd64-11_4
2021-08-18T22:16:57-eda3de0/netbsd-arm-bsiegert
2021-08-09T20:06:35-f1dce31/netbsd-arm-bsiegert
2021-08-06T20:44:03-63b968f/netbsd-386-9_0
2021-06-18T22:05:09-9401172/netbsd-386-9_0
2021-06-09T16:35:20-ec3026d/netbsd-amd64-9_0
2021-05-12T17:32:39-f93b951/netbsd-arm64-bsiegert
2021-05-11T14:21:06-2520e72/netbsd-amd64-9_0

@bcmills
Copy link
Contributor Author

bcmills commented Dec 14, 2021

greplogs --dashboard -md -l -e 'client stuck in Dial' --since=2021-10-06

2021-12-14T21:23:43-fc8ae98/netbsd-amd64-9_0-n2
2021-12-14T17:43:51-becaeea/netbsd-386-9_0-n2
2021-11-24T21:09:36-7e5331a/netbsd-amd64-9_0-n1
2021-11-19T22:35:28-b31dda8/netbsd-arm-bsiegert
2021-11-14T16:54:11-dfa62c7/netbsd-amd64-9_0
2021-11-09T18:23:16-55e6e82/netbsd-amd64-9_0
2021-11-04T07:05:31-2622235/netbsd-arm-bsiegert
2021-10-28T02:35:22-056dfe6/netbsd-386-9_0
2021-10-23T16:18:15-12e4404/netbsd-arm-bsiegert
2021-10-11T20:46:14-7023535/netbsd-arm-bsiegert
2021-10-09T14:53:12-eba91e8/netbsd-arm-bsiegert
2021-10-07T03:41:40-6f74ed0/netbsd-arm-bsiegert

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/371994 mentions this issue: net: eliminate arbitrary timeout in TestVariousDeadlines

@bcmills
Copy link
Contributor Author

bcmills commented Dec 14, 2021

This test fails frequently even on builders not affected by #49209. It should be diagnosed and either fixed (if a Go bug) or skipped (if a platform bug).

@bcmills bcmills added okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 release-blocker labels Dec 14, 2021
@bcmills bcmills modified the milestones: Backlog, Go1.18 Dec 14, 2021
@bcmills bcmills self-assigned this Dec 14, 2021
@bcmills bcmills added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Dec 14, 2021
gopherbot pushed a commit that referenced this issue Dec 15, 2021
net: eliminate arbitrary timeout in TestVariousDeadlines
b5c0dba 
When we set a timeout, we don't actually have a guarantee one how long
the OS will take to notice it. Moreover, if the test deadlocks
completely (for example, due to a deadline never taking effect), it
would be more useful to get a full goroutine dump instead of the current
"client stuck in Dial+Copy" failure message.

For #37883
For #41863

Change-Id: I9f712ef1c620f97a5ab69baac45deb71134b99bc
Reviewed-on: https://go-review.googlesource.com/c/go/+/371994
Trust: Bryan Mills <[email protected]>
Run-TryBot: Bryan Mills <[email protected]>
Reviewed-by: Ian Lance Taylor <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
@bcmills bcmills removed okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 release-blocker labels Dec 15, 2021
@bcmills
Copy link
Contributor Author

bcmills commented Jan 12, 2022

No new failures since CL 371994. I'm calling this fixed.

greplogs --dashboard -md -l -e 'client stuck in Dial' --since=2021-12-16

@bcmills bcmills closed this as completed Jan 12, 2022
@bcmills bcmills mentioned this issue May 19, 2022
Closed
@rsc rsc unassigned bcmills Jun 23, 2022
@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-NetBSD WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
None yet
Milestone
Go1.18
Development

No branches or pull requests
3 participants
@bsiegert @bcmills @gopherbot