-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/build: warn in TryBot CL comment if the parent commit is old #30807
Comments
Also see: #19664 (x/build: make trybots refuse to test a commit that's too old), only difference is that you're asking for a warning and not an hard refusal. May be worth to just move the discussion there and decide if a warning of a refusal is better. |
It looks like the original commit stalled because they couldn't reach a consensus on what the right limit should be. A number of days, a number of commits, some combination of both? Perhaps we can start with a warning and see if it's too agressive or conservative. And if we're happy with it, consider replacing the warning with an error. |
It stalled on time to implement it more than deciding anything. |
Change https://golang.org/cl/170457 mentions this issue: |
Updates golang/go#19664 Updates golang/go#9858 Updates golang/go#30807 Change-Id: I378979e2745b4d34286a3a038161eb03148771e7 Reviewed-on: https://go-review.googlesource.com/c/build/+/170457 Reviewed-by: Dmitri Shuralyov <[email protected]>
Duplicate of #19664 |
On #30785, @bradfitz helpfully noticed that the baseline I was testing against was quite old.
It would have been even more helpful if the bot would have told me that instead of requiring human intervention. 🙂
The TryBot result for my test said:
Perhaps it also could have said something like:
(CC @dmitshur)
The text was updated successfully, but these errors were encountered: