Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build: add Windows builder for long tests #26529

Closed
ysmolski opened this issue Jul 22, 2018 · 6 comments
Closed

x/build: add Windows builder for long tests #26529

ysmolski opened this issue Jul 22, 2018 · 6 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge new-builder OS-Windows
Milestone
Unreleased

Comments

@ysmolski
Copy link
Member

We should run long tests on all major platforms, not only on Linux. Whenever test is removed from the short mode, it gets neglected because long tests are not run automatically.

As pointed out by @alexbrainman recently in #26469, Windows long tests are badly broken: #26469 (comment)

#26473 might move even more tests to the long mode.
@gopherbot gopherbot added this to the Unreleased milestone Jul 22, 2018
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Jul 22, 2018
@bradfitz
Copy link
Contributor

bradfitz commented Aug 3, 2018

Sure, this would be fine and easy.

Good warm-up project for @dmitshur.

@ALTree ALTree mentioned this issue Jan 9, 2019
Closed
@bcmills bcmills mentioned this issue Jan 18, 2019
Closed
@bradfitz
Copy link
Contributor

Maybe @bcmills wants to do this.

@bcmills
Copy link
Contributor

bcmills commented Sep 16, 2019

CC @toothrot

@bcmills bcmills mentioned this issue Sep 16, 2019
Closed
@bcmills bcmills mentioned this issue Oct 21, 2019
Closed
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/202479 mentions this issue: dashboard: add windows and 32-bit longtest builders

@bradfitz bradfitz mentioned this issue Oct 22, 2019
Closed
@bcmills
Copy link
Contributor

bcmills commented Oct 26, 2019

One failure down (#35117), another found (#35175). This this is gonna be passing someday, I just know it!

@bcmills
Copy link
Contributor

bcmills commented Oct 29, 2019

The saga continues with #35236.

codebien pushed a commit to codebien/build that referenced this issue Nov 13, 2019
@bradfitz @codebien
dashboard: add windows and 32-bit longtest builders
b35429e 
Fixes golang/go#29641
Fixes golang/go#26529

Change-Id: I5ab3aa443276ab36b866d7fabc1d78a82b34cb64
Reviewed-on: https://go-review.googlesource.com/c/build/+/202479
Reviewed-by: Bryan C. Mills <[email protected]>
@bcmills bcmills mentioned this issue Nov 18, 2019
Closed
@golang golang locked and limited conversation to collaborators Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge new-builder OS-Windows
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@bradfitz @ysmolski @dmitshur @bcmills @gopherbot