x/sys/unix: Capsicum support breaks freebsd build #21136

ncw · 2017-07-23T21:16:52Z

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (`go version`)?

go version go1.8.3 linux/amd64

What operating system and processor architecture are you using (`go env`)?

GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/ncw/go"
GORACE=""
GOROOT="/opt/go/go1.8"
GOTOOLDIR="/opt/go/go1.8/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build712833005=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="1"
PKG_CONFIG="pkg-config"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"

What did you do?

cd ${GOPATH}/src/golang.org/x/sys
GOOS=freebsd GOARCH=386 go install ./...

What did you expect to see?

No error

What did you see instead?

# golang.org/x/sys/unix
unix/cap_freebsd.go:18: undefined: CAP_RIGHTS_VERSION_00
unix/cap_freebsd.go:19: undefined: CAP_RIGHTS_VERSION_00
unix/cap_freebsd.go:19: const initializer CAP_RIGHTS_VERSION_00 + 2 is not a constant
unix/cap_freebsd.go:46: undefined: CapRights
unix/cap_freebsd.go:50: undefined: CapRights
unix/cap_freebsd.go:55: undefined: CapRights
unix/cap_freebsd.go:90: undefined: CapRights
unix/cap_freebsd.go:125: undefined: CapRights
unix/cap_freebsd.go:164: undefined: CapRights
unix/cap_freebsd.go:179: undefined: CapRights
unix/cap_freebsd.go:179: too many errors

I bisected the problem to this commit

golang/sys@7a4fde3

@benlaurie committed with @ianlancetaylor

According to https://go-review.googlesource.com/c/47290/ the trybots ran OK so I'm a bit puzzled about this.

The text was updated successfully, but these errors were encountered:

Until golang/go#21136 is fixed

agilob · 2017-07-25T17:55:17Z

the trybots ran OK so I'm a bit puzzled about this.

Breaks compilation of any go package on FBSD i386 too.

bradfitz · 2017-07-25T18:03:10Z

the trybots ran OK so I'm a bit puzzled about this.

I filed #21163

ALTree · 2017-07-25T18:03:35Z

According to https://go-review.googlesource.com/c/47290/ the trybots ran OK so I'm a bit puzzled about this.

AFAIK we don't have a freebsd/386 trybot.

slon · 2017-07-26T15:33:07Z

Hello. May I claim this issue?

gopherbot · 2017-07-26T16:56:43Z

CL https://golang.org/cl/51270 mentions this issue.

bradfitz · 2017-07-26T16:57:09Z

@slon, yes, you could've sent a change (no need to ask), but the fix was simple enough that I just sent it.

Now that golang/go#21136 is fixed

Capsicum support was added by https://golang.org/cl/47290, but oinly for amd64. This broke the freebsd/386 build which was subsequently fixed by http://golang.org/cl/51270. However, even with this fix the tests still fail to build due to the missing Cap* functions and types. Fix the build/test on FreeBSD 386 for real by re-running mkall.sh to get all the Capsicum functions and types. Updates golang/go#21136 Change-Id: I54fe2c4567674b07dedad677756369a43a1f0ef6

gopherbot · 2017-07-27T15:27:24Z

Change https://golang.org/cl/51570 mentions this issue: unix: re-enable Capsicum on FreeBSD 386

Capsicum support was added by https://golang.org/cl/47290, but only for amd64. This broke the freebsd/386 build which was subsequently fixed by http://golang.org/cl/51270. However, even with this fix the tests still fail to build due to the missing Capsicum functions and types. Fix the build/test on freebsd/386 for real by re-running mkall.sh on FreeBSD 11.1-RELEASE (inside VirtualBox) to get all the Capsicum functions and types. Some zerrors constants were removed or converted to enums in the FreeBSD headers. Manually move them to a dedicated file. Do the same for amd64, where these constants were removed by accident in https://golang.org/cl/47290. Updates golang/go#21136 Change-Id: I54fe2c4567674b07dedad677756369a43a1f0ef6

Capsicum support was added by https://golang.org/cl/47290, but only for amd64. This broke the freebsd/386 build which was subsequently fixed by http://golang.org/cl/51270. However, even with this fix the tests still fail to build due to the missing Capsicum functions and types. Fix the build/test on freebsd/386 for real by re-running mkall.sh on FreeBSD 11.1-RELEASE (inside VirtualBox) to get all the Capsicum functions and types. Some zerrors constants were removed or converted to enums in the FreeBSD headers. Manually move them to a dedicated file. Do the same for amd64, where these constants were removed by accident in https://golang.org/cl/47290. Updates golang/go#21136 Change-Id: I54fe2c4567674b07dedad677756369a43a1f0ef6 Reviewed-on: https://go-review.googlesource.com/51570 Reviewed-by: Brad Fitzpatrick <[email protected]> Run-TryBot: Brad Fitzpatrick <[email protected]> TryBot-Result: Gobot Gobot <[email protected]>

hacdias · 2017-07-29T19:00:00Z

I'm getting this error too @ncw, how did you solve it?

ncw · 2017-07-29T22:37:34Z

@hacdias just update - it should be fixed now. It is for me any way.

hacdias · 2017-07-30T07:36:52Z

I'm getting this error on Travis though with Go 1.8.3. I'll try to figure out why.

benlaurie · 2017-07-30T18:47:04Z

What version of FreeBSD are those with problems running?

hacdias · 2017-07-30T18:51:25Z

In my case it's cross compiling on Ubuntu Trusty on Travis CI.

benlaurie · 2017-07-30T18:55:38Z

I guess whatever you're using for cross-compiling is not up-to-date...

hacdias · 2017-07-30T18:57:37Z

I'll check that out, thanks @benlaurie

ncw · 2017-07-30T19:42:19Z

@hacdias You need to update golang.org/x/sys so go get -u golang.org/x/sys

mikioh · 2017-07-31T00:01:51Z

The build is still broken on freebsd/arm.

export GOOS=freebsd
export GOARCH=arm

go build
# golang.org/x/sys/unix
./cap_freebsd.go:18:23: undefined: CAP_RIGHTS_VERSION_00
./cap_freebsd.go:19:2: const initializer CAP_RIGHTS_VERSION_00 + 2 is not a constant
./cap_freebsd.go:19:23: undefined: CAP_RIGHTS_VERSION_00
./cap_freebsd.go:46:21: undefined: CapRights
./cap_freebsd.go:50:24: undefined: CapRights
./cap_freebsd.go:55:27: undefined: CapRights
./cap_freebsd.go:90:29: undefined: CapRights
./cap_freebsd.go:125:29: undefined: CapRights
./cap_freebsd.go:164:39: undefined: CapRights
./cap_freebsd.go:179:41: undefined: CapRights
./cap_freebsd.go:179:41: too many errors

go test -c
# golang.org/x/sys/unix
./cap_freebsd.go:18:23: undefined: CAP_RIGHTS_VERSION_00
./cap_freebsd.go:19:2: const initializer CAP_RIGHTS_VERSION_00 + 2 is not a constant
./cap_freebsd.go:19:23: undefined: CAP_RIGHTS_VERSION_00
./cap_freebsd.go:46:21: undefined: CapRights
./cap_freebsd.go:50:24: undefined: CapRights
./cap_freebsd.go:55:27: undefined: CapRights
./cap_freebsd.go:90:29: undefined: CapRights
./cap_freebsd.go:125:29: undefined: CapRights
./cap_freebsd.go:164:39: undefined: CapRights
./cap_freebsd.go:179:41: undefined: CapRights
./cap_freebsd.go:179:41: too many errors

hacdias · 2017-07-31T06:31:17Z

Yeah, I get the exact same error on Travis, which always downloads the latest commit of each dependency through go get.

hacdias · 2017-07-31T14:50:10Z

It's also broken on openbsd/arm6:

GOOS=openbsd GOARCH=arm GOARM=6 go build -ldflags='-s -w -X main.version=1.0.4 -X main.commit=1dcb5944c3de638dfa22f8c19728820f33118496 -X main.date=2017-07-31T09:47:18Z' -o dist/openbsd-arm-filemanager/filemanager cmd/filemanager/main.go

travis@d282747cb28c:~/gopath/src/github.com/hacdias/filemanager$ GOOS=openbsd GOARCH=arm GOARM=6 go build -ldflags='-s -w -X main.version=1.0.4 -X main.commit=1dcb5944c3de638dfa22f8c19728820f33118496 -X main.date=2017-07-31T09:47:18Z' -o dist/openbsd-arm-filemanager/filemanager cmd/filemanager/main.go
# golang.org/x/sys/unix
../../../golang.org/x/sys/unix/flock.go:16: undefined: Flock_t
../../../golang.org/x/sys/unix/sockcmsg_unix.go:37: undefined: Cmsghdr
../../../golang.org/x/sys/unix/sockcmsg_unix.go:43: undefined: Cmsghdr

No error without ldflags.

mikioh · 2017-08-01T00:02:22Z

@hacdias,

That's an obviously different issue. Please file a new issue and makes this issue focus on FreeBSD stuff.

nbari · 2017-08-03T11:28:23Z

I am using goxc, to cross-compile but getting exactly this error, tried to update go get -u golang.org/x/sys/unix but still having the issue, current go version: go version go1.8.3 darwin/amd64 just in case this is the Makefile some output:

$ make compile
/Users/nbari/projects/go/bin/goxc -os="freebsd netbsd openbsd darwin linux windows" -bc="!386"
[goxc:go-vet] 2017/08/03 13:25:33 Task go-vet succeeded
ok      github.com/ssh-vault/ssh-vault  3.109s
?       github.com/ssh-vault/ssh-vault/cmd/ssh-vault    [no test files]
[goxc:go-test] 2017/08/03 13:25:37 Task go-test succeeded
[goxc:go-install] 2017/08/03 13:25:37 Task go-install succeeded
[goxc:xc] 2017/08/03 13:25:37 Parallelizing xc for 9 platforms, using max 3 of 4 processors
# golang.org/x/sys/unix
../../../../../golang.org/x/sys/unix/cap_freebsd.go:18: undefined: CAP_RIGHTS_VERSION_00
../../../../../golang.org/x/sys/unix/cap_freebsd.go:19: undefined: CAP_RIGHTS_VERSION_00
../../../../../golang.org/x/sys/unix/cap_freebsd.go:19: const initializer CAP_RIGHTS_VERSION_00 + 2 is not a constant
../../../../../golang.org/x/sys/unix/cap_freebsd.go:46: undefined: CapRights
../../../../../golang.org/x/sys/unix/cap_freebsd.go:50: undefined: CapRights
../../../../../golang.org/x/sys/unix/cap_freebsd.go:55: undefined: CapRights
../../../../../golang.org/x/sys/unix/cap_freebsd.go:90: undefined: CapRights
../../../../../golang.org/x/sys/unix/cap_freebsd.go:125: undefined: CapRights
../../../../../golang.org/x/sys/unix/cap_freebsd.go:164: undefined: CapRights
../../../../../golang.org/x/sys/unix/cap_freebsd.go:179: undefined: CapRights
../../../../../golang.org/x/sys/unix/cap_freebsd.go:179: too many errors
[goxc:xc] 2017/08/03 13:26:10 'go' returned error: Wait error: exit status 2: # golang.org/x/sys/unix

benlaurie · 2017-08-03T11:36:44Z

The problem is goxc doesn't have support for current FreeBSD, it seems.

nbari · 2017-08-03T11:44:24Z

@benlaurie Hi, thanks for the hint, I just tried with this:

env GOOS=freebsd GOARCH=amd64 make

and is working.

tklauser · 2017-08-04T12:29:36Z

The Capsicum types and constants in x/sys/unix were not generated for freebsd/arm or freebsd/386 in https://golang.org/cl/47290. I fixed the situation for freebsd/386 in https://golang.org/cl/51570 and will try to get a freebsd/arm system set up somewhere to generate them there as well (I didn't manage to generate them using a cross-compile setup).

gopherbot · 2017-08-08T15:00:14Z

Change https://golang.org/cl/53639 mentions this issue: unix: fix freebsd/arm build, fix freebsd/386 tests

gopherbot · 2017-08-08T15:02:58Z

Change https://golang.org/cl/53691 mentions this issue: unix: fix freebsd/arm build, fix freebsd/{386,arm} tests

It was broken by https://golang.org/cl/47290 Fixes golang/go#21136 Change-Id: I2a08869fd44a9776f0dc7d461814e1df4e606b5d Reviewed-on: https://go-review.googlesource.com/51270 Reviewed-by: Ian Lance Taylor <[email protected]>

Capsicum support was added by https://golang.org/cl/47290, but only for amd64. This broke the freebsd/386 build which was subsequently fixed by http://golang.org/cl/51270. However, even with this fix the tests still fail to build due to the missing Capsicum functions and types. Fix the build/test on freebsd/386 for real by re-running mkall.sh on FreeBSD 11.1-RELEASE (inside VirtualBox) to get all the Capsicum functions and types. Some zerrors constants were removed or converted to enums in the FreeBSD headers. Manually move them to a dedicated file. Do the same for amd64, where these constants were removed by accident in https://golang.org/cl/47290. Updates golang/go#21136 Change-Id: I54fe2c4567674b07dedad677756369a43a1f0ef6 Reviewed-on: https://go-review.googlesource.com/51570 Reviewed-by: Brad Fitzpatrick <[email protected]> Run-TryBot: Brad Fitzpatrick <[email protected]> TryBot-Result: Gobot Gobot <[email protected]>

Re-run mkall.sh on FreeBSD-11.1-RELEASE armv6 for Capsicum consts and POSIX.1-2008 path relative *at() syscalls. Add errors_freebsd_arm.go generated semi-automatically using: https://gist.github.com/paulzhol/c6d54dc2baf2a6bd204b343a15459661 Similar to https://golang.org/cl/51570. In order to handle C enum based constants that mkerrors.sh missed. Use fix from https://golang.org/cl/53639 to run Capsicum tests only on amd64. Fixes golang/go#21136 Change-Id: I9681b033531090e6b1c5e2446a442deb39cf3066 Reviewed-on: https://go-review.googlesource.com/53691 Reviewed-by: Brad Fitzpatrick <[email protected]> Reviewed-by: Tobias Klauser <[email protected]> Run-TryBot: Brad Fitzpatrick <[email protected]> TryBot-Result: Gobot Gobot <[email protected]>

gopherbot added this to the Unreleased milestone Jul 23, 2017

ncw added a commit to rclone/rclone that referenced this issue Jul 23, 2017

vendor: roll back golang.org/x/sys to fix compile

6fce1ac

Until golang/go#21136 is fixed

mikioh changed the title ~~x/sys: Compile broken for freebsd/386~~ x/sys/unix: broken for freebsd/{arm,386} Jul 25, 2017

mikioh added the help wanted label Jul 25, 2017

bradfitz mentioned this issue Jul 25, 2017

x/build: trybots should always compile for all platforms on subrepos #21163

Closed

gopherbot closed this as completed in golang/sys@02a6680 Jul 26, 2017

ncw added a commit to rclone/rclone that referenced this issue Jul 26, 2017

vendor: update golang.org/x/sys

da9926d

Now that golang/go#21136 is fixed

mikioh reopened this Jul 31, 2017

hacdias mentioned this issue Jul 31, 2017

Error compiling for openbsd/arm and freebsd/6 goreleaser/goreleaser#318

Closed

mikioh changed the title ~~x/sys/unix: broken for freebsd/{arm,386}~~ x/sys/unix: Capsicum support breaks freebsd build Jul 31, 2017

mikioh added the OS-FreeBSD label Aug 1, 2017

gopherbot closed this as completed in golang/sys@47bdb83 Aug 8, 2017

golang locked and limited conversation to collaborators Aug 8, 2018

gopherbot added the FrozenDueToAge label Aug 8, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

x/sys/unix: Capsicum support breaks freebsd build #21136

x/sys/unix: Capsicum support breaks freebsd build #21136

ncw commented Jul 23, 2017

agilob commented Jul 25, 2017

bradfitz commented Jul 25, 2017

ALTree commented Jul 25, 2017

slon commented Jul 26, 2017

gopherbot commented Jul 26, 2017

bradfitz commented Jul 26, 2017

gopherbot commented Jul 27, 2017

hacdias commented Jul 29, 2017

ncw commented Jul 29, 2017

hacdias commented Jul 30, 2017

benlaurie commented Jul 30, 2017

hacdias commented Jul 30, 2017

benlaurie commented Jul 30, 2017

hacdias commented Jul 30, 2017

ncw commented Jul 30, 2017

mikioh commented Jul 31, 2017

hacdias commented Jul 31, 2017

hacdias commented Jul 31, 2017

mikioh commented Aug 1, 2017 •

edited

Loading

nbari commented Aug 3, 2017

benlaurie commented Aug 3, 2017

nbari commented Aug 3, 2017

tklauser commented Aug 4, 2017

gopherbot commented Aug 8, 2017

gopherbot commented Aug 8, 2017

x/sys/unix: Capsicum support breaks freebsd build #21136

x/sys/unix: Capsicum support breaks freebsd build #21136

Comments

ncw commented Jul 23, 2017

What version of Go are you using (go version)?

What operating system and processor architecture are you using (go env)?

What did you do?

What did you expect to see?

What did you see instead?

agilob commented Jul 25, 2017

bradfitz commented Jul 25, 2017

ALTree commented Jul 25, 2017

slon commented Jul 26, 2017

gopherbot commented Jul 26, 2017

bradfitz commented Jul 26, 2017

gopherbot commented Jul 27, 2017

hacdias commented Jul 29, 2017

ncw commented Jul 29, 2017

hacdias commented Jul 30, 2017

benlaurie commented Jul 30, 2017

hacdias commented Jul 30, 2017

benlaurie commented Jul 30, 2017

hacdias commented Jul 30, 2017

ncw commented Jul 30, 2017

mikioh commented Jul 31, 2017

hacdias commented Jul 31, 2017

hacdias commented Jul 31, 2017

mikioh commented Aug 1, 2017 • edited Loading

nbari commented Aug 3, 2017

benlaurie commented Aug 3, 2017

nbari commented Aug 3, 2017

tklauser commented Aug 4, 2017

gopherbot commented Aug 8, 2017

gopherbot commented Aug 8, 2017

What version of Go are you using (`go version`)?

What operating system and processor architecture are you using (`go env`)?

mikioh commented Aug 1, 2017 •

edited

Loading