Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: move things from internal to vendor for Go 1.7 #14047

Closed
bradfitz opened this issue Jan 20, 2016 · 6 comments
Closed

src: move things from internal to vendor for Go 1.7 #14047

bradfitz opened this issue Jan 20, 2016 · 6 comments
Labels
FrozenDueToAge Vendoring
Milestone
Go1.7

Comments

@bradfitz
Copy link
Contributor

Let's move stuff out of $GOROOT/src/internal and into $GOROOT/src/vendor for Go 1.7.

Related bugs: #13961 and #14031
@bradfitz bradfitz added this to the Go1.7 milestone Jan 20, 2016
@bradfitz
Copy link
Contributor Author

bradfitz commented Feb 9, 2016

Revert this CL too: https://go-review.googlesource.com/#/c/19384/1

/cc @rsc

@rsc
Copy link
Contributor

rsc commented Feb 9, 2016

To be clear, the only vendor-able stuff in $GOROOT/src/internal is hpack, right?

@bradfitz
Copy link
Contributor Author

Yes, currently. There was talk of moving singleflight to syncutil too, which has 3-4 copies lately, which are starting to diverge.

@bradfitz bradfitz self-assigned this Mar 24, 2016
@gopherbot
Copy link
Contributor

CL https://golang.org/cl/21063 mentions this issue.

gopherbot pushed a commit that referenced this issue Mar 24, 2016
@bradfitz
vendor: move golang.org/x/net/http2/hpack back to vendor
0104a31 
Updates #14047

Change-Id: I7e314e2c7e3e8da18ab023729740fbc9ea3f661e
Reviewed-on: https://go-review.googlesource.com/21063
Run-TryBot: Brad Fitzpatrick <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Reviewed-by: Robert Griesemer <[email protected]>
@bradfitz
Copy link
Contributor Author

bradfitz commented May 1, 2016

Did enough.

@bradfitz bradfitz closed this as completed May 1, 2016
@gopherbot
Copy link
Contributor

CL https://golang.org/cl/23114 mentions this issue.

gopherbot pushed a commit that referenced this issue May 14, 2016
@kostya-sh @bradfitz
cmd/vendor: move cmd/internal/unvendor packages to cmd/vendor
094afe0 
Updates #14047

Change-Id: I4b150533393bfb90e840497095ac32bcca4f04c2
Reviewed-on: https://go-review.googlesource.com/23114
Run-TryBot: Brad Fitzpatrick <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Reviewed-by: Brad Fitzpatrick <[email protected]>
@golang golang locked and limited conversation to collaborators May 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge Vendoring
Projects
None yet
Milestone
Go1.7
Development

No branches or pull requests
3 participants
@bradfitz @rsc @gopherbot