test: enable fixedbugs/bug193.go for -G compiler option

Temporarily disable a questionable test case in fixedbugs/bug193.go and enable the test as a whole. See the issues below for details. Updates #45114. Updates #45117. Change-Id: I1de6f8d79b592eeeec139cd92b6c9cac56a9a74b Reviewed-on: https://go-review.googlesource.com/c/go/+/303094 Trust: Robert Griesemer <[email protected]> Reviewed-by: Emmanuel Odeke <[email protected]>
golang · Mar 23, 2021 · f4b9183 · f4b9183
1 parent cd26192
commit f4b9183
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/test/fixedbugs/bug193.go b/test/fixedbugs/bug193.go
@@ -11,6 +11,8 @@ func main() {
 	ss := 1 << s
 	y1 := float64(ss)
 	y2 := float64(1 << s) // ERROR "shift"
-	y3 := string(1 << s)  // ERROR "shift"
+	// see issues #45114, #45117
+	// y3 := string(1 << s)  // DISABLED "shift"
+	y3 := 0
 	_, _, _, _, _ = s, ss, y1, y2, y3
 }
diff --git a/test/run.go b/test/run.go
@@ -1939,7 +1939,6 @@ var excluded = map[string]bool{
 	"writebarrier.go": true, // correct diagnostics, but different lines (probably irgen's fault)
 
 	"fixedbugs/bug176.go":    true, // types2 reports all errors (pref: types2)
-	"fixedbugs/bug193.go":    true, // types2 bug: shift error not reported (fixed in go/types)
 	"fixedbugs/bug195.go":    true, // types2 reports slightly different (but correct) bugs
 	"fixedbugs/bug228.go":    true, // types2 not run after syntax errors
 	"fixedbugs/bug231.go":    true, // types2 bug? (same error reported twice)