Skip to content

Commit

Permalink
runtime/metrics: remove unused StopTheWorld Description field
Browse files Browse the repository at this point in the history
This change removes the as-of-yet unused StopTheWorld field in the
Description struct. Adding a new field to a struct is much easier than
removing it, so let's save it for when we actually need it.

Change-Id: I8074b8569187c1a148500575fa8a661534e875d5
Reviewed-on: https://go-review.googlesource.com/c/go/+/282632
Run-TryBot: Michael Knyszek <[email protected]>
TryBot-Result: Go Bot <[email protected]>
Trust: Michael Knyszek <[email protected]>
Reviewed-by: Michael Pratt <[email protected]>
Reviewed-by: Austin Clements <[email protected]>
  • Loading branch information
mknyszek committed Jan 8, 2021
1 parent 6598c65 commit 8f6a9ac
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 5 deletions.
1 change: 0 additions & 1 deletion api/go1.16.txt
Original file line number Diff line number Diff line change
Expand Up @@ -395,7 +395,6 @@ pkg runtime/metrics, type Description struct, Cumulative bool
pkg runtime/metrics, type Description struct, Description string
pkg runtime/metrics, type Description struct, Kind ValueKind
pkg runtime/metrics, type Description struct, Name string
pkg runtime/metrics, type Description struct, StopTheWorld bool
pkg runtime/metrics, type Float64Histogram struct
pkg runtime/metrics, type Float64Histogram struct, Buckets []float64
pkg runtime/metrics, type Float64Histogram struct, Counts []uint64
Expand Down
4 changes: 0 additions & 4 deletions src/runtime/metrics/description.go
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,6 @@ type Description struct {
//
// This flag thus indicates whether or not it's useful to compute a rate from this value.
Cumulative bool

// StopTheWorld is whether or not the metric requires a stop-the-world
// event in order to collect it.
StopTheWorld bool
}

// The English language descriptions below must be kept in sync with the
Expand Down

0 comments on commit 8f6a9ac

Please sign in to comment.