Skip to content

Commit

Permalink
cmd/compile: remove outdate TODO in inl.go
Browse files Browse the repository at this point in the history
Mid-stack inlining is enable now, see #19348, but we still can not
remove the special case for runtime.heapBits.nextArena, because
runtime.heapBits.next is too complex to be inlined
(cost 96 exceeds budget 80).

Change-Id: I04ea86509074afdc83a3f70d68b8a1a8829763d1
Reviewed-on: https://go-review.googlesource.com/c/go/+/174839
Reviewed-by: Brad Fitzpatrick <[email protected]>
  • Loading branch information
cuonglm authored and bradfitz committed May 2, 2019
1 parent 2316784 commit 19f5c23
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions src/cmd/compile/internal/gc/inl.go
Original file line number Diff line number Diff line change
Expand Up @@ -343,10 +343,6 @@ func (v *hairyVisitor) visit(n *Node) bool {
// runtime.heapBits.next even though
// it calls slow-path
// runtime.heapBits.nextArena.
//
// TODO(austin): Once mid-stack
// inlining is the default, remove
// this special case.
break
}
}
Expand Down

0 comments on commit 19f5c23

Please sign in to comment.