feat(gddo-server): make log level configurable, default to info #660
Conversation
dominicbarnes
force-pushed
the
config-log-level
branch
from
6de209a to
f68fa17
Compare
|
This PR (HEAD: f68fa17) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/gddo/+/205607 to see it. Tip: You can toggle comments from me using the |
dominicbarnes
force-pushed
the
config-log-level
branch
from
f68fa17 to
1ed333a
Compare
|
This PR (HEAD: 1ed333a) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/gddo/+/205607 to see it. Tip: You can toggle comments from me using the |
|
This PR (HEAD: b36045e) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/gddo/+/205607 to see it. Tip: You can toggle comments from me using the |
This PR adds the ability to configure the log level for the server. Currently, the default is to log everything (including debug) which logs secrets like the github token and is a security risk.
This is similar to #554 but opts to integrate with viper to keep this consistent, in addition to allowing this to be set as a CLI flag.
Lastly, the default log level becomes "info" which is probably what most people want, and they can opt in to "debug" if needed when troubleshooting.