-
Notifications
You must be signed in to change notification settings - Fork 264
Add extra scopes #634
base: master
Are you sure you want to change the base?
Add extra scopes #634
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Adding missing scopes when creating an instance of the default client. Now that these are added, we can run the server with the service account without getting a permissions error
Signed the CLA ✔️ |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
This PR (HEAD: 288d53a) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/gddo/+/187097 to see it. Tip: You can toggle comments from me using the |
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/187097. |
This scopes are being suggested to use when configuring the remote api locally - https://cloud.google.com/appengine/docs/standard/go/tools/remoteapi/ so for consistency it would be great if this pull request could be merged |
Message from Andrew Bonventre: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/187097. |
Message from Jen O'Byrne: Patch Set 1: Hey Andrew Sorry the issue link wasn't clear enough! Here is the issue I raised: #631 and another issue I commented on I have given the service account all of the permissions as arnottcr said to give it but it doesn't work. I have given it the owner role, editor role and it still has the "must be an admin" error. I made these changes locally, and then I was able to start the GDDO server as it had the extra scopes that it was missing. Please don’t reply on this GitHub thread. Visit golang.org/cl/187097. |
Message from Go Bot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/187097. |
After trying to deploy this project with remote search enabled I encountered permissions errors when trying to run the gddo server.
I have tried granting the service account different roles (App Engine Admin, Cloud Datastore Owner, Storage Admin, Owner role) but whenever you start the gddo server it returns a 401 error -
error creating server:open database: unable to contact server: bad response 401; body: "You must be logged in as an administrator to access this.\n"
I think this is happening because the Default client is missing these two scopes