-
Notifications
You must be signed in to change notification settings - Fork 1k
Set CGO_ENABLED=1 for OS X builds in hack/build-all script #1839
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
1 similar comment
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it! |
CLAs look good, thanks! |
1 similar comment
CLAs look good, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great - thank you!
What does this do / why do we need it?
This change sets
CGO_ENABLED=1
in thehack/build-all
script if building for OS X on OS X. This will help address the DNS issues that occur in the non-CGO, Mac dep binary. See the issue below for more details.What should your reviewer look out for in this PR?
Do you need help or clarification on anything?
No.
Which issue(s) does this PR fix?
#1838