Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

Set CGO_ENABLED=1 for OS X builds in hack/build-all script #1839

Merged
merged 4 commits into from
May 2, 2018

Conversation

yolken-stripe
Copy link
Contributor

@yolken-stripe yolken-stripe commented May 1, 2018

What does this do / why do we need it?

This change sets CGO_ENABLED=1 in thehack/build-all script if building for OS X on OS X. This will help address the DNS issues that occur in the non-CGO, Mac dep binary. See the issue below for more details.

What should your reviewer look out for in this PR?

Do you need help or clarification on anything?

No.

Which issue(s) does this PR fix?

#1838

@yolken-stripe yolken-stripe requested a review from sdboyer as a code owner May 1, 2018 05:28
@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

1 similar comment
@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@yolken-stripe
Copy link
Contributor Author

I signed it!

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link
Collaborator

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels May 1, 2018
@yolken-stripe yolken-stripe changed the title Support configuring CGO_ENABLED in hack/build-all script Set CGO_ENABLED=1 for OS X builds in hack/build-all script May 2, 2018
Copy link
Member

@sdboyer sdboyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants