-
Notifications
You must be signed in to change notification settings - Fork 1k
Conversation
Following the discussion golang#1070 (comment) "Agreed, dep cannot currently be trusted to not make changes after the importers are run. The issue which tracks that is golang#908.", it is clear that the maintainers of the tool do not see it as a reliable project. As such, the users should be correctly informed about the status of the project and what are the goals in order to make it a production ready one.
To further explain the PR. I do not wish to diminish the efforts of the team behind this project. However, As such, I think that it's important for people to have a clear/correct picture of the status quo and as soon as the situation changes, that should also be reflected in the Readme. Thank you. |
We do see dep as a reliable, production-ready project, as we view that as mostly being a product of the main paths that people encounter in everyday use. Those paths are on
"currently be trusted" here may be a bit misleading. While we currently don't know why dep didn't use the rev you originally had there (using All that said, i've pushed a change to the README that acknowledges the issues with |
@ScottMansfield which part of that frustrates you? |
First impressions are hard to shake, so I think your approach of defining "production ready" as |
indeed, they are hard to shake. we could consider making there's a line to walk here, though. right now, it looks like there's a bug/regression that's caused the mismatch in this particular case - #1070 (comment). maybe we just need to be a little more cautious with the importers. but these things happen, especially if you're riding HEAD - which is why we're trying to move away from recommending that, in favor of the released versions in #996. but, most importantly, it's not always a bug if the input from the tool can't be directly converted. either way, the gist of this PR is that an unfortunate combination of expectations and bugs came together and caused a poor experience for @dlsniper, within the specific, narrow span of time in which |
What does this do / why do we need it?
Following the discussion #1070 (comment)
"Agreed, dep cannot currently be trusted to not make changes after the importers are run.
The issue which tracks that is #908.", it is clear that the maintainers of
the tool do not see it as a reliable project.
As such, the users should be correctly informed about the status of the
project and what are the goals in order to make it a production ready one.
What should your reviewer look out for in this PR?
Correctly set the expectations of users in case I'm not aware of any further milestones.