dep cannot vendor dependencies that do not have Go source code #1306

davecheney · 2017-10-24T05:22:13Z

What version of `dep` are you using (`dep version`)?

What `dep` command did you run?

I am trying to convert a project that uses glide to vendor two repositories containing protocol buffer definitions. The abstract from glide.yaml is

hash: 2f5e7adae8a174aebf478c2aac823837001c82d40f647fd9da15be270739057c
updated: 2017-10-23T16:03:08.007589083-04:00
imports:
- name: github.com/envoyproxy/data-plane-api
  version: 5b29f002b44f3f6e3921bd3b4535aeb91f89e84a
- name: github.com/googleapis/googleapis
  version: 5c6df0cd18c6a429eab739fb711c27f6e1393366
- name: github.com/golang/protobuf
  version: ab9f9a6dab164b7d1246e0e688b0ab7b94d8553e
  subpackages:
  - jsonpb
  - proto
  - protoc-gen-go/descriptor
  - ptypes
  - ptypes/any
  - ptypes/duration
  - ptypes/struct
  - ptypes/timestamp
  - ptypes/wrappers

The two repositories in question are github.com/envoyproxy/data-plane-api and github.com/googleapis/googleapis. When I try to add

+
+[[constraint]]
+  name="github.com/envoyproxy/data-plane-api"
+  revision="5b29f002b44f3f6e3921bd3b4535aeb91f89e84a"
+
+[[constraint]]
+  name="github.com/googleapis/googleapis"
+  revision="5c6df0cd18c6a429eab739fb711c27f6e1393366"

dep ensure refuses to vendor the repositories

What did you expect to see?

those two repositories vendored into vendor/

What did you see instead?

% dep ensure
ensure Solve(): No versions of github.com/envoyproxy/data-plane-api met constraints:
        5b29f002b44f3f6e3921bd3b4535aeb91f89e84a: Could not introduce github.com/envoyproxy/data-plane-api@5b29f002b44f3f6e3921bd3b4535aeb91f89e84a, as its subpackage github.com/envoyproxy/data-plane-api does not contain usable Go code (*build.NoGoError).. (Package is required by (root).)
        master: Could not introduce github.com/envoyproxy/data-plane-api@master, as its subpackage github.com/envoyproxy/data-plane-api does not contain usable Go code (*build.NoGoError).. (Package is required by (root).)
        typo: Could not introduce github.com/envoyproxy/data-plane-api@typo, as it is not allowed by constraint 5b29f002b44f3f6e3921bd3b4535aeb91f89e84a from project github.com/heptio/zzz.

The text was updated successfully, but these errors were encountered:

markcampanelli · 2017-10-25T03:18:05Z

I hit same issue when trying to use dep to manage some non-Go build tools.

markuswustenberg · 2017-10-26T14:54:45Z

This also happens when fetching e.g. github.com/docker/docker, which doesn't have Go code in the root (since v0.9.1 at least):

$ dep ensure -v -add github.com/docker/docker       
Fetching sources...
(1/1) github.com/docker/docker

Root project is "code.uber.internal/infra/dep-no-go-code"
 1 transitively valid internal packages
 1 external packages imported from 1 projects
(0)   ✓ select (root)
(1)	? attempt github.com/docker/docker with 1 pkgs; 206 versions to try
(1)	    try github.com/docker/[email protected]
(2)	✗   github.com/docker/docker at v1.13.1 has problem subpkg(s):
(2)	  	github.com/docker/docker has err (*build.NoGoError); required by (root).
(1)	    try github.com/docker/[email protected]
(2)	✗   github.com/docker/docker at v1.13.0 has problem subpkg(s):
(2)	  	github.com/docker/docker has err (*build.NoGoError); required by (root).
(1)	    try github.com/docker/[email protected]
(2)	✗   github.com/docker/docker at v1.12.6 has problem subpkg(s):
(2)	  	github.com/docker/docker has err (*build.NoGoError); required by (root).
(1)	    try github.com/docker/[email protected]
(2)	✗   github.com/docker/docker at v1.12.5 has problem subpkg(s):
(2)	  	github.com/docker/docker has err (*build.NoGoError); required by (root).
(1)	    try github.com/docker/[email protected]
(2)	✗   github.com/docker/docker at v1.12.4 has problem subpkg(s):
(2)	  	github.com/docker/docker has err (*build.NoGoError); required by (root).
(1)	    try github.com/docker/[email protected]
(2)	✗   github.com/docker/docker at v1.12.3 has problem subpkg(s):
(2)	  	github.com/docker/docker has err (*build.NoGoError); required by (root).
(1)	    try github.com/docker/[email protected]
(2)	✗   github.com/docker/docker at v1.12.2 has problem subpkg(s):
(2)	  	github.com/docker/docker has err (*build.NoGoError); required by (root).
(1)	    try github.com/docker/[email protected]
(2)	✗   github.com/docker/docker at v1.12.1 has problem subpkg(s):
(2)	  	github.com/docker/docker has err (*build.NoGoError); required by (root).
(1)	    try github.com/docker/[email protected]
(2)	✗   github.com/docker/docker at v1.12.0 has problem subpkg(s):
(2)	  	github.com/docker/docker has err (*build.NoGoError); required by (root).
(1)	    try github.com/docker/[email protected]
(2)	✗   github.com/docker/docker at v1.11.2 has problem subpkg(s):
(2)	  	github.com/docker/docker has err (*build.NoGoError); required by (root).
(1)	    try github.com/docker/[email protected]
(2)	✗   github.com/docker/docker at v1.11.1 has problem subpkg(s):
(2)	  	github.com/docker/docker has err (*build.NoGoError); required by (root).
(1)	    try github.com/docker/[email protected]
(2)	✗   github.com/docker/docker at v1.11.0 has problem subpkg(s):
(2)	  	github.com/docker/docker has err (*build.NoGoError); required by (root).
(1)	    try github.com/docker/[email protected]
(2)	✗   github.com/docker/docker at v1.10.3 has problem subpkg(s):
(2)	  	github.com/docker/docker has err (*build.NoGoError); required by (root).
(1)	    try github.com/docker/[email protected]
(2)	✗   github.com/docker/docker at v1.10.2 has problem subpkg(s):
(2)	  	github.com/docker/docker has err (*build.NoGoError); required by (root).
(1)	    try github.com/docker/[email protected]
(2)	✗   github.com/docker/docker at v1.10.1 has problem subpkg(s):
(2)	  	github.com/docker/docker has err (*build.NoGoError); required by (root).
(1)	    try github.com/docker/[email protected]
(2)	✗   github.com/docker/docker at v1.10.0 has problem subpkg(s):
(2)	  	github.com/docker/docker has err (*build.NoGoError); required by (root).
(1)	    try github.com/docker/[email protected]
(2)	✗   github.com/docker/docker at v1.9.1 has problem subpkg(s):
(2)	  	github.com/docker/docker has err (*build.NoGoError); required by (root).
(1)	    try github.com/docker/[email protected]
(2)	✗   github.com/docker/docker at v1.9.0 has problem subpkg(s):
(2)	  	github.com/docker/docker has err (*build.NoGoError); required by (root).
(1)	    try github.com/docker/[email protected]
(2)	✗   github.com/docker/docker at v1.8.3 has problem subpkg(s):
(2)	  	github.com/docker/docker has err (*build.NoGoError); required by (root).
(1)	    try github.com/docker/[email protected]
(2)	✗   github.com/docker/docker at v1.8.2 has problem subpkg(s):
(2)	  	github.com/docker/docker has err (*build.NoGoError); required by (root).
(1)	    try github.com/docker/[email protected]
(2)	✗   github.com/docker/docker at v1.8.1 has problem subpkg(s):
(2)	  	github.com/docker/docker has err (*build.NoGoError); required by (root).
(1)	    try github.com/docker/[email protected]
(2)	✗   github.com/docker/docker at v1.8.0 has problem subpkg(s):
(2)	  	github.com/docker/docker has err (*build.NoGoError); required by (root).
(1)	    try github.com/docker/[email protected]
(2)	✗   github.com/docker/docker at v1.7.1 has problem subpkg(s):
(2)	  	github.com/docker/docker has err (*build.NoGoError); required by (root).
(1)	    try github.com/docker/[email protected]
(2)	✗   github.com/docker/docker at v1.7.0 has problem subpkg(s):
(2)	  	github.com/docker/docker has err (*build.NoGoError); required by (root).
(1)	    try github.com/docker/[email protected]
(2)	✗   github.com/docker/docker at v1.6.2 has problem subpkg(s):
(2)	  	github.com/docker/docker has err (*build.NoGoError); required by (root).
(1)	    try github.com/docker/[email protected]
(2)	✗   github.com/docker/docker at v1.6.1 has problem subpkg(s):
(2)	  	github.com/docker/docker has err (*build.NoGoError); required by (root).
(1)	    try github.com/docker/[email protected]
(2)	✗   github.com/docker/docker at v1.6.0 has problem subpkg(s):
(2)	  	github.com/docker/docker has err (*build.NoGoError); required by (root).
(1)	    try github.com/docker/[email protected]
(2)	✗   github.com/docker/docker at v1.5.0 has problem subpkg(s):
(2)	  	github.com/docker/docker has err (*build.NoGoError); required by (root).
(1)	    try github.com/docker/[email protected]
(2)	✗   github.com/docker/docker at v1.4.1 has problem subpkg(s):
(2)	  	github.com/docker/docker has err (*build.NoGoError); required by (root).
(1)	    try github.com/docker/[email protected]
(2)	✗   github.com/docker/docker at v1.4.0 has problem subpkg(s):
(2)	  	github.com/docker/docker has err (*build.NoGoError); required by (root).
(1)	    try github.com/docker/[email protected]
(2)	✗   github.com/docker/docker at v1.3.3 has problem subpkg(s):
(2)	  	github.com/docker/docker has err (*build.NoGoError); required by (root).
(1)	    try github.com/docker/[email protected]
(2)	✗   github.com/docker/docker at v1.3.2 has problem subpkg(s):
(2)	  	github.com/docker/docker has err (*build.NoGoError); required by (root).
(1)	    try github.com/docker/[email protected]
(2)	✗   github.com/docker/docker at v1.3.1 has problem subpkg(s):
(2)	  	github.com/docker/docker has err (*build.NoGoError); required by (root).
(1)	    try github.com/docker/[email protected]
(2)	✗   github.com/docker/docker at v1.3.0 has problem subpkg(s):
(2)	  	github.com/docker/docker has err (*build.NoGoError); required by (root).
(1)	    try github.com/docker/[email protected]
(2)	✗   github.com/docker/docker at v1.2.0 has problem subpkg(s):
(2)	  	github.com/docker/docker has err (*build.NoGoError); required by (root).
(1)	    try github.com/docker/[email protected]
(2)	✗   github.com/docker/docker at v1.1.2 has problem subpkg(s):
(2)	  	github.com/docker/docker has err (*build.NoGoError); required by (root).
(1)	    try github.com/docker/[email protected]
(2)	✗   github.com/docker/docker at v1.1.1 has problem subpkg(s):
(2)	  	github.com/docker/docker has err (*build.NoGoError); required by (root).
(1)	    try github.com/docker/[email protected]
(2)	✗   github.com/docker/docker at v1.1.0 has problem subpkg(s):
(2)	  	github.com/docker/docker has err (*build.NoGoError); required by (root).
(1)	    try github.com/docker/[email protected]
(2)	✗   github.com/docker/docker at v1.0.1 has problem subpkg(s):
(2)	  	github.com/docker/docker has err (*build.NoGoError); required by (root).
(1)	    try github.com/docker/[email protected]
(2)	✗   github.com/docker/docker at v1.0.0 has problem subpkg(s):
(2)	  	github.com/docker/docker has err (*build.NoGoError); required by (root).
(1)	    try github.com/docker/[email protected]
(2)	✗   github.com/docker/docker at v0.12.0 has problem subpkg(s):
(2)	  	github.com/docker/docker has err (*build.NoGoError); required by (root).
(1)	    try github.com/docker/[email protected]
(2)	✗   github.com/docker/docker at v0.11.1 has problem subpkg(s):
(2)	  	github.com/docker/docker has err (*build.NoGoError); required by (root).
(1)	    try github.com/docker/[email protected]
(2)	✗   github.com/docker/docker at v0.11.0 has problem subpkg(s):
(2)	  	github.com/docker/docker has err (*build.NoGoError); required by (root).
(1)	    try github.com/docker/[email protected]
(2)	✗   github.com/docker/docker at v0.10.0 has problem subpkg(s):
(2)	  	github.com/docker/docker has err (*build.NoGoError); required by (root).
(1)	    try github.com/docker/[email protected]
(1)	✓ select github.com/docker/[email protected] w/1 pkgs

Version:

$ dep version
dep:
 version     : devel
 build date  : 
 git hash    : 
 go version  : go1.9.1
 go compiler : gc
 platform    : darwin/amd64

sdboyer · 2017-10-27T03:49:07Z

yeah...this is tricky. i'm considering the possibility that we change the rules on required to not complain if the named packages lack Go code. alternatively, we could relax the "no go code" rule in general and consider any files that may possibly be usable to Go good enough to make a package "valid" for import. that would open up the possibility of false positives with real imports...but that seems a lot less likely to be a real problem than the false negatives being described here.

the only other alternative i can think of right now is something like #269, which is a whole other can of worms.

@markuswustenberg

This also happens when fetching e.g. github.com/docker/docker, which doesn't have Go code in the root (since v0.9.1 at least):

yeah, the design here implicitly expects that you give -add a package - not necessarily a project root - that is actually importable. this is one of those confounded expectations arising from bumping up against the model, again - folks are thinking, "i want to grab this down and just have it there so i can reference stuff from it," but dep's model is "you don't actually use these, so we're gonna get rid of it."

this is gonna be a point of friction for a while, unfortunately. the easiest way to make e.g. your editor's autocomplete work is to just trick it by also having that project on GOPATH - and by the time that we get around to adding the new storage area, loosely outlined here, i think most of this pain should go away. but it's gonna be a while.

markuswustenberg · 2017-10-27T07:25:10Z

Thanks for your answer @sdboyer.

alternatively, we could relax the "no go code" rule in general and consider any files that may possibly be usable to Go good enough to make a package "valid" for import.

In my view, any arbitrary binary is potentially usable by Go code, so that's seems a bit of an odd restriction. Maybe there could just be an option to override this behaviour?

yeah, the design here implicitly expects that you give -add a package - not necessarily a project root - that is actually importable

In this case, I'm trying to grab the docker client which is under github.com/docker/docker/client, but dep won't let me import that directly. Is there any way to get this working with the current tools?

sdboyer · 2017-10-27T13:42:21Z

In my view, any arbitrary binary is potentially usable by Go code, so that's seems a bit of an odd restriction.

the key here is the definition of "usable" - dep is, for now, primarily concerned with what is necessary to compile Go code. not generate; not run. it's nice when we can also capture those things, but for now, they're not our primary objective. that puts arbitrary binaries out of scope, unless i've missed something quite big about extensible compiler capabilities. (entirely possible!)

In this case, I'm trying to grab the docker client which is under github.com/docker/docker/client, but dep won't let me import that directly. Is there any way to get this working with the current tools?

dep ensure -add github.com/docker/docker/client

discordianfish · 2017-11-10T13:57:17Z

I have a related issue. Not sure if I should open a new issue for that though:
I'm building a Dockerfile and I want to add Gopkg.* first, then run dep ensure before I add the code in a next step. That's a common pattern which allows Docker to cache the dependency-install step, so that I don't have to run this every time I change the code. Due to the 'no go code' rule this isn't possible when using dep.

sdboyer · 2017-11-10T14:31:53Z

@discordianfish this issue is specifically about the case where there's no Go code in a dependency, which is different from having no Go code in the current project. dep ensure -vendor-only should cover your case.

discordianfish · 2017-11-10T14:40:45Z

Oh perfect, thanks! Sorry for the noise.

davecheney · 2017-11-10T21:41:56Z

Have a look at github.com/heptio/contour. I’m using the pattern you describe and it is working well.

…

On 11 Nov 2017, at 01:40, discordianfish ***@***.***> wrote: Oh perfect, thanks! Sorry for the noise. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

jhayotte · 2017-11-21T20:04:48Z

Hi @sdboyer,
I tried out to migrate from Glide to Dep and dependencies including a list of protofile like https://github.com/googleapis/googleapis/tree/master/google/api cannot be vendored.

Would be nice to have a workaround in the meantime. Many people are trying to use dep and are blocked by this issue :/

sdboyer · 2017-11-21T20:09:45Z

yeah, i don't see any problems with expanding the definition of required to cover this case. so we have a path to a solution - just, need the elbow grease to get it done.

krisnova · 2017-11-21T20:10:40Z

Happy to lend some commits while I am enjoying my time of being unemployed if you want to assign this or any other issues to me

jhayotte · 2017-11-22T19:40:10Z

Hi @sdboyer,

I can contribute to this issue as well. We just need to clarify your expectations.

Do you wish that we remove the constraint looking for *.go files? (IMO that's what we should do) or do we handle it as a warning?

dep/gps/pkgtree/pkgtree.go

Lines 219 to 226 in 13df556

    
           gofiles, err := filepath.Glob(filepath.Join(p.Dir, "*.go")) 
        
           if err != nil { 
        
           	return err 
        
           } 
        
           if len(gofiles) == 0 { 
        
           	return &build.NoGoError{Dir: p.Dir} 
        
           }

travisjeffery · 2017-11-23T05:02:24Z

Here's a PR for it #1398. Feedback welcome, thanks.

sdboyer · 2017-11-23T13:02:20Z

i'm delighted to see all the offers to help ❤️ ❤️ this is how these things get done!

but yeah, lemme clarify the requirements here.

we can't mess with ListPackages() in the way @jhayotte has outlined. that's fixing this problem by lying about the state of the world, and ListPackages() needs to not do that. we can't change what it reports in order to achieve a desired outcome in the solver; instead, we need to change the solver to deal with this more appropriately.

to the specifics. right now, the behavior of the solver is that:

if a target import path has either been included in the required list from Gopkg.toml, or if it's in an import statement (we do not currently differentiate between these two cases)
and that target import path does not exist within its containing project
or that target import path has any errors within its containing project
then consider it a failure condition

what we want to do here is tease apart actual import statements from Gopkg.toml's required. the behavior for imports should remain the same, but:

if a target import path has been given in the required list from Gopkg.toml
and that target import path does not exist within its containing project
or that target import path has an error OTHER THAN a *build.NoGoError
then consider it a failure condition

this achieves the outcome i described in an earlier comment: #1306 (comment)

there's going to be more work to do here. in addition to likely needing to update some of gps' tests, we'll want at least one new one to cover this particular path (and probably a few to cover combinations of conditions). crucially, we're also going to need to change how the hasherdoes its work, as we're changing the semantics of imports and required's so that they're no longer identical: we'll need to break them out into separate groups.

this change will also then entail a bump o the solver-version that you see in Gopkg.lock, which we'll have to do a little bit of footwork around, as i don't think we've accommodated that in dep yet.

johanbrandhorst · 2017-12-18T12:48:01Z

Lots of offers of work but I see no open PRs? Is anyone working on this at the moment? It's a blocker for our transition (and I unfortunately do not have spare cycles at this time 😞 ).

sdboyer · 2017-12-23T15:44:18Z

nope, nobody is on this at the moment, unfortunately. it involves solver changes, so it's a rather tricky task to take on.

* This does not include the code generators, such as gogen, because of an open issue in dep: golang/dep#1306. * This adds a new dependency that was not previously identified with glide: github.com/petar/GOLLRB

carolynvs · 2018-01-18T00:26:18Z

I am working on this, there was a lot of overlap between the changes needed for this and the transitive constraint prototype so I had a head start. 😀

* This does not include the code generators, such as gogen, because of an open issue in dep: golang/dep#1306. * This adds a new dependency that was not previously identified with glide: github.com/petar/GOLLRB

hamid-elaosta · 2018-04-26T15:04:11Z

@carolynvs This is an interesting point, because what you suggest above does not appear to be the behaviour, perhaps I'm missing something.

I have a Go project A, which I'm trying to vendor into another Go project B. From A I am using only a Proto Buf .proto file, which resides in a subpackage of A. I am vendoring the top-level package, not the sub-package, and I have no pruning or other cleanup/removal configured in my toml, yet dep insists it cannot vendor A because its sub-package (the one I'm getting the proto file from) does not contain Go code.

Is there an override I can use to vendor the entirety of project A? I had assumed vendoring its top-level would vendor it entirely, regardless if I'm using only a file from a sub-package in my B project.

carolynvs · 2018-04-26T15:14:46Z

@hamid-elaosta Here is an example of how I vendored the k8's codegen repos:

https://github.com/kubernetes-incubator/service-catalog/blob/e8bb45942117c3a653af4d8d45af31d62abb223d/Gopkg.toml#L13-L26

https://github.com/kubernetes-incubator/service-catalog/blob/e8bb45942117c3a653af4d8d45af31d62abb223d/Gopkg.toml#L81-L86

hamid-elaosta · 2018-04-26T15:46:28Z

@carolynvs Thanks for the links. Unfortunately neither seems to work (and dep complains about redundant prune options) I'm not sure if it's some combination of my project requirements that is preventing it but the error message didn't change.

The project I'm attempting to vendor is on a specific branch (non-master), the constraint is overridden with an SSH path because it's a private (corporate) git server, and my local copy was not go-g[o]t but git cloned (because go-get won't check out over ssh from our git server).

EDIT: I should add, dep ensure worked when I had a go file in the sub-package that contains the proto, but it was removed in a recent update to that project (it's now generated after checkout).

tangblue · 2018-05-16T08:12:54Z

Hit the same issue when trying to use dep to get HTML static file from another project.

mysugar · 2018-06-01T05:28:29Z

I tried to use dep to get github.com/spinlock/jemalloc-go which is a c project.
Then i update the Gopkg.toml file , here is my file

# [prune]
#   non-go = false
#   go-tests = true
#   unused-packages = true
required = ["github.com/spinlock/jemalloc-go"]
[[override]]
  name = "github.com/spinlock/jemalloc-go"
  revision = "26719b2ee6186ef794cd50b604f8d765d3be5a30"
[prune]

Then i got all files in my vendor dir. So the config worked for me.Hope it can help others.
My dep version is 0.4.1.

The only purpose at the moment is to allow vendoring of the SPDK source code into Go projects which manage dependencies with the "dep" tool. That tool is designed for Go projects and as a sanity check rejects any dependency which does not have at least one Go file, at least at the moment (golang/dep#1306). Change-Id: I22458d0895729ad7d8ea53e7541e9089da1d448a Signed-off-by: Patrick Ohly <[email protected]> Reviewed-on: https://review.gerrithub.io/416831 Tested-by: SPDK Automated Test System <[email protected]> Reviewed-by: Daniel Verkamp <[email protected]> Reviewed-by: Ben Walker <[email protected]>

ZhenhangTung · 2018-07-25T07:22:54Z

@zhexuany I think your problem is not related to this issue, and you could open a new issue or reach out to the community if this problem still bothers you.

The thing is subpackage session and sessionctx contains useable go code. Could you please help m out?

The context.go file in sessionctx package was created in this commit, which is on 22 Feb, so not sure if you was importing the version before this commit, since you didn't give us any conext or logs when dep was running.
From my understanding, useable go code doen't mean that you have some subpackages which contains go files, it means that there should be go files under this package.
Hope this could help you.

msolimans · 2018-08-02T20:20:46Z

tried to avoid pruning non-go files but did not work by just turning it off using non-go = false however removing root prune at all was good enough to do the magic for me and to include everything I want. didn't like to include unused-packages too but at least it is working for now

tico8 · 2018-12-13T11:55:50Z

dependencies that do not have Go source code

My case was solved by following options.
I wanted to get github.com/gogo/protobuf(do not have Go source) into "vender/".

[prune]
  go-tests = true
  unused-packages = true
  non-go = true
  
  [[prune.project]]
    name = "github.com/gogo/protobuf"
    non-go = false
    unused-packages = false

truongnmt · 2019-03-07T04:17:29Z

Solution from @tico8 works! However I wonder if I dep ensure, that changes will be lost?

ruijundeng · 2019-03-09T02:40:49Z

@carolynvs I am following how you construct your Gopkg.toml file for k8s dependencies. However, I still encountered this problem while trying to get k8s.io/client-go, k8s.io/api, k8s.io/apimachinery.

My Dep Version:

dep:
version : 0.5.0
build date :
git hash :
go version : go1.11.4
go compiler : gc
platform : linux/amd64
features : ImportDuringSolve=false

My Gopkg.toml (I've exhausted every combination, with or without prune):

required = ["k8s.io/client-go"] 
[[constraint]]                         
  name = "k8s.io/client-go"                            
  version = "kubernetes-1.11.1"
                          
[prune]                                  
  go-tests = true                                      
  unused-packages = true
                               
[[prune.project]]                        
    name = "k8s.io/client-go"                          
    non-go = false 
    unused-packages = false

Run Dep ensure -v
I got:

kubernetes-1.11.1: Could not introduce k8s.io/[email protected], as its subpackage k8s.io/client-go does not contain usable Go code (*build.NoGoError).. (Package is required by (root).)

sdboyer mentioned this issue Oct 26, 2017

Unclear why dep ensure -add adds a constraint #1313

Closed

rselbach mentioned this issue Nov 9, 2017

dep cannot vendor dependencies if parent isn't go-gettable #1363

Closed

travisjeffery mentioned this issue Nov 23, 2017

allow dirs that don't contain go files (fix #1306) #1398

Closed

shaban mentioned this issue Dec 17, 2017

Add uninstall script matthewmueller/joy#75

Open

dpetersen mentioned this issue Dec 25, 2017

Repo organization incompatible with go dep improbable-eng/grpc-web#116

Closed

font mentioned this issue Jan 6, 2018

Add repo-infra scripts to verify go source code kubernetes-retired/cluster-registry#167

Merged

carolynvs mentioned this issue Jan 17, 2018

Migrate from glide to dep for dependency management kubernetes-retired/service-catalog#1670

Merged

7 tasks

carolynvs mentioned this issue Jan 18, 2018

[WIP] Ignore NoGoCode errors from required packages #1545

Closed

5 tasks

shashidharatd mentioned this issue Feb 20, 2018

Migrate from glide to golang/dep and also bump vendor kubernetes-retired/federation#237

Merged

lawrencegripper mentioned this issue Feb 21, 2018

Move from Glide to Dep: dep ensure -add fails Azure/azure-sdk-for-go#1108

Closed

chespinoza mentioned this issue Apr 25, 2018

dep doesn't pull the whole cgo repo, main dynamic lib (so) is not being pulled #1823

Closed

m90 mentioned this issue May 5, 2018

Failed to get templates from project qor/admin when running dep init #1840

Closed

atombender mentioned this issue Jun 9, 2018

dep does not import kubernetes/client-go correctly #1207

Closed

pohly mentioned this issue Jun 26, 2018

go: empty Go package spdk/spdk#341

Closed

xmudrii mentioned this issue Jun 26, 2018

Add/decide on top level sections client-go/unofficial-docs#4

Open

ryanhofdotgov mentioned this issue Aug 13, 2018

Send test coverage for backend to codecov.io 18F/culper#669

Merged

andrewkroh mentioned this issue Aug 23, 2018

[Research] Migrate to golang/dep from govendor elastic/beats#8070

Closed

gammazero mentioned this issue Sep 30, 2018

Impossible to install with dep gammazero/nexus#150

Closed

cquon mentioned this issue Jan 16, 2019

Basic framework for writing and running CLI plugins docker/cli#1564

Merged

9 tasks

slintes mentioned this issue Feb 13, 2019

error while trying to vendor kubevirt api kubevirt/kubevirt#2017

Closed

alexeykazakov mentioned this issue Mar 22, 2019

Initial makefile and minishift setup redhat-developer/devconsole-git#2

Merged

This was referenced Apr 25, 2019

Develop logicmonitor/lm-sdk-go#8

Closed

Develop logicmonitor/lm-sdk-go#9

Merged

luluzhao mentioned this issue May 31, 2019

dep ensure -add .com/aws/aws-xray-sdk-go does not working aws/aws-xray-sdk-go#112

Closed

kevinburke closed this as completed Jun 9, 2019

Jun2016 mentioned this issue Jun 19, 2019

Update README.md sandvikcode/mockserver-client-go#13

Merged

jbrunner mentioned this issue Oct 16, 2019

Improve UI and add command line instructions vmware-archive/gangway#137

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

dep cannot vendor dependencies that do not have Go source code #1306

dep cannot vendor dependencies that do not have Go source code #1306

davecheney commented Oct 24, 2017 •

edited

Loading

markcampanelli commented Oct 25, 2017

markuswustenberg commented Oct 26, 2017 •

edited

Loading

sdboyer commented Oct 27, 2017

markuswustenberg commented Oct 27, 2017

sdboyer commented Oct 27, 2017

discordianfish commented Nov 10, 2017

sdboyer commented Nov 10, 2017

discordianfish commented Nov 10, 2017

davecheney commented Nov 10, 2017 via email

jhayotte commented Nov 21, 2017

sdboyer commented Nov 21, 2017

krisnova commented Nov 21, 2017

jhayotte commented Nov 22, 2017 •

edited

Loading

travisjeffery commented Nov 23, 2017 •

edited

Loading

sdboyer commented Nov 23, 2017 •

edited

Loading

johanbrandhorst commented Dec 18, 2017

sdboyer commented Dec 23, 2017

carolynvs commented Jan 18, 2018

hamid-elaosta commented Apr 26, 2018

carolynvs commented Apr 26, 2018

hamid-elaosta commented Apr 26, 2018 •

edited

Loading

tangblue commented May 16, 2018

mysugar commented Jun 1, 2018

ZhenhangTung commented Jul 25, 2018

msolimans commented Aug 2, 2018 •

edited

Loading

tico8 commented Dec 13, 2018

truongnmt commented Mar 7, 2019

ruijundeng commented Mar 9, 2019

dep cannot vendor dependencies that do not have Go source code #1306

dep cannot vendor dependencies that do not have Go source code #1306

Comments

davecheney commented Oct 24, 2017 • edited Loading

What version of dep are you using (dep version)?

What dep command did you run?

What did you expect to see?

What did you see instead?

markcampanelli commented Oct 25, 2017

markuswustenberg commented Oct 26, 2017 • edited Loading

sdboyer commented Oct 27, 2017

markuswustenberg commented Oct 27, 2017

sdboyer commented Oct 27, 2017

discordianfish commented Nov 10, 2017

sdboyer commented Nov 10, 2017

discordianfish commented Nov 10, 2017

davecheney commented Nov 10, 2017 via email

jhayotte commented Nov 21, 2017

sdboyer commented Nov 21, 2017

krisnova commented Nov 21, 2017

jhayotte commented Nov 22, 2017 • edited Loading

travisjeffery commented Nov 23, 2017 • edited Loading

sdboyer commented Nov 23, 2017 • edited Loading

johanbrandhorst commented Dec 18, 2017

sdboyer commented Dec 23, 2017

carolynvs commented Jan 18, 2018

hamid-elaosta commented Apr 26, 2018

carolynvs commented Apr 26, 2018

hamid-elaosta commented Apr 26, 2018 • edited Loading

tangblue commented May 16, 2018

mysugar commented Jun 1, 2018

ZhenhangTung commented Jul 25, 2018

msolimans commented Aug 2, 2018 • edited Loading

tico8 commented Dec 13, 2018

truongnmt commented Mar 7, 2019

ruijundeng commented Mar 9, 2019

davecheney commented Oct 24, 2017 •

edited

Loading

What version of `dep` are you using (`dep version`)?

What `dep` command did you run?

markuswustenberg commented Oct 26, 2017 •

edited

Loading

jhayotte commented Nov 22, 2017 •

edited

Loading

travisjeffery commented Nov 23, 2017 •

edited

Loading

sdboyer commented Nov 23, 2017 •

edited

Loading

hamid-elaosta commented Apr 26, 2018 •

edited

Loading

msolimans commented Aug 2, 2018 •

edited

Loading