Skip to content

Commit

Permalink
ssh: add hmac-sha2-512.
Browse files Browse the repository at this point in the history
  • Loading branch information
fbettag committed Mar 8, 2018
1 parent 85f9870 commit 712b88d
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
2 changes: 1 addition & 1 deletion ssh/common.go
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ var supportedHostKeyAlgos = []string{
// This is based on RFC 4253, section 6.4, but with hmac-md5 variants removed
// because they have reached the end of their useful life.
var supportedMACs = []string{
"[email protected]", "hmac-sha2-256", "hmac-sha1", "hmac-sha1-96",
"[email protected]", "hmac-sha2-512", "hmac-sha2-256", "hmac-sha1", "hmac-sha1-96",
}

var supportedCompressions = []string{compressionNone}
Expand Down
4 changes: 4 additions & 0 deletions ssh/mac.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import (
"crypto/hmac"
"crypto/sha1"
"crypto/sha256"
"crypto/sha512"
"hash"
)

Expand Down Expand Up @@ -49,6 +50,9 @@ var macModes = map[string]*macMode{
"[email protected]": {32, true, func(key []byte) hash.Hash {
return hmac.New(sha256.New, key)
}},
"hmac-sha2-512": {64, false, func(key []byte) hash.Hash {
return hmac.New(sha512.New, key)
}},
"hmac-sha2-256": {32, false, func(key []byte) hash.Hash {
return hmac.New(sha256.New, key)
}},
Expand Down

2 comments on commit 712b88d

@nathandfox
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why isn't this merged?

@ianlancetaylor
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use GitHub for changes. The place to discuss this change is https://golang.org/cl/98056. (I don't know the answer to your question.)

Please sign in to comment.