Skip to content

Commit

Permalink
main.star: drop z- prefix from port-wide builder groups
Browse files Browse the repository at this point in the history
This was added on the mistaken assumption that console groups are
ordered by name. They are not, they are ordered by creation.

Change-Id: I07ff03c394c11e25ba9b4f693a5977652f9d43d0
Reviewed-on: https://go-review.googlesource.com/c/build/+/558656
TryBot-Bypass: Michael Knyszek <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
  • Loading branch information
mknyszek committed Jan 26, 2024
1 parent d71770b commit 62fa988
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 26 deletions.
48 changes: 24 additions & 24 deletions generated/luci-milo.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -36453,7 +36453,7 @@ consoles {
}
}
consoles {
id: "z-port-darwin-amd64"
id: "port-darwin-amd64"
name: "all darwin/amd64"
builders {
name: "buildbucket/luci.golang.ci/gotip-darwin-amd64-nocgo"
Expand Down Expand Up @@ -38246,7 +38246,7 @@ consoles {
builder_view_only: true
}
consoles {
id: "z-port-darwin-arm64"
id: "port-darwin-arm64"
name: "all darwin/arm64"
builders {
name: "buildbucket/luci.golang.ci/gotip-darwin-arm64_11"
Expand Down Expand Up @@ -38827,7 +38827,7 @@ consoles {
builder_view_only: true
}
consoles {
id: "z-port-js-wasm"
id: "port-js-wasm"
name: "all js/wasm"
builders {
name: "buildbucket/luci.golang.ci/gotip-js-wasm"
Expand Down Expand Up @@ -39024,7 +39024,7 @@ consoles {
builder_view_only: true
}
consoles {
id: "z-port-linux-386"
id: "port-linux-386"
name: "all linux/386"
builders {
name: "buildbucket/luci.golang.ci/gotip-linux-386"
Expand Down Expand Up @@ -39449,7 +39449,7 @@ consoles {
builder_view_only: true
}
consoles {
id: "z-port-linux-amd64"
id: "port-linux-amd64"
name: "all linux/amd64"
builders {
name: "buildbucket/luci.golang.ci/gotip-linux-amd64"
Expand Down Expand Up @@ -41536,7 +41536,7 @@ consoles {
builder_view_only: true
}
consoles {
id: "z-port-linux-arm64"
id: "port-linux-arm64"
name: "all linux/arm64"
builders {
name: "buildbucket/luci.golang.ci/gotip-linux-arm64"
Expand Down Expand Up @@ -41745,7 +41745,7 @@ consoles {
builder_view_only: true
}
consoles {
id: "z-port-linux-ppc64"
id: "port-linux-ppc64"
name: "all linux/ppc64"
builders {
name: "buildbucket/luci.golang.ci/gotip-linux-ppc64-power10"
Expand Down Expand Up @@ -41942,7 +41942,7 @@ consoles {
builder_view_only: true
}
consoles {
id: "z-port-linux-ppc64le"
id: "port-linux-ppc64le"
name: "all linux/ppc64le"
builders {
name: "buildbucket/luci.golang.ci/gotip-linux-ppc64le"
Expand Down Expand Up @@ -42139,7 +42139,7 @@ consoles {
builder_view_only: true
}
consoles {
id: "z-port-linux-riscv64"
id: "port-linux-riscv64"
name: "all linux/riscv64"
builders {
name: "buildbucket/luci.golang.ci/gotip-linux-riscv64"
Expand Down Expand Up @@ -42336,7 +42336,7 @@ consoles {
builder_view_only: true
}
consoles {
id: "z-port-openbsd-amd64"
id: "port-openbsd-amd64"
name: "all openbsd/amd64"
builders {
name: "buildbucket/luci.golang.ci/gotip-openbsd-amd64"
Expand Down Expand Up @@ -42533,7 +42533,7 @@ consoles {
builder_view_only: true
}
consoles {
id: "z-port-solaris-amd64"
id: "port-solaris-amd64"
name: "all solaris/amd64"
builders {
name: "buildbucket/luci.golang.ci/gotip-solaris-amd64"
Expand Down Expand Up @@ -42730,7 +42730,7 @@ consoles {
builder_view_only: true
}
consoles {
id: "z-port-wasip1-wasm"
id: "port-wasip1-wasm"
name: "all wasip1/wasm"
builders {
name: "buildbucket/luci.golang.ci/gotip-wasip1-wasm_wasmtime"
Expand Down Expand Up @@ -43023,7 +43023,7 @@ consoles {
builder_view_only: true
}
consoles {
id: "z-port-windows-386"
id: "port-windows-386"
name: "all windows/386"
builders {
name: "buildbucket/luci.golang.ci/gotip-windows-386"
Expand Down Expand Up @@ -43232,7 +43232,7 @@ consoles {
builder_view_only: true
}
consoles {
id: "z-port-windows-amd64"
id: "port-windows-amd64"
name: "all windows/amd64"
builders {
name: "buildbucket/luci.golang.ci/gotip-windows-amd64"
Expand Down Expand Up @@ -44164,7 +44164,7 @@ consoles {
builder_view_only: true
}
consoles {
id: "z-port-windows-arm64"
id: "port-windows-arm64"
name: "all windows/arm64"
builders {
name: "buildbucket/luci.golang.ci/gotip-windows-arm64"
Expand Down Expand Up @@ -44361,7 +44361,7 @@ consoles {
builder_view_only: true
}
consoles {
id: "z-port-freebsd-riscv64"
id: "port-freebsd-riscv64"
name: "all freebsd/riscv64"
builders {
name: "buildbucket/luci.golang.ci/gotip-freebsd-riscv64"
Expand Down Expand Up @@ -44558,7 +44558,7 @@ consoles {
builder_view_only: true
}
consoles {
id: "z-port-linux-arm"
id: "port-linux-arm"
name: "all linux/arm"
builders {
name: "buildbucket/luci.golang.ci/gotip-linux-arm"
Expand Down Expand Up @@ -44755,7 +44755,7 @@ consoles {
builder_view_only: true
}
consoles {
id: "z-port-netbsd-arm"
id: "port-netbsd-arm"
name: "all netbsd/arm"
builders {
name: "buildbucket/luci.golang.ci/gotip-netbsd-arm"
Expand Down Expand Up @@ -44952,7 +44952,7 @@ consoles {
builder_view_only: true
}
consoles {
id: "z-port-netbsd-arm64"
id: "port-netbsd-arm64"
name: "all netbsd/arm64"
builders {
name: "buildbucket/luci.golang.ci/gotip-netbsd-arm64"
Expand Down Expand Up @@ -45149,7 +45149,7 @@ consoles {
builder_view_only: true
}
consoles {
id: "z-port-openbsd-ppc64"
id: "port-openbsd-ppc64"
name: "all openbsd/ppc64"
builders {
name: "buildbucket/luci.golang.ci/gotip-openbsd-ppc64"
Expand Down Expand Up @@ -45346,7 +45346,7 @@ consoles {
builder_view_only: true
}
consoles {
id: "z-port-openbsd-riscv64"
id: "port-openbsd-riscv64"
name: "all openbsd/riscv64"
builders {
name: "buildbucket/luci.golang.ci/gotip-openbsd-riscv64"
Expand Down Expand Up @@ -45543,7 +45543,7 @@ consoles {
builder_view_only: true
}
consoles {
id: "z-port-plan9-386"
id: "port-plan9-386"
name: "all plan9/386"
builders {
name: "buildbucket/luci.golang.ci/gotip-plan9-386"
Expand Down Expand Up @@ -45740,7 +45740,7 @@ consoles {
builder_view_only: true
}
consoles {
id: "z-port-plan9-amd64"
id: "port-plan9-amd64"
name: "all plan9/amd64"
builders {
name: "buildbucket/luci.golang.ci/gotip-plan9-amd64"
Expand Down Expand Up @@ -45937,7 +45937,7 @@ consoles {
builder_view_only: true
}
consoles {
id: "z-port-plan9-arm"
id: "port-plan9-arm"
name: "all plan9/arm"
builders {
name: "buildbucket/luci.golang.ci/gotip-plan9-arm"
Expand Down
4 changes: 2 additions & 2 deletions main.star
Original file line number Diff line number Diff line change
Expand Up @@ -1641,10 +1641,10 @@ def _define_go_ci():
console.gen()

# Emit builder groups for each port.
# These will appear last, since they're emitted last.
for port, builders in postsubmit_builders_by_port.items():
luci.list_view(
# Put "z" at the beginning to sort this at the bottom of the page.
name = "z-port-%s" % port.replace("/", "-"),
name = "port-%s" % port.replace("/", "-"),
title = "all %s" % port,
entries = builders,
)
Expand Down

0 comments on commit 62fa988

Please sign in to comment.