Skip to content

Commit

Permalink
cmd/watchflakes: do not exit in the case of a mismatch
Browse files Browse the repository at this point in the history
When watchflakes encountered a build with a mismatch between
a builder definition and the input revision it would log the error and
exit. This change changes the behavior to log that the mismatch exists
and skip the build. This was causing watchflakes to continuously exit
and never process builds past the point of the encountered mismatch.

Fixes golang/go#70091

Change-Id: Ic3e2957a8e501f6dfa8bbbc458db40f925a0877d
Reviewed-on: https://go-review.googlesource.com/c/build/+/623995
Reviewed-by: Michael Knyszek <[email protected]>
Auto-Submit: Carlos Amedee <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
TryBot-Bypass: Dmitri Shuralyov <[email protected]>
  • Loading branch information
cagedmantis authored and gopherbot committed Nov 1, 2024
1 parent f8f181a commit 58f5650
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion cmd/watchflakes/luci.go
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,10 @@ func (c *LUCIClient) GetBuildResult(ctx context.Context, repo string, builder Bu
case "go":
goCommit = c
default:
log.Fatalf("repo mismatch: %s %s %s", bRepo, repo, buildURL(id))
// go.dev/issue/70091 pointed out that failing because of a missmatch between builder definition
// and input version is suboptimal. Instead log the case and continue processing.
log.Printf("repo mismatch: %s %s %s", bRepo, repo, buildURL(id))
return nil
}
}
if commit == "" {
Expand Down

0 comments on commit 58f5650

Please sign in to comment.