Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MongoDB driver to 1.1.0, use correct import path #267

Merged
merged 2 commits into from
Aug 17, 2019

Conversation

zikaeroh
Copy link
Contributor

Fixes #263.
Fixes #237.

I could not completely remove the use of connstring due to the prevalence of Config.DatabaseName. ApplyURI does not expose ConnString.Database (or appear to even use it...).

MongoDB tests pass, but others will fail until #265 is merged.

Copy link
Member

@dhui dhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Could you rebase or merge from master so there are fewer failing tests?

@zikaeroh
Copy link
Contributor Author

Merged master; only the mssql tests seem to be failing.

@dhui dhui merged commit 97cfb4d into golang-migrate:master Aug 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants