Add MS SQL Server Support #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 404
💛 - Coveralls |
dhui
requested changes
May 20, 2019
database/mssql/mssql_test.go
Outdated
| Env: map[string]string{"ACCEPT_EULA": "Y", "SA_PASSWORD": saPassword, "MSSQL_PID": "Express"}, | ||
| PortRequired: true, ReadyFunc: isReady, | ||
| } | ||
| // Supported versions: https://www.mysql.com/support/supportedplatforms/database.html |
There was a problem hiding this comment.
Also add this link (lists available image tags) as a comment: https://mcr.microsoft.com/v2/mssql/server/tags/list
database/mssql/mssql.go
Outdated
| } else if err != nil { | ||
| return &database.Error{OrigErr: err, Err: "try lock failed", Query: []byte(query)} | ||
| } else { | ||
| return &database.Error{Err: fmt.Sprintf("try lock failed with error %v", lockErrorMap[int(status)]), Query: []byte(query)} |
There was a problem hiding this comment.
Also expose the actual mssql.ReturnStatus in case the mapping doesn't contain the return status.
database/mssql/mssql.go
Outdated
| ErrDatabaseDirty = fmt.Errorf("database is dirty") | ||
| ) | ||
|
|
||
| var lockErrorMap = map[int]string{ |
There was a problem hiding this comment.
Change this to map[mssql.ReturnStatus]string
dhui
approved these changes
May 21, 2019
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finished the work started by @bwiggs and added tests.