-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More consistent way of handling validation errors #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxisto
force-pushed
the
better-error-handling
branch
from
February 20, 2023 14:33
c6f4c37
to
8c124aa
Compare
This was
linked to
issues
Feb 20, 2023
Closed
oxisto
commented
Feb 20, 2023
oxisto
commented
Feb 20, 2023
oxisto
commented
Feb 20, 2023
oxisto
changed the title
More consistent way of handling composite errors
More consistent way of handling validation errors
Feb 20, 2023
oxisto
force-pushed
the
better-error-handling
branch
2 times, most recently
from
February 20, 2023 21:25
533550d
to
6d0139f
Compare
oxisto
force-pushed
the
better-error-handling
branch
from
February 20, 2023 22:01
a7bf269
to
f759348
Compare
oxisto
force-pushed
the
better-error-handling
branch
from
February 20, 2023 22:03
f759348
to
1cf3c71
Compare
mfridman
reviewed
Feb 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fantastic work!
The new error handling reads a lot better in my opinion and hopefully, in a few releases, we can drop the older error branch and build tags entirely.
mfridman
reviewed
Feb 21, 2023
mfridman
reviewed
Feb 21, 2023
mfridman
reviewed
Feb 21, 2023
mfridman
approved these changes
Feb 21, 2023
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the mess of the old
ValidationError
struct and replaces it with either multiple wrapped errors (in case of Go 1.20) or an implementation that emulates that behaviour using internal structs (on Go < 1.20).It also consistently aborts the validation process now if signature validation fails, which otherwise might lead to unexpected error situations.