Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize Prometheus metrics using OTEL #55

Merged
merged 5 commits into from
Jul 9, 2024
Merged

Standardize Prometheus metrics using OTEL #55

merged 5 commits into from
Jul 9, 2024

Conversation

sonnes
Copy link
Collaborator

@sonnes sonnes commented Jul 3, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.24%. Comparing base (ce74446) to head (7e47da7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
+ Coverage   98.34%   99.24%   +0.89%     
==========================================
  Files          47       29      -18     
  Lines        1030      661     -369     
==========================================
- Hits         1013      656     -357     
+ Misses         17        5      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonnes sonnes requested a review from ajatprabha July 4, 2024 05:15
@sonnes sonnes marked this pull request as ready for review July 4, 2024 05:29
@@ -0,0 +1,230 @@
package xkafkaprom

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make the package name simply as xprom/xkafka rather than xprom/xkafkaprom?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i want to avoid the name conflict while creating and configuring a producer/consumer.

Maybe we can use a convention like xprom* - xpromkafka, xpromdb, xpromsql etc.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have noticed this pattern in https://github.com/riverqueue/river

@sonnes sonnes requested a review from witochandra July 5, 2024 05:46
xprom/semconv/kafka.go Show resolved Hide resolved
xprom/xpromkafka/collector.go Show resolved Hide resolved
@sonnes sonnes merged commit 1446392 into main Jul 9, 2024
5 checks passed
@sonnes sonnes deleted the xprom branch July 9, 2024 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants