Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xkafka: Add retry middleware #44

Merged
merged 6 commits into from
Jun 12, 2024
Merged

xkafka: Add retry middleware #44

merged 6 commits into from
Jun 12, 2024

Conversation

sonnes
Copy link
Collaborator

@sonnes sonnes commented May 31, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.29%. Comparing base (f24974e) to head (c7c82a1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
+ Coverage   98.25%   98.29%   +0.04%     
==========================================
  Files          45       46       +1     
  Lines         975      999      +24     
==========================================
+ Hits          958      982      +24     
  Misses         17       17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonnes sonnes changed the title Draft: Add retry middleware xkafka: Add retry middleware Jun 11, 2024
@sonnes sonnes requested a review from ajatprabha June 11, 2024 05:38
Copy link
Contributor

@ajatprabha ajatprabha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nit picks, LGTM overall!

LGTM

xkafka/middleware/retry/retry.go Show resolved Hide resolved
xkafka/middleware/retry/retry.go Outdated Show resolved Hide resolved
@sonnes sonnes merged commit 5aeb0ca into main Jun 12, 2024
5 checks passed
@sonnes sonnes deleted the xkafka/retry branch June 12, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants