Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Repo feature #11

Merged
merged 18 commits into from
Oct 21, 2021
Merged

Add Repo feature #11

merged 18 commits into from
Oct 21, 2021

Conversation

punit-kulal
Copy link
Collaborator

@punit-kulal punit-kulal commented Apr 15, 2021

PUT /repositories/{repository_name} route implements an idempotent route to add or update(using force_update flag) a repository for albatross.
Have added corresponding tests.
yaml and flock dependencies have been added to support read, edit of underlying config files

@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2021

Codecov Report

Merging #11 (2613b4d) into master (60b7ecc) will decrease coverage by 0.32%.
The diff coverage is 72.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
- Coverage   73.60%   73.27%   -0.33%     
==========================================
  Files          17       21       +4     
  Lines         538      711     +173     
==========================================
+ Hits          396      521     +125     
- Misses        111      145      +34     
- Partials       31       45      +14     
Impacted Files Coverage Δ
pkg/helmcli/repository/adder.go 64.89% <64.89%> (ø)
api/repository/add.go 66.66% <66.66%> (ø)
api/repository/service.go 96.55% <96.55%> (ø)
pkg/helmcli/repository/client.go 100.00% <100.00%> (ø)

api/repository/add.go Outdated Show resolved Hide resolved
api/repository/add.go Show resolved Hide resolved
api/repository/add.go Outdated Show resolved Hide resolved
api/repository/service.go Outdated Show resolved Hide resolved
cmd/albatross/albatross.go Show resolved Hide resolved
pkg/helmcli/adder.go Outdated Show resolved Hide resolved
pkg/helmcli/adder.go Outdated Show resolved Hide resolved
pkg/helmcli/adder.go Outdated Show resolved Hide resolved
pkg/helmcli/adder.go Outdated Show resolved Hide resolved
pkg/helmcli/repository_client.go Outdated Show resolved Hide resolved
@kaustubhkurve
Copy link
Collaborator

Also, in the PR description, the route is mentioned as /repository/{repository-name}. However, it's /repositories/{repository-name}. You can update the description as well.

cmd/albatross/albatross.go Outdated Show resolved Hide resolved
api/repository/add.go Outdated Show resolved Hide resolved
api/repository/add.go Outdated Show resolved Hide resolved
api/repository/add.go Show resolved Hide resolved
api/repository/service.go Outdated Show resolved Hide resolved
cmd/albatross/albatross.go Outdated Show resolved Hide resolved
pkg/helmcli/adder.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@kaustubhkurve kaustubhkurve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A

@punit-kulal punit-kulal marked this pull request as ready for review October 21, 2021 07:34
@punit-kulal punit-kulal merged commit e81aced into master Oct 21, 2021
@punit-kulal punit-kulal deleted the feature/add-repo branch October 21, 2021 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants