Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add on message drop in events plugin #49

Merged
merged 3 commits into from
Mar 6, 2024

Conversation

VivekPipaliya23
Copy link

Proposed Changes

This PR will send message being dropped from the queue due to various reasons to events sidecar.
It will introduce on_message_drop hook in vmq_events_sidecar plugin.

Types of Changes

  • Bugfix (non-breaking change which fixes issue #XXXX)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, styles...)
  • DevOps (Build scripts, pipelines...)

Checklist

  • I have read the CODE_OF_CONDUCT.md document
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if needed)
  • Any dependent changes have been merged and published in related repositories
  • I have updated changelog (At the bottom of the release version)
  • I have squashed all my commits into one before merging

@dhruvjain99
Copy link
Member

Two minor comments. Rest looks fine to me.

@VivekPipaliya23 VivekPipaliya23 force-pushed the feat/add-on-message-drop-in-events-plugin branch from 6134bfd to e497b6e Compare March 6, 2024 06:28
@dhruvjain99 dhruvjain99 merged commit 3e1e0d2 into main Mar 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants