Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add topic metrics to on_deliver and on_delivery_complete events #42

Merged

Conversation

VivekPipaliya23
Copy link

Proposed Changes

This will add topic level metrics to on_deliver and on_delivery_complete events.
propagate those matched_acl record to events sidecar.

Types of Changes

  • Bugfix (non-breaking change which fixes issue #XXXX)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, styles...)
  • DevOps (Build scripts, pipelines...)

Checklist

  • I have read the CODE_OF_CONDUCT.md document
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if needed)
  • Any dependent changes have been merged and published in related repositories
  • I have updated changelog (At the bottom of the release version)
  • I have squashed all my commits into one before merging

@VivekPipaliya23 VivekPipaliya23 force-pushed the feat/add-topic-metrics-to-on-deliver-and-complete-events branch from 6e04ef2 to dced388 Compare February 9, 2024 08:26
apps/vmq_server/src/vmq_mqtt_fsm.erl Outdated Show resolved Hide resolved
apps/vmq_server/src/vmq_mqtt_fsm.erl Outdated Show resolved Hide resolved
apps/vmq_server/src/vmq_mqtt_fsm.erl Outdated Show resolved Hide resolved
apps/vmq_server/src/vmq_metrics.erl Outdated Show resolved Hide resolved
Copy link
Member

@dhruvjain99 dhruvjain99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dhruvjain99 dhruvjain99 merged commit 4dbb030 into main Feb 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants