forked from vernemq/vernemq
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: add topic metrics to on_deliver and on_delivery_complete events #42
Merged
dhruvjain99
merged 9 commits into
main
from
feat/add-topic-metrics-to-on-deliver-and-complete-events
Feb 16, 2024
Merged
Feat: add topic metrics to on_deliver and on_delivery_complete events #42
dhruvjain99
merged 9 commits into
main
from
feat/add-topic-metrics-to-on-deliver-and-complete-events
Feb 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VivekPipaliya23
force-pushed
the
feat/add-topic-metrics-to-on-deliver-and-complete-events
branch
from
February 9, 2024 08:26
6e04ef2
to
dced388
Compare
dhruvjain99
requested changes
Feb 12, 2024
dhruvjain99
requested changes
Feb 14, 2024
dhruvjain99
requested changes
Feb 15, 2024
dhruvjain99
approved these changes
Feb 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This will add topic level metrics to
on_deliver
andon_delivery_complete
events.propagate those
matched_acl
record to events sidecar.Types of Changes
Checklist
CODE_OF_CONDUCT.md
document