Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send topic label value to web-hook plugin #36

Merged
merged 12 commits into from
Jan 30, 2024
Merged

Send topic label value to web-hook plugin #36

merged 12 commits into from
Jan 30, 2024

Conversation

VivekPipaliya23
Copy link

Proposed Changes

Add match topic label value to on subscribe and publish events and send it to web hook plugin from events sidecar.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes issue #XXXX)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, styles...)
  • DevOps (Build scripts, pipelines...)

@VivekPipaliya23 VivekPipaliya23 self-assigned this Dec 15, 2023
@VivekPipaliya23 VivekPipaliya23 force-pushed the feat/send-topic-label-to-webhook branch 8 times, most recently from 25da293 to 81fd6e6 Compare December 20, 2023 15:03
@VivekPipaliya23 VivekPipaliya23 changed the base branch from main to feat/add-topic-level-metrics January 22, 2024 06:04
dhruvjain99
dhruvjain99 requested changes Jan 22, 2024
View reviewed changes
rebar.config Outdated Show resolved Hide resolved
apps/vmq_proto/proto/on_publish.proto Outdated Show resolved Hide resolved
apps/vmq_proto/proto/on_subscribe.proto Outdated Show resolved Hide resolved
apps/vmq_proto/proto/matched_acl.proto Outdated Show resolved Hide resolved
@VivekPipaliya23 VivekPipaliya23 force-pushed the feat/send-topic-label-to-webhook branch 2 times, most recently from 0e09d53 to f901412 Compare January 24, 2024 06:07
@VivekPipaliya23 VivekPipaliya23 changed the base branch from feat/add-topic-level-metrics to main January 24, 2024 06:08
dhruvjain99
dhruvjain99 requested changes Jan 24, 2024
View reviewed changes
apps/vmq_enhanced_auth/src/vmq_enhanced_auth.erl Outdated Show resolved Hide resolved
apps/vmq_enhanced_auth/src/vmq_enhanced_auth.erl Outdated Show resolved Hide resolved
apps/vmq_enhanced_auth/src/vmq_enhanced_auth.erl Outdated Show resolved Hide resolved
apps/vmq_enhanced_auth/src/vmq_enhanced_auth.erl Outdated Show resolved Hide resolved
apps/vmq_enhanced_auth/src/vmq_enhanced_auth.erl Outdated Show resolved Hide resolved
apps/vmq_server/src/vmq_mqtt5_fsm.erl Outdated Show resolved Hide resolved
@VivekPipaliya23 VivekPipaliya23 force-pushed the feat/send-topic-label-to-webhook branch 2 times, most recently from b1aa108 to 7702a77 Compare January 27, 2024 12:50
dhruvjain99
dhruvjain99 approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@dhruvjain99 dhruvjain99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dhruvjain99 dhruvjain99 merged commit ef1ce39 into main Jan 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvjain99 dhruvjain99 dhruvjain99 approved these changes

Assignees

@VivekPipaliya23 VivekPipaliya23

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VivekPipaliya23 @dhruvjain99