Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update multi-connection mode connect logic #37

Merged
merged 9 commits into from
Jan 31, 2024

Conversation

ajatprabha
Copy link
Member

@ajatprabha ajatprabha commented Jan 30, 2024

  • Handle multiConnRevision edge cases
    • Only bump if at least on client connects, keep retrial on the rest
    • Skip version bump and disconnect all in case no clients connect at all
  • Update stored clients iff newClients are non-empty

@ajatprabha ajatprabha changed the title Update multi-connection mode connect logic Draft: Update multi-connection mode connect logic Jan 30, 2024
@ajatprabha ajatprabha force-pushed the update-multi-connection-logic branch from ef26735 to dc0a599 Compare January 31, 2024 07:51
@ajatprabha ajatprabha changed the title Draft: Update multi-connection mode connect logic Update multi-connection mode connect logic Jan 31, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (32871d5) 100.00% compared to head (fa9c4cf) 99.70%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##              main      #37      +/-   ##
===========================================
- Coverage   100.00%   99.70%   -0.30%     
===========================================
  Files           32       32              
  Lines          660      681      +21     
===========================================
+ Hits           660      679      +19     
- Misses           0        2       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ajatprabha ajatprabha merged commit 133b7e9 into main Jan 31, 2024
3 checks passed
@ajatprabha ajatprabha deleted the update-multi-connection-logic branch January 31, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants