Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop unsupported versions and Add new versions #90

Merged
merged 5 commits into from
Sep 19, 2019

Conversation

hirokinko
Copy link
Contributor

  • Add support for Django 2.0 or higher
  • Add support for Python 3.7
  • Drop support for Django (1.10 or lower)
  • Drop support for Python (2.6, 3.3)
  • Use tox to run tests and env matrix.

@coveralls
Copy link

Coverage Status

Coverage decreased (-5.4%) to 86.441% when pulling 679a6e4 on uncovertruth:drop_unsupported_versions into 94ff6e1 on goinnn:master.

@hirokinko
Copy link
Contributor Author

@goinnn Does this pull request have any problem?

@benzkji
Copy link

benzkji commented Oct 28, 2018

would be great to have an up to date version of django-multiselectfield

@wolph
Copy link

wolph commented Jan 30, 2019

As a temporary workaround you can install this git version through pip like this:

pip install 'git+https://github.com/uncovertruth/django-multiselectfield.git@drop_unsupported_versions#egg=django-multiselectfield' 

@karolyi
Copy link
Contributor

karolyi commented Feb 18, 2019

@hirokinko the PR is failing because you added code that lowered code coverage. add more tests covering the new lines and your PR will not fail.

@tomasgarzon
Copy link
Collaborator

Thanks @hirokinko for this great contribution, could you add some additional test in order to increase the coverage? This PR is failing and we need to fix it before merging to master.

@tomasgarzon tomasgarzon merged commit 72177cc into goinnn:master Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants