Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Django 2.0 #77

Closed
wants to merge 2 commits into from
Closed

Support Django 2.0 #77

wants to merge 2 commits into from

Conversation

blag
Copy link
Collaborator

@blag blag commented Jan 29, 2018

Closes #74.

@coveralls
Copy link

coveralls commented Jan 29, 2018

Coverage Status

Coverage increased (+0.1%) to 92.0% when pulling 3ea4abc on blag:django-2.0 into 94ff6e1 on goinnn:master.

@Lyla-Fischer
Copy link

Lyla-Fischer commented May 15, 2018

Some of the comments on this question seem to indicate that this might be an error in the migration files.

If the main change is in multiselectfield/db/fields.py:105 value = self._get_val_from_obj(obj), it kind of makes sense that there might be a migration error somewhere.

@Lyla-Fischer
Copy link

I have some changes here that allow for the example app to run using django 2.0 and runserver. The tests still fail in the same way, but it might be a hint as to what is going wrong.

@Lyla-Fischer
Copy link

I upvoted this question which seems to have the same issue that we are running into. There's no solution posted.

@chlab
Copy link

chlab commented Jun 15, 2018

May I ask what the status is of this branch?

@olivierdalang
Copy link
Contributor

@blag Isn't it value_from_object rather than val_from_object ?
With Django 2.2, I get 'MultiSelectField' object has no attribute 'val_from_object'...

@tomasgarzon
Copy link
Collaborator

Hi @blag , please check Travis errors, there seems to be several errors with some Django Version

@jayvdb
Copy link

jayvdb commented Oct 5, 2020

It appears this has been fixed.

@jayvdb
Copy link

jayvdb commented Dec 26, 2021

ping @goinnn / @blag . This can be closed?

@blag blag closed this May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CommandError: Unable to serialize database: 'MultiSelectField' object has no attribute '_get_val_from_obj'
7 participants