Return MSFList, not plain list, from form field #118
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes
MultiSelectFormField
to return the proper type -MSFList
instead oflist
.Consider this model:
Whenever a user edits an instance of this model through the admin (default ModelAdmin is sufficient for testing) without editing the multiselect field, the second assertion will fail.
While no sane person will actually perform such assertions in model
save
, audit-logging libraries (like https://github.com/jazzband/django-auditlog) may report false changes based on unequal string representation.