Skip to content
This repository has been archived by the owner on Jul 5, 2021. It is now read-only.

New theme: hugotube #326

Closed
marcanuy opened this issue Jan 24, 2018 · 5 comments
Closed

New theme: hugotube #326

marcanuy opened this issue Jan 24, 2018 · 5 comments

Comments

@marcanuy
Copy link

Theme inspired by Youtube layout.

https://github.com/marcanuy/hugotube

@digitalcraftsman
Copy link
Member

digitalcraftsman commented Mar 11, 2018

Hi Marcelo,

excuse the late response. Due to university I had to take a step back from the maintenance of this repo. Nonetheless, thanks for sharing your theme with us.

I've tested hugotube with the build script for Hugo's theme site and noticed a few issues:

marcanuy added a commit to marcanuy/hugotube that referenced this issue Mar 12, 2018
@marcanuy
Copy link
Author

Hey @digitalcraftsman, thanks for the tips.

I've added the MIME type but not sure about the other suggestion:

please use http(s)://www.example.com as base url in the [example config]

I already have baseURL = "https://marcanuy.github.io/hugotube", i.e.: the Github pages URI.

@digitalcraftsman
Copy link
Member

I already have baseURL = "https://marcanuy.github.io/hugotube", i.e.: the Github pages URI.

After reflecting this I came to the conclusion that the chance of an abuse in this setup is quite low compared to an external website (i.e. outside of GitHub). So forget my comment from above.

However, it the demo looks still unstyled because style.css can't be fetched. In order to get your theme running an asset pipeling is required to compile the SASS stylesheet, right?

Hugo doesn't execute any further commands in order to generate the demo. Therefore, there has to be a compiled style.css in the repo (at least for the demo).

marcanuy added a commit to marcanuy/hugotube that referenced this issue Mar 16, 2018
@marcanuy
Copy link
Author

Done.

@digitalcraftsman
Copy link
Member

Your theme should appear soon on Hugo's theme site. Furthermore, I'll promote your theme on Hugo's official Twitter account.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants