Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for Go 1.16 #8015

Merged
merged 9 commits into from
Feb 18, 2021
Merged

Prepare for Go 1.16 #8015

merged 9 commits into from
Feb 18, 2021

Conversation

bep
Copy link
Member

@bep bep commented Dec 3, 2020

No description provided.

@regisphilibert
Copy link
Member

at last! I'm excited!

@bep bep force-pushed the go116-upgrade branch 2 times, most recently from 8a6f6bd to c6789c4 Compare January 29, 2021 16:53
@bep
Copy link
Member Author

bep commented Feb 1, 2021

@anthonyfok this PR will make Hugo >= Go 1.16 only, hope that's not creating too much noise, as these upgrades are to valuable to delay.

@anthonyfok
Copy link
Member

anthonyfok commented Feb 1, 2021

@bep Thanks for the heads-up!

The upcoming Debian 11 (bullseye) is about to enter Soft Freeze very soon on Feb 12, and major changes will no longer be allowed (see https://release.debian.org/bullseye/freeze_policy.html), so Go 1.15 and Hugo 0.80.0 will indeed be the final versions that gets released in Debian 11.

So, both you and the Go team have good timing!

Debian package will stay at 0.80.0 and become somewhat stagnant for the next few months until Debian 11 is released, to prevent accidents from happening like during the Debian 10 freeze when Go packages in "testing" and "unstable" were not in sync (my mistakes)...

Maybe I'll try to keep the package up-to-date in debian/experimental.
Or perhaps I should go and fix the Snap package. snapcraft.yaml definitely needs upgrading to v2 or something like that.

@bep
Copy link
Member Author

bep commented Feb 1, 2021

@anthonyfok if you think it would be a good idea to push a new Hugo version with the latest JS fixes, we can do that. I'm not sure when Go 1.16 final version is out, but I plan to do a release when that happens. Also to get a Apple M1 build out the door.

@anthonyfok
Copy link
Member

@anthonyfok if you think it would be a good idea to push a new Hugo version with the latest JS fixes, we can do that. I'm not sure when Go 1.16 final version is out, but I plan to do a release when that happens. Also to get a Apple M1 build out the door.

@bep Thank you for your kind offer! We are OK on the Debian side: it was easy enough to cherry-pick #8198, and I have already uploaded it to Debian

hugo (0.80.0-4) unstable; urgency=medium

  * Revert "Include a local copy of github.com/evanw/esbuild v0.8.17"
  * Cherry-pick "deps: Update to esbuild v0.8.39" from upstream.
    See https://github.com/gohugoio/hugo/pull/8198
    Thanks to Bjørn Erik Pedersen (hugo) and Evan Wallace (esbuild)
    for resolving this issue!
  * Bump dependency on golang-github-evanw-esbuild-dev to (>= 0.8.39)

 -- Anthony Fok <[email protected]>  Mon, 01 Feb 2021 23:48:43 -0700

Oh, wait, I just noticed that you said "JS fixes" (plural), so if you mean all other fixes since 2021-01-01, yes, that would be very nice! Thank you! 🙏

But only if it is not too much trouble for you, especially since it is so close to go1.16 release, and it is always trivial for me to package master (e.g. 0.8.0+git20210201) or cherry-pick more patches, both of which I have done with other Debian Go packages.

If you do decide to push one last go1.15-compatible release, probably a week from now, say, Feb 9 would be ideal. That may allow us to pick up some more fixes or new features (e.g. zsh and fish completion), while giving me enough time to upload Hugo to Debian before the Soft Freeze starting on Feb 12.

Thanks again!

/cc @eclipseo (even though Fedora follows a different release schedule, I thought you might be interested)

@bep
Copy link
Member Author

bep commented Feb 3, 2021

No, it was js FIX singular.

@bep
Copy link
Member Author

bep commented Feb 17, 2021

  • Update all build versions (Travis, Snap, Circle, GitHub)
  • Adjust the Darwin build => M1
  • Test build with new M1/ios target

@bep bep changed the title Work In Progress: Prepare for Go 1.16 Prepare for Go 1.16 Feb 18, 2021
@bep bep merged commit 29fb456 into gohugoio:master Feb 18, 2021
@jmooring jmooring mentioned this pull request May 27, 2021
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants