-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding shelan.org to showcase page #1831
Conversation
The original image was 2055px × 1252px, which was oversized and did not fit the required dimension of 600px × 400px (3:2 aspect ratio). To fix, the image was cropped and resized to the required dimension, and was further optimized: $ pngquant --nofs -v --speed 1 --quality 65-80 shelan-tn.png $ optipng -o7 -zm1-9 shelan-tn-or8.png $ mv shelan-tn-or8.png shelan-tn.png reducing its filesize from 334125 bytes to 26929 bytes. See #1831
The original image was 2055px × 1252px, which was oversized and did not fit the required dimension of 600px × 400px (3:2 aspect ratio). To fix, the image was cropped and resized to the required dimension, and was further optimized: $ pngquant --nofs -v --speed 1 --quality 65-80 shelan-tn.png $ optipng -o7 -zm1-9 shelan-tn-or8.png $ mv shelan-tn-or8.png shelan-tn.png reducing its filesize from 334125 bytes to 26929 bytes. See #1831
Thank you for handling the merging of Showcase-related pull requests! However, please double check to see the submitted thumbnail images in the pull requests to Showcase is sized at 600px × 400px, like all the other existing At my current location with not a not-too-fast Internet connection, I can see the original shelan-tn.png taking 5 to 10 times longer to load than other thumbnails. Also, due to its incorrect aspect ratio, the base of the image is not aligned, with the other two thumbnails on the same row, and will eventually create problems for the next row of thumbnails. Also, very often, we will need to optimize the submitted thumbnail image. Please see what I did in commit 8681a35. I usually use pngquant to change the submitted full-color (24-bit? 32-bit?) PNG image to an indexed-color image. At times, for images with lots of colors, I would convert it to JPEG, depending on the resulting visual quality and the resulting filesize. In the case of shelan-tn.png, the original file was reduced from 334125 bytes to 26929 bytes. Yes, the Showcase is growing rather quickly, and that is why we need to keep an eye on the thumbnail filesize, otherwise the Showcase page will soon become painfully slow to load. Many thanks for your help! :-) Anthony |
Hi @anthonyfok I strongly agree with your suggestions. It was my mistake that I have added the unmodified version of the thumbnail. Thank a lot for pointing it out. Best Regards, Shelan |
Hi @anthonyfok, it makes indeed sense to compress / optimize the images. Thank you for sharing your workflow and tools for the compression. I took a note for the next time 😄 I think we should add a note about thumbnail requirements here and reference it at the bottom of the showcase page. While editing the contribution page in docs: you added a few a days the file |
Hi @shelan, worry not, it was my mistake that I had procrastinated in putting up the necessary documentation in the right place. @digitalcraftsman, you are awesome! I love your addition of Showcase submission guideline to the |
@anthonyfok Thanks. It would be great if we only need to compress the thumbnails in the long run before merging additions to the showcase. |
The original image was 2055px × 1252px, which was oversized and did not fit the required dimension of 600px × 400px (3:2 aspect ratio). To fix, the image was cropped and resized to the required dimension, and was further optimized: $ pngquant --nofs -v --speed 1 --quality 65-80 shelan-tn.png $ optipng -o7 -zm1-9 shelan-tn-or8.png $ mv shelan-tn-or8.png shelan-tn.png reducing its filesize from 334125 bytes to 26929 bytes. See gohugoio#1831
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Adding shelan.org blog space to showcase page.