Added content_test.go to increase test coverage. #1823
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -35,10 +35,10 @@ import ( | |||
| "sync" | |||
| ) | |||
|
|
|||
| // Length of the summary that Hugo extracts from a content. | |||
| // SummaryLength of the summary that Hugo extracts from a content. | |||
|
As to commit message, see https://github.com/spf13/hugo/blob/master/CONTRIBUTING.md |
Started to increase coverage in Helper package. In the process, aslo a few minor changes have been applied to content.go. * Content.go has undergone a formatting refactor regarding comments * Unused function TruncateWords has been removed * RenderingContext's "mmark" has been changed to use MmarkRender * Content_test.go added to cover content.go's functionality
|
Commit fixed. I didn't fix the commits as a whole. Now I got it. Thanks! |
|
Yes, now it looks good (I modified your commit message slightly). Thanks for your contribution. Tests are very, very important. Merged in e95f3af |
|
Ahh thanks, I learned a lot from this. I'm working on the next batch already. I love writing tests actually. Cheers @bep! |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proper pull request. For all the conversation please see pull request #1812.