Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge of config from themes with sitemap configs panics #8724

Closed
bep opened this issue Jul 3, 2021 · 1 comment · Fixed by #8725
Closed

Merge of config from themes with sitemap configs panics #8724

bep opened this issue Jul 3, 2021 · 1 comment · Fixed by #8725
Assignees
@bep
Labels
Bug Outdated

Comments

@bep
Copy link
Member

bep commented Jul 3, 2021 •
edited
Loading 

panic: interface conversion: interface {} is config.Sitemap, not maps.Params
8:52:17 PM: goroutine 1 [running]:
8:52:17 PM: github.com/gohugoio/hugo/config.(*defaultConfigProvider).Merge(0xc00009ceb0, 0x0, 0x0, 0x1e39420, 0xc0001566c0)
8:52:17 PM: 	/root/project/hugo/config/defaultConfigProvider.go:224 +0xfd9
8:52:17 PM: github.com/gohugoio/hugo/hugolib.configLoader.collectModules.func1(0xc000540180, 0x23687f8, 0xc0005a0840)

This only happens when the target project does not have a sitemap config. I will double check that we don't have any other such non-map types.
@bep bep self-assigned this Jul 3, 2021
@bep bep added the Bug label Jul 3, 2021
@bep bep changed the title Merge of config from themes with site map configs panics Merge of config from themes with permalinks configs panics Jul 3, 2021
@bep bep changed the title Merge of config from themes with permalinks configs panics Merge of config from themes with sitemap configs panics Jul 3, 2021
@bep bep mentioned this issue Jul 3, 2021
Merged
bep added a commit to bep/hugo that referenced this issue Jul 3, 2021
@bep
Fix panic when theme has permalinks config
ea584b9 
Fixes gohugoio#8724
@bep bep closed this as completed in #8725 Jul 3, 2021
bep added a commit that referenced this issue Jul 3, 2021
@bep
Fix panic when theme has permalinks config
e451b98 
Fixes #8724
This was referenced Jul 5, 2021
Merged
Merged
@bot-actions bot-actions bot mentioned this issue Jul 7, 2021
Merged
@github-actions github-actions bot mentioned this issue Jul 16, 2021
Closed
This was referenced Jul 16, 2021
Closed
Closed
@github-actions github-actions bot mentioned this issue Jul 16, 2021
Merged
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bep bep

Labels
Bug Outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix panic when theme has permalinks config bep/hugo
1 participant
@bep