Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert the home.Pages change introduced in 0.57 #6238

Closed
bep opened this issue Aug 17, 2019 · 2 comments
Closed

Revert the home.Pages change introduced in 0.57 #6238

bep opened this issue Aug 17, 2019 · 2 comments
Assignees
@bep
Labels
Outdated
Milestone
v0.57.2

Comments

@bep
Copy link
Member

bep commented Aug 17, 2019

In 0.57 we change the behaviour of home.Pages to be in line with the other sections. This has created a lot noise and breakage in the wild.

We need to revert that change, but add a warning that we will change this in 0.58 and that you should consider using .Site.RegularPages if that is what you want.
@bep bep added this to the v0.57.2 milestone Aug 17, 2019
@bep bep self-assigned this Aug 17, 2019
@bep
Copy link
Member Author

bep commented Aug 17, 2019

Fixed in ab40ce6

@bep bep closed this as completed Aug 17, 2019
@bep bep mentioned this issue Aug 17, 2019
Closed
bep added a commit to bep/hugo that referenced this issue Aug 17, 2019
@bep
tpl: Avoid "home page warning" in RSS template
0f8a81f 
See gohugoio#6238
bep added a commit to bep/hugo that referenced this issue Aug 17, 2019
@bep
hugolib: Don't use the global warning logger
f54d474 
See gohugoio#6238
bep added a commit that referenced this issue Aug 17, 2019
@bep
tpl: Avoid "home page warning" in RSS template
564cf1b 
See #6238
bep added a commit that referenced this issue Aug 17, 2019
@bep
hugolib: Don't use the global warning logger
ea68160 
See #6238
bep added a commit that referenced this issue Aug 17, 2019
@bep
tpl: Use RegularPages for RSS template
88d6993 
This is in line with how it was in Hugo 0.56.

See #6238
@danielfdickinson danielfdickinson mentioned this issue Sep 1, 2019
Closed
svetlemodry referenced this issue in orianna-zzo/AllinOne Dec 8, 2019
@svetlemodry
Fix for home.Pages behaviour change in Hugo in version 0.58.0 and later
2d5dd34 
There was a change in Hugo in version 0.58.0 and later changing the behaviour of home.Pages value. This pull request fixes the AllinOne theme home page to behave same as prior the 0.58.0 version.
@fu-sen fu-sen mentioned this issue Dec 24, 2019
Merged
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bep bep

Labels
Outdated
Projects
None yet
Milestone
v0.57.2
Development

No branches or pull requests
1 participant
@bep