Finish the multilingual feature #2309
Comments
bep
added a commit
that referenced
this issue
Jul 29, 2016
It will get more involved in the build process in a minute. See #2309
bep
added a commit
that referenced
this issue
Jul 29, 2016
bep
added a commit
that referenced
this issue
Jul 29, 2016
Work In Progress! This commit makes a rework of the build and rebuild process to better suit a multi-site setup. This also includes a complete overhaul of the site tests. Previous these were a messy mix that were testing just small parts of the build chain, some of it testing code-paths not even used in "real life". Now all tests that depends on a built site follows the same and real production code path. See #2309
bep
added a commit
that referenced
this issue
Jul 30, 2016
It will get more involved in the build process in a minute. See #2309
bep
added a commit
that referenced
this issue
Jul 30, 2016
bep
added a commit
that referenced
this issue
Jul 31, 2016
Work In Progress! This commit makes a rework of the build and rebuild process to better suit a multi-site setup. This also includes a complete overhaul of the site tests. Previous these were a messy mix that were testing just small parts of the build chain, some of it testing code-paths not even used in "real life". Now all tests that depends on a built site follows the same and real production code path. See #2309
bep
added a commit
that referenced
this issue
Aug 1, 2016
Work In Progress! This commit makes a rework of the build and rebuild process to better suit a multi-site setup. This also includes a complete overhaul of the site tests. Previous these were a messy mix that were testing just small parts of the build chain, some of it testing code-paths not even used in "real life". Now all tests that depends on a built site follows the same and real production code path. See #2309
bep
added a commit
that referenced
this issue
Aug 2, 2016
Work In Progress! This commit makes a rework of the build and rebuild process to better suit a multi-site setup. This also includes a complete overhaul of the site tests. Previous these were a messy mix that were testing just small parts of the build chain, some of it testing code-paths not even used in "real life". Now all tests that depends on a built site follows the same and real production code path. See #2309
bep
added a commit
that referenced
this issue
Aug 4, 2016
It will get more involved in the build process in a minute. See #2309
bep
added a commit
that referenced
this issue
Aug 4, 2016
bep
added a commit
that referenced
this issue
Aug 4, 2016
Work In Progress! This commit makes a rework of the build and rebuild process to better suit a multi-site setup. This also includes a complete overhaul of the site tests. Previous these were a messy mix that were testing just small parts of the build chain, some of it testing code-paths not even used in "real life". Now all tests that depends on a built site follows the same and real production code path. See #2309 Closes #2211 Closes #477 Closes #1744
bep
added a commit
that referenced
this issue
Aug 4, 2016
And in the same go adjusted some minor parts of the language API: Add LanguagePrefix alias to Node and rename the Multilingual config section to Languages. See #2309
bep
added a commit
that referenced
this issue
Aug 4, 2016
And in the same go adjusted some minor parts of the language API: Add LanguagePrefix alias to Node and rename the Multilingual config section to Languages. See #2309
bep
added a commit
that referenced
this issue
Aug 4, 2016
tychoish
pushed a commit
to tychoish/hugo
that referenced
this issue
Aug 13, 2017
tychoish
pushed a commit
to tychoish/hugo
that referenced
this issue
Aug 13, 2017
This is needed to verify gohugoio#2309, but it closes a big hole in Hugo's automated tests. The loading of the config is now moved to `hugolib` and the same default settings are now used in production and tests. As Viper now uses Afero as its filesystem, we now can write fairly complete integration tests with ease. See gohugoio#2309
tychoish
pushed a commit
to tychoish/hugo
that referenced
this issue
Aug 13, 2017
tychoish
pushed a commit
to tychoish/hugo
that referenced
this issue
Aug 13, 2017
tychoish
pushed a commit
to tychoish/hugo
that referenced
this issue
Aug 13, 2017
tychoish
pushed a commit
to tychoish/hugo
that referenced
this issue
Aug 13, 2017
The current "rendering language" is needed outside of Site. This commit moves the Language type to the helpers package, and then used to get correct correct language configuration in the markdownify template func. This commit also adds two new template funcs: relLangURL and absLangURL. See gohugoio#2309
tychoish
pushed a commit
to tychoish/hugo
that referenced
this issue
Aug 13, 2017
tychoish
pushed a commit
to tychoish/hugo
that referenced
this issue
Aug 13, 2017
tychoish
pushed a commit
to tychoish/hugo
that referenced
this issue
Aug 13, 2017
And clean up the test. See gohugoio#2309
tychoish
pushed a commit
to tychoish/hugo
that referenced
this issue
Aug 13, 2017
tychoish
pushed a commit
to tychoish/hugo
that referenced
this issue
Aug 13, 2017
tychoish
pushed a commit
to tychoish/hugo
that referenced
this issue
Aug 13, 2017
Or: some more multilingual TODO-fixes. See gohugoio#2309
tychoish
pushed a commit
to tychoish/hugo
that referenced
this issue
Aug 13, 2017
And pull up common member vars like Tmpl and Multilinguage. Or: the final multilingual TODO-fixes. See gohugoio#2309
tychoish
pushed a commit
to tychoish/hugo
that referenced
this issue
Aug 13, 2017
Makes the templates simpler. See gohugoio#2309
tychoish
pushed a commit
to tychoish/hugo
that referenced
this issue
Aug 13, 2017
tychoish
pushed a commit
to tychoish/hugo
that referenced
this issue
Aug 13, 2017
tychoish
pushed a commit
to tychoish/hugo
that referenced
this issue
Aug 13, 2017
In a multi-language setup, before this commit the Node's Translations() method would return some "dummy nodes" that would point to the correct page (Permalink), but would not be the same as the node it points to -- it would not have the translated title etc. The node creation is, however, so mingled with rendering, whihc is too early to have any global state, so the nodes has to be split in a prepare and a render phase. This commits does that with as small a change as possible. This implementation is a temp solution until we fix gohugoio#2297. Updates gohugoio#2309
tychoish
pushed a commit
to tychoish/hugo
that referenced
this issue
Aug 13, 2017
Updates gohugoio#2309
tychoish
pushed a commit
to tychoish/hugo
that referenced
this issue
Aug 13, 2017
And some other minor fixes from code review. Updates gohugoio#2309
tychoish
pushed a commit
to tychoish/hugo
that referenced
this issue
Aug 13, 2017
tychoish
pushed a commit
to tychoish/hugo
that referenced
this issue
Aug 13, 2017
tychoish
pushed a commit
to tychoish/hugo
that referenced
this issue
Aug 13, 2017
So the Permalink gets correct when listing translations. I have also checked the other relevant places to make sure we do not overwrite node values we need later. Pointers can be tricky, but lesson learned is: A copy is cheap. Updates gohugoio#2309
tychoish
pushed a commit
to tychoish/hugo
that referenced
this issue
Aug 13, 2017
After a visual inspection to make (pretty) sure it is correct re multiple languages. Updates gohugoio#2309
tychoish
pushed a commit
to tychoish/hugo
that referenced
this issue
Aug 13, 2017
This commit also refines the partial rebuild logic, to make sure we do not do more work than needed. Updates gohugoio#2309
tychoish
pushed a commit
to tychoish/hugo
that referenced
this issue
Aug 13, 2017
tychoish
pushed a commit
to tychoish/hugo
that referenced
this issue
Aug 13, 2017
tychoish
pushed a commit
to tychoish/hugo
that referenced
this issue
Aug 13, 2017
|
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Just an issue tracking the work done in #2303
The text was updated successfully, but these errors were encountered: